From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rondra.lf-net.org (rondra.lf-net.org [188.68.36.203]) by mx.groups.io with SMTP id smtpd.web12.4610.1647913492683919357 for ; Mon, 21 Mar 2022 18:44:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@lf-net.org header.s=2021 header.b=LE1AdFoa; spf=pass (domain: lf-net.org, ip: 188.68.36.203, mailfrom: littlefox@lf-net.org) Received: from localhost (localhost [127.0.0.1]) by rondra.lf-net.org (Postfix) with ESMTP id 7ACEC5FDB5; Tue, 22 Mar 2022 01:44:50 +0000 (UTC) Authentication-Results: rondra.lf-net.org (amavisd-new); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=lf-net.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lf-net.org; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:references:in-reply-to:user-agent:subject:subject :from:from:date:date:received:received; s=2021; t=1647913490; x= 1649727891; bh=/OAYG319bVP5cUItz6HwVmdWxGiIqH2OEiU16ot4zeI=; b=L E1AdFoaVgSlajYi54kNcj3t+RZE+N/zxSAku+lTJY9+C2XlmYkN9Wd6ZauuAe+XN V1m+fHYlUptBb99W+XpLKESg4yhN10QfoPW/MvEI7Pk9il4dxaW0WF05VOciGGsh iiNysuiE1Xi8ptK5S3rBM33Y24rNo8t3lpgbSWfwCtwKwOzVUB4rYWn2m3vYo1qU Yib09dUYW8wn3MFCDGvHeTFdQuE/lUFYH5pci6GP906KiGkSs9D5+Mr8Xw7GHhWG xFKemRrJhOLghdov73PAd2mT4r40VnXQz6iKmCo4yQpOrSyJyh40pcDeNR8MZqhl 4IsTv5xEXe3hjv0FDn3aA== X-Virus-Scanned: Debian amavisd-new at rondra.lf-net.org Received: from rondra.lf-net.org ([127.0.0.1]) by localhost (rondra.lf-net.org [127.0.0.1]) (amavisd-new, port 10026) with LMTP id dI_yXnuNyxAO; Tue, 22 Mar 2022 01:44:50 +0000 (UTC) Received: from [IPv6:::1] (unknown [IPv6:2001:16b8:5507:d001:c26d:6540:dc1b:7b8e]) by rondra.lf-net.org (Postfix) with ESMTPSA id 1974B5FDB2; Tue, 22 Mar 2022 01:44:50 +0000 (UTC) Date: Tue, 22 Mar 2022 01:44:49 +0000 From: "Mara Sophie Grosch" To: devel@edk2.groups.io, hao.a.wu@intel.com Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css User-Agent: K-9 Mail for Android In-Reply-To: References: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Will do tomorrow (UTC+1), thanks for reviewing :) Am 22. M=C3=A4rz 2022 01:28:45 UTC schrieb "Wu, Hao A" = : >The change is good to me. > >Could you help to apply this change to the code in MdeModulePkg\Bus\Pci\Nv= mExpressPei\ as well? >Really sorry for missing the above comment in previous reply. > >Best Regards, >Hao Wu > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Mara >> Sophie Grosch via groups.io >> Sent: Tuesday, March 22, 2022 1:06 AM >> To: devel@edk2.groups.io; Wu, Hao A >> Subject: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for >> Cap.Css >>=20 >> Fix the check for NVMe command set being supported by the controller. >>=20 >> Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 = in that >> register, making the OVMF think the NVMe controller does not support NVM= e. >>=20 >> Uncovered by commit 9dd14fc91c174eae87fd122c7ac70073a363527f, which >> changed the number of bits included in the Css register from 4 to 8. >>=20 >> Signed-off-by: Mara Sophie Grosch >> --- >> MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c >> b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c >> index d87212ffb2..b90c48731c 100644 >> --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c >> +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.c >> @@ -761,7 +761,7 @@ NvmeControllerInit ( >> return Status; >> } >>=20 >> - if (Private->Cap.Css !=3D 0x01) { >> + if ((Private->Cap.Css & BIT0) =3D=3D 0) { >> DEBUG ((DEBUG_INFO, "NvmeControllerInit: the controller doesn't su= pport >> NVMe command set\n")); >> return EFI_UNSUPPORTED; >> } >> -- >> 2.35.1 >>=20 >>=20 >>=20 >>=20 > > > > > > --=20 Diese Nachricht wurde von meinem Android-Ger=C3=A4t mit K-9 Mail gesendet.