From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ma1-aaemail-dr-lapp03.apple.com (ma1-aaemail-dr-lapp03.apple.com [17.171.2.72]) by mx.groups.io with SMTP id smtpd.web10.10557.1595296427042166205 for ; Mon, 20 Jul 2020 18:53:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=hLEUjTh8; spf=pass (domain: apple.com, ip: 17.171.2.72, mailfrom: afish@apple.com) Received: from pps.filterd (ma1-aaemail-dr-lapp03.apple.com [127.0.0.1]) by ma1-aaemail-dr-lapp03.apple.com (8.16.0.42/8.16.0.42) with SMTP id 06L1dACa022117; Mon, 20 Jul 2020 18:53:45 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=lgmW7U8Hg7jeyhiEDEPeQVt65B3D7oh1RfRxB3HNpLE=; b=hLEUjTh80x0GT373ydwq1L6SWLWI7ZmnNs+IDqm2WPcf/c+y5yUBfrkGS8jcH/oqe68h FWSRT8kF+SpWqy7TyjjqhpwBcpt52Ump7FFs2e2F9imcTqODWi94wSkBSaa0ZOuPUi5d Sq6Uw8SJKTVq8V2/rqCJUc6KXUyq+JkuFk1Ocl3YvNBX9CiHqNeeVtu2/VsS5fmEud0K 67bqAHNiVQbuDfVs8euJ+qvdk16zdiNcGJnbvHCqEA0FRQh5WX1jwzzwyFOn2oT8Wxhe 5IgRrkbanMemyMx3pkTk/alZ2mOc/1oaFqeAMTUm50V5cHZiFcgYQ687/EGOYFvtiVh2 ww== Received: from rn-mailsvcp-mta-lapp03.rno.apple.com (rn-mailsvcp-mta-lapp03.rno.apple.com [10.225.203.151]) by ma1-aaemail-dr-lapp03.apple.com with ESMTP id 32c02u3d3c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 20 Jul 2020 18:53:45 -0700 Received: from rn-mailsvcp-mmp-lapp02.rno.apple.com (rn-mailsvcp-mmp-lapp02.rno.apple.com [17.179.253.15]) by rn-mailsvcp-mta-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPS id <0QDS00DSVQLKVU30@rn-mailsvcp-mta-lapp03.rno.apple.com>; Mon, 20 Jul 2020 18:53:44 -0700 (PDT) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp02.rno.apple.com by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) id <0QDS00Y00PRDHY00@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Mon, 20 Jul 2020 18:53:44 -0700 (PDT) X-Va-A: X-Va-T-CD: 421954f57d824491683834a3b8154b48 X-Va-E-CD: abc689c8dbf31225341f60396bcd51b3 X-Va-R-CD: 957f4327799c979987441c5c4157b258 X-Va-CD: 0 X-Va-ID: e48e4b55-38c6-4147-b29d-96f662aef31e X-V-A: X-V-T-CD: 421954f57d824491683834a3b8154b48 X-V-E-CD: abc689c8dbf31225341f60396bcd51b3 X-V-R-CD: 957f4327799c979987441c5c4157b258 X-V-CD: 0 X-V-ID: 542c7dd3-4c7a-4170-9979-c86d58aecbec X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-20_09:2020-07-20,2020-07-20 signatures=0 Received: from [17.235.12.190] (unknown [17.235.12.190]) by rn-mailsvcp-mmp-lapp02.rno.apple.com (Oracle Communications Messaging Server 8.1.0.5.20200312 64bit (built Mar 12 2020)) with ESMTPSA id <0QDS0034UQLENY00@rn-mailsvcp-mmp-lapp02.rno.apple.com>; Mon, 20 Jul 2020 18:53:42 -0700 (PDT) From: "Andrew Fish" Message-id: MIME-version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: [edk2-devel] File in the build question. I'm working on a smart git grep Date: Mon, 20 Jul 2020 18:53:37 -0700 In-reply-to: Cc: "devel@edk2.groups.io" , "lersek@redhat.com" To: "Jiang, Guomin" References: <39884c36-c42d-8718-f14b-d638e0cd1d69@redhat.com> <1622466A6176DB37.5128@groups.io> <725658cb-b4f1-0e8a-a5f8-117c4f23221d@redhat.com> X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-20_09:2020-07-20,2020-07-20 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_A2976FBF-BF09-4AE9-B6E4-D7EED210FB0A" --Apple-Mail=_A2976FBF-BF09-4AE9-B6E4-D7EED210FB0A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 20, 2020, at 6:18 PM, Jiang, Guomin wrot= e: >=20 > I would like that add BaseTols/Scripts/ to the PATH. >=20 > Usually, I use ```set PATH=3D%PATH%;%WORKSPACE%\BaseTools\Scripts``` to = add new directory to the environment variable. >=20 > But I suggest that we should judge if the last character in PATH variabl= e is ';' character and then add new directory. >=20 > Let me know what I can help you. I=E2=80=99m thinking I could file a bugzilla to add BaseTools/Scripts/ to = the path for edksetup.sh/edksetup.bat and then I can just contribute my Pyt= hon git extension to BaseTools/Scripts As Laszlo pointed out there is generic value having BaseTools/Scripts/ in= the path so I filed: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2859 Thanks, Andrew Fish >=20 >> -----Original Message----- >> From: devel@edk2.groups.io > On Behalf Of Laszlo >> Ersek >> Sent: Tuesday, July 21, 2020 3:55 AM >> To: Andrew Fish >; edk2-devel-= groups-io >> > >> Subject: Re: [edk2-devel] File in the build question. I'm working on a = smart git >> grep >>=20 >> On 07/18/20 22:23, Andrew Fish wrote: >>> Wanted to see if people are OK with adding BaseTools/Scripts/ to the p= ath >> when you run `. edksetuip.sh` or edksetup.bat? >>>=20 >>> If we do that and I add BaseTools/Scripts/git-pgrep then it will show = up as >> an extended git command. >>>=20 >>> I was thinking over time we could add git-edk2* git commands to help >> automate the process or maintainer workflow. >>>=20 >>> If people are OK with adding the path I can make a patch set to contri= bute >> git-pgrep, but I need some help with how to add the new path to >> edksetup.bat. >>=20 >> To be honest, I think edksetup.sh should add BaseTools/Scripts/ to the = PATH >> environment variable anyway. I find it a bit awkward to run >>=20 >> python BaseTools/Scripts/GetMaintainer.py -l ... >>=20 >> rather than just >>=20 >> GetMaintainer.py -l ... >>=20 >> Thanks >> Laszlo >>=20 >>=20 >>=20 --Apple-Mail=_A2976FBF-BF09-4AE9-B6E4-D7EED210FB0A Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jul 20, 2= 020, at 6:18 PM, Jiang, Guomin <guomin.jiang@intel.com> wrote:

I would like that add BaseTols/= Scripts/ to the PATH.

Usually, I use ```set PATH=3D%PATH%;%= WORKSPACE%\BaseTools\Scripts``` to add new directory to the environment var= iable.

But I suggest that we should judge if the last chara= cter in PATH variable is ';' character and then add new directory.
Let me know what I can help you.

I=E2=80=99m th= inking I could file a bugzilla to add BaseTools/Scripts/ to the path for ed= ksetup.sh/edksetup.bat and then I can just contribute my Python git extensi= on to BaseTools/Scripts

As Laszlo point= ed out there is generic value having  BaseTools/Scripts/ in the path s= o I filed: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2859<= /a>


Andrew Fish


-----Original Message-----
From: devel@edk2.groups.io = <devel@edk2.gr= oups.io> On Behalf Of Laszlo
Ersek
Sent:= Tuesday, July 21, 2020 3:55 AM
To: Andrew Fish <afish@apple.com>; edk2-devel= -groups-io
<devel@edk2.groups.io>
Subject: Re: [edk2-devel]= File in the build question. I'm working on a smart git
grep<= br class=3D"">
On 07/18/20 22:23, Andrew Fish wrote:
Wanted to see if people are OK = with adding BaseTools/Scripts/ to the path
when = you run `. edksetuip.sh` or edksetup.bat?

If we do that and I add BaseTools/Scripts/= git-pgrep then it will show up as
an extended gi= t command.

I was thinking over time we could add git-edk2* git commands to help
automate the process or maintainer workflow.

If people are OK= with adding the path I can make a patch set to contribute
git-pgrep, but I need some help with how to add the new path to<= br class=3D"">edksetup.bat.

To be honest, I th= ink edksetup.sh should add BaseTools/Scripts/ to the PATH
env= ironment variable anyway. I find it a bit awkward to run

 python BaseTools/Scripts/GetMaintainer.py -l ...

rather than just

 G= etMaintainer.py -l ...

Thanks
La= szlo



--Apple-Mail=_A2976FBF-BF09-4AE9-B6E4-D7EED210FB0A--