From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from IMSVA.IN.MEGATRENDS.COM (venus.amiindia.co.in [111.93.197.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 69C431A1E2F for ; Thu, 25 Aug 2016 01:43:55 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 465BB82055 for ; Thu, 25 Aug 2016 14:13:57 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 300FB8204A for ; Thu, 25 Aug 2016 14:13:56 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS for ; Thu, 25 Aug 2016 14:13:56 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Thu, 25 Aug 2016 14:13:49 +0530 From: Ramesh R. To: edk2-devel Thread-Topic: BootableImageSupportTest\StorageSecurityCommandProtocolTest Thread-Index: AdH+rBKMD33ErVHaTU69l2RWRNE5FA== Date: Thu, 25 Aug 2016 08:43:48 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.109] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1054-22534.006 X-TM-AS-Result: No--18.796-5.0-31-10 X-imss-scan-details: No--18.796-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1054-22534.006 X-TMASE-Result: 10--18.796500-10.000000 X-TMASE-MatchedRID: NtGK0Swcehs0+65nJzb9bEZakoam9+aemoKXVHfiMM/JYIv7y0tu9r+x r+LBXiQ/z1y1kXvqQsW+2XdvL8veTUTOAIv8Sn/UFYJUGv4DL3zBjPUmRFINAG3D6f6IpbLIvQ2 eKtTgS/AEfA4J9jLLt13QNqaa3g28ZF6ysdFjt0pVnniKh7YTC99WrDP4LKdpx7QfsswIVxXBGr i2x+GkHFehZ8JDMoGXa+5MR1psyWhqD9kNPFM9GDbN0t/c2qF2MrX+p1uNztAUtdRZTmEaIV2pa +aJMbyanFfNkmfs1AiyNm0/eGTGyjScgMqgJnG/EgwM8US/pTF9e88fgoklswwv1ZvdCH+FmPMv FiO40LCPL1kerA0y5Kstby4QSn9bHKtI0XZIf48OsNNBnlgRWn0tCKdnhB58r10pknZXGJp9j2G wzTE3vXkguuQorcgMM55ot+K0hp6zh0QXTbek6CUyxQLT+s4vkUElOYbo56V+3BndfXUhXQ== X-TMASE-SNAP-Result: 1.811037.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: BootableImageSupportTest\StorageSecurityCommandProtocolTest X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 08:43:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, When the we run the "BootableImageSupportTest\StorageSecurityCommandProt= ocolTest" test on the NVME devices we are getting into error because of the= below testing code. // // According to TCG definition, when the Security Protocol field is set= to 00h, and SP // Specific is set to 0000h in a TRUSTED RECEIVE command, return securi= ty protocol // information. This Command is not associated with a security send com= mand // Status =3D StorageSecurityCommand->ReceiveData ( StorageSecurityCommand, BlockIo->Media->MediaId, 100000000, // Tim= eout 10-sec 0, // Sec= urityProtocol 0, // Sec= urityProtocolSpecifcData 10, // Pay= loadBufferSize, DataBuffer, // Pay= loadBuffer &RcvDataSize ); // // for ATA8-ACS SecurityProtocol, 512 byte is a request // if (IsAtaDevice) { if((Status =3D=3D EFI_DEVICE_ERROR) || (Status =3D=3D EFI_WARN_BUFFER= _TOO_SMALL)){ AssertionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; } } else { if((!EFI_ERROR(Status)) || (Status =3D=3D EFI_WARN_BUFFER_TOO_SMALL))= { AssertionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; } } For Ata devices, EFI_DEVICE_ERROR considered as valid error case and for th= e Nvme ( Non ATA) device it's considered as error. Could you please let us = know why there is difference in this case ?. Thanks, Ramesh