From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from IMSVA.IN.MEGATRENDS.COM (venus.amiindia.co.in [111.93.197.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 108DE1A1F49 for ; Wed, 7 Sep 2016 22:11:50 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AFFD282047; Thu, 8 Sep 2016 10:42:00 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A311382046; Thu, 8 Sep 2016 10:42:00 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Thu, 8 Sep 2016 10:42:00 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Thu, 8 Sep 2016 10:41:42 +0530 From: Ramesh R. To: "Tian, Feng" , edk2-devel , "Jin, Eric" CC: Sandip Datta Roy , Srini Narayana , Sundaresan S Thread-Topic: BootableImageSupportTest\StorageSecurityCommandProtocolTest Thread-Index: AdH+rBKMD33ErVHaTU69l2RWRNE5FAAvq2BQAN3zvKAARX8+gABSqBWAAHcBbXAAnATWUA== Date: Thu, 8 Sep 2016 05:11:45 +0000 Message-ID: References: <7F1BAD85ADEA444D97065A60D2E97EE538825C19@SHSMSX101.ccr.corp.intel.com> <7F1BAD85ADEA444D97065A60D2E97EE566D84D98@SHSMSX101.ccr.corp.intel.com> <7F1BAD85ADEA444D97065A60D2E97EE566D868BC@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <7F1BAD85ADEA444D97065A60D2E97EE566D868BC@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.109] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1054-22562.005 X-TM-AS-Result: No--26.772-5.0-31-10 X-imss-scan-details: No--26.772-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1054-22562.005 X-TMASE-Result: 10--26.772200-10.000000 X-TMASE-MatchedRID: PL66URbwWA8ikhyG+/kfartSPxOEfQf+Ct59Uh3p/NUUtdRZTmEaIZCm 1SoZkCxTMXEn4M+GcWtQbzuGj0Jy0sApPMMdpxNFlVHM/F6YkvRWjiXAsVR2K5UQzHWBKOFAaWZ hr1gcIxIpBuTwKkPZjgKQaHsq1kaw9XO+v7tbdJBor4yxPAz7WSseSAhqf1rRKBTGF0djn/dOzs dyPcx3Se96JOlp7HKlW8bhEauEL7Cbd2EpmAf1jq/Zw8tRb535f0t3HDYyPxqynk7TnYzMunZru QG5/1P7O1552zf2RpRQ/XOWzPYsh4jQo/Iw2s1S4nbwqqmOd2m3m33HIJfYjZ0Koq3EzpuHPJ7f geSaCTB0bJJ3QAROLu+nyoMlaFu13lljvljtNt4bmaDSnOqZfmXSofv/sdGOyL0CMroLynW9DZ4 q1OBL8AR8Dgn2Msu3XdA2ppreDbyU4ete/ETR9Km4PbloS2C39pLnYtQ99xLnU40jhQv76qPFjJ EFr+ol4Z/vCGGy3v6v3atzxdEIK90H8LFZNFG7NwH7I8fAFRpYVPVogSjEZQ== X-TMASE-SNAP-Result: 1.811037.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 Subject: Re: BootableImageSupportTest\StorageSecurityCommandProtocolTest X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 05:11:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Feng, With the device we have , we tried 512 as size and all the devices retur= ns EFI_SUCCESS. Thanks, Ramesh -----Original Message----- From: Tian, Feng [mailto:feng.tian@intel.com]=20 Sent: 05 September 2016 08:48 To: Ramesh R.; edk2-devel; Jin, Eric Cc: Tian, Feng Subject: RE: BootableImageSupportTest\StorageSecurityCommandProtocolTest Ramesh, I suspect even if you send the buffer size as 512 all the devices should re= turn EFI_SUCCESS as well. As for different NVMe device behavior for length 10, it may be different un= derstanding on spec. Eric,=20 Do you know how to handle such case in SCT? Thanks Feng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Rame= sh R. Sent: Saturday, September 3, 2016 2:06 AM To: Tian, Feng ; edk2-devel ;= Jin, Eric Subject: Re: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocol= Test Hi Feng, Some Nvme devices returns EFI_DEVICE_ERROR for the SCT test code ( when the= buffer passed with 10 bytes) and that creates failure in the SCT report.=20 Some Nvme devices returns EFI_SUCCESS also.=20 All the devices return EFI_SUCCESS if the we send the buffer size as "Memor= y Page size Minimum (MPSMIN)" =20 Thanks, Ramesh -----Original Message----- From: Tian, Feng [mailto:feng.tian@intel.com]=20 Sent: 01 September 2016 8:12 To: Ramesh R.; edk2-devel; Jin, Eric Cc: Tian, Feng Subject: RE: BootableImageSupportTest\StorageSecurityCommandProtocolTest I checked the ATA spec, it says the transfer length of "Trust-Send" ATA cmd= should be 512. But for NVMe and other SCSI device, I didn't see any length limitation on "= Security Protocol In" cmd with security protocol field 0 and security proto= col specific field 0. It seems user could pass in any length value to get security protocol infor= mation. And last, user could get the whole one by passing down "supported s= ecurity protocol list length" + 8. Ramesh, do you meet real failure case? Eric, what's your opinion on this? Thanks Feng -----Original Message----- From: Ramesh R. [mailto:rameshr@ami.com]=20 Sent: Wednesday, August 31, 2016 1:20 AM To: Tian, Feng ; edk2-devel ;= Jin, Eric Subject: RE: BootableImageSupportTest\StorageSecurityCommandProtocolTest Hi Feng, Any update or suggestion on this? Can we consider this as SCT tool issue = and would be fixed in next version ? Thanks, Ramesh -----Original Message----- From: Tian, Feng [mailto:feng.tian@intel.com]=20 Sent: 26 August 2016 12:54 To: Ramesh R.; edk2-devel; Jin, Eric Cc: Tian, Feng Subject: RE: BootableImageSupportTest\StorageSecurityCommandProtocolTest Yes, I agree it's weird.=20 We are looking at this and will get back to you if we have findings. Thanks Feng -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Rame= sh R. Sent: Thursday, August 25, 2016 4:44 PM To: edk2-devel Subject: [edk2] BootableImageSupportTest\StorageSecurityCommandProtocolTest Hi, When the we run the "BootableImageSupportTest\StorageSecurityCommandProt= ocolTest" test on the NVME devices we are getting into error because of the= below testing code. // // According to TCG definition, when the Security Protocol field is set= to 00h, and SP // Specific is set to 0000h in a TRUSTED RECEIVE command, return securi= ty protocol // information. This Command is not associated with a security send com= mand // Status =3D StorageSecurityCommand->ReceiveData ( StorageSecurityCommand, BlockIo->Media->MediaId, 100000000, // Tim= eout 10-sec 0, // Sec= urityProtocol 0, // Sec= urityProtocolSpecifcData 10, // Pay= loadBufferSize, DataBuffer, // Pay= loadBuffer &RcvDataSize ); // // for ATA8-ACS SecurityProtocol, 512 byte is a request // if (IsAtaDevice) { if((Status =3D=3D EFI_DEVICE_ERROR) || (Status =3D=3D EFI_WARN_BUFFER= _TOO_SMALL)){ AssertionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; } } else { if((!EFI_ERROR(Status)) || (Status =3D=3D EFI_WARN_BUFFER_TOO_SMALL))= { AssertionType =3D EFI_TEST_ASSERTION_PASSED; } else { AssertionType =3D EFI_TEST_ASSERTION_FAILED; } } For Ata devices, EFI_DEVICE_ERROR considered as valid error case and for th= e Nvme ( Non ATA) device it's considered as error. Could you please let us = know why there is difference in this case ?. Thanks, Ramesh _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel