public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <leif@nuviainc.com>, Julien Grall <julien@xen.org>,
	nd <nd@arm.com>
Subject: Re: [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment
Date: Wed, 21 Jul 2021 08:24:30 +0000	[thread overview]
Message-ID: <FCD2FA1A-7692-41DB-A380-211768A223E4@arm.com> (raw)
In-Reply-To: <20210721081843.32164-1-philmd@redhat.com>

Hi Philippe,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 21/07/2021, 09:19, "Philippe Mathieu-Daudé" <philmd@redhat.com> wrote:

    From: Philippe Mathieu-Daude <philmd@redhat.com>

    The "Shell Embedded Boot Loader" description (added in
    commit 6f5872b1f401) does not add any value, remove it.

    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
    Cc: Leif Lindholm <leif@nuviainc.com>
    Cc: Sami Mujawar <sami.mujawar@arm.com>
    Cc: Julien Grall <julien@xen.org>
    Suggested-by: Laszlo Ersek <lersek@redhat.com>
    Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
    ---
     ArmVirtPkg/ArmVirt.dsc.inc           | 3 ---
     ArmVirtPkg/ArmVirtKvmTool.fdf        | 3 ---
     ArmVirtPkg/ArmVirtXen.fdf            | 3 ---
     ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ---
     4 files changed, 12 deletions(-)

    diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
    index d9abadbe708c..619b5f0b44c0 100644
    --- a/ArmVirtPkg/ArmVirt.dsc.inc
    +++ b/ArmVirtPkg/ArmVirt.dsc.inc
    @@ -375,9 +375,6 @@ [Components.common]
       #
       MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {
         <PcdsFixedAtBuild>
           gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
    diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmTool.fdf
    index 076155199905..152453dc4bb3 100644
    --- a/ArmVirtPkg/ArmVirtKvmTool.fdf
    +++ b/ArmVirtPkg/ArmVirtKvmTool.fdf
    @@ -173,9 +173,6 @@ [FV.FvMain]
       INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
       INF OvmfPkg/VirtioRngDxe/VirtioRng.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       INF ShellPkg/Application/Shell/Shell.inf
       INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf

    diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
    index 8fbbc2313aff..9597465cf58a 100644
    --- a/ArmVirtPkg/ArmVirtXen.fdf
    +++ b/ArmVirtPkg/ArmVirtXen.fdf
    @@ -177,9 +177,6 @@ [FV.FvMain]
       INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
       INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       INF ShellPkg/Application/Shell/Shell.inf
       INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
       INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
    diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
    index 5b1d10057545..26f13f6a2115 100644
    --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
    +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
    @@ -99,9 +99,6 @@ [FV.FvMain]
       INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
       INF OvmfPkg/VirtioRngDxe/VirtioRng.inf

    -  #
    -  # UEFI application (Shell Embedded Boot Loader)
    -  #
       INF ShellPkg/Application/Shell/Shell.inf
       INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
       INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
    -- 
    2.31.1



  reply	other threads:[~2021-07-21  8:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  8:18 [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment Philippe Mathieu-Daudé
2021-07-21  8:24 ` Sami Mujawar [this message]
2021-07-29 10:14   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FCD2FA1A-7692-41DB-A380-211768A223E4@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox