* [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment
@ 2021-07-21 8:18 Philippe Mathieu-Daudé
2021-07-21 8:24 ` Sami Mujawar
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-21 8:18 UTC (permalink / raw)
To: devel
Cc: Philippe Mathieu-Daude, Laszlo Ersek, Ard Biesheuvel,
Leif Lindholm, Sami Mujawar, Julien Grall
From: Philippe Mathieu-Daude <philmd@redhat.com>
The "Shell Embedded Boot Loader" description (added in
commit 6f5872b1f401) does not add any value, remove it.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Julien Grall <julien@xen.org>
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
ArmVirtPkg/ArmVirt.dsc.inc | 3 ---
ArmVirtPkg/ArmVirtKvmTool.fdf | 3 ---
ArmVirtPkg/ArmVirtXen.fdf | 3 ---
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ---
4 files changed, 12 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index d9abadbe708c..619b5f0b44c0 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -375,9 +375,6 @@ [Components.common]
#
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {
<PcdsFixedAtBuild>
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmTool.fdf
index 076155199905..152453dc4bb3 100644
--- a/ArmVirtPkg/ArmVirtKvmTool.fdf
+++ b/ArmVirtPkg/ArmVirtKvmTool.fdf
@@ -173,9 +173,6 @@ [FV.FvMain]
INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
INF OvmfPkg/VirtioRngDxe/VirtioRng.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
INF ShellPkg/Application/Shell/Shell.inf
INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
index 8fbbc2313aff..9597465cf58a 100644
--- a/ArmVirtPkg/ArmVirtXen.fdf
+++ b/ArmVirtPkg/ArmVirtXen.fdf
@@ -177,9 +177,6 @@ [FV.FvMain]
INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
INF ShellPkg/Application/Shell/Shell.inf
INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
index 5b1d10057545..26f13f6a2115 100644
--- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
+++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
@@ -99,9 +99,6 @@ [FV.FvMain]
INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
INF OvmfPkg/VirtioRngDxe/VirtioRng.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
INF ShellPkg/Application/Shell/Shell.inf
INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment
2021-07-21 8:18 [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment Philippe Mathieu-Daudé
@ 2021-07-21 8:24 ` Sami Mujawar
2021-07-29 10:14 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Sami Mujawar @ 2021-07-21 8:24 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, devel@edk2.groups.io
Cc: Laszlo Ersek, Ard Biesheuvel, Leif Lindholm, Julien Grall, nd
Hi Philippe,
Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 21/07/2021, 09:19, "Philippe Mathieu-Daudé" <philmd@redhat.com> wrote:
From: Philippe Mathieu-Daude <philmd@redhat.com>
The "Shell Embedded Boot Loader" description (added in
commit 6f5872b1f401) does not add any value, remove it.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Julien Grall <julien@xen.org>
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
ArmVirtPkg/ArmVirt.dsc.inc | 3 ---
ArmVirtPkg/ArmVirtKvmTool.fdf | 3 ---
ArmVirtPkg/ArmVirtXen.fdf | 3 ---
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ---
4 files changed, 12 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index d9abadbe708c..619b5f0b44c0 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -375,9 +375,6 @@ [Components.common]
#
MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {
<PcdsFixedAtBuild>
gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmTool.fdf
index 076155199905..152453dc4bb3 100644
--- a/ArmVirtPkg/ArmVirtKvmTool.fdf
+++ b/ArmVirtPkg/ArmVirtKvmTool.fdf
@@ -173,9 +173,6 @@ [FV.FvMain]
INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
INF OvmfPkg/VirtioRngDxe/VirtioRng.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
INF ShellPkg/Application/Shell/Shell.inf
INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
index 8fbbc2313aff..9597465cf58a 100644
--- a/ArmVirtPkg/ArmVirtXen.fdf
+++ b/ArmVirtPkg/ArmVirtXen.fdf
@@ -177,9 +177,6 @@ [FV.FvMain]
INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
INF ShellPkg/Application/Shell/Shell.inf
INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
index 5b1d10057545..26f13f6a2115 100644
--- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
+++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
@@ -99,9 +99,6 @@ [FV.FvMain]
INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
INF OvmfPkg/VirtioRngDxe/VirtioRng.inf
- #
- # UEFI application (Shell Embedded Boot Loader)
- #
INF ShellPkg/Application/Shell/Shell.inf
INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment
2021-07-21 8:24 ` Sami Mujawar
@ 2021-07-29 10:14 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2021-07-29 10:14 UTC (permalink / raw)
To: Sami Mujawar
Cc: Philippe Mathieu-Daudé, devel@edk2.groups.io, Laszlo Ersek,
Ard Biesheuvel, Leif Lindholm, Julien Grall, nd
On Wed, 21 Jul 2021 at 10:24, Sami Mujawar <Sami.Mujawar@arm.com> wrote:
>
> Hi Philippe,
>
> Thank you for this patch.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
Merged, thanks.
> Regards,
>
> Sami Mujawar
>
> On 21/07/2021, 09:19, "Philippe Mathieu-Daudé" <philmd@redhat.com> wrote:
>
> From: Philippe Mathieu-Daude <philmd@redhat.com>
>
> The "Shell Embedded Boot Loader" description (added in
> commit 6f5872b1f401) does not add any value, remove it.
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Julien Grall <julien@xen.org>
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 3 ---
> ArmVirtPkg/ArmVirtKvmTool.fdf | 3 ---
> ArmVirtPkg/ArmVirtXen.fdf | 3 ---
> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ---
> 4 files changed, 12 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index d9abadbe708c..619b5f0b44c0 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -375,9 +375,6 @@ [Components.common]
> #
> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf
>
> - #
> - # UEFI application (Shell Embedded Boot Loader)
> - #
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {
> <PcdsFixedAtBuild>
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmTool.fdf
> index 076155199905..152453dc4bb3 100644
> --- a/ArmVirtPkg/ArmVirtKvmTool.fdf
> +++ b/ArmVirtPkg/ArmVirtKvmTool.fdf
> @@ -173,9 +173,6 @@ [FV.FvMain]
> INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
> INF OvmfPkg/VirtioRngDxe/VirtioRng.inf
>
> - #
> - # UEFI application (Shell Embedded Boot Loader)
> - #
> INF ShellPkg/Application/Shell/Shell.inf
> INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
>
> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf
> index 8fbbc2313aff..9597465cf58a 100644
> --- a/ArmVirtPkg/ArmVirtXen.fdf
> +++ b/ArmVirtPkg/ArmVirtXen.fdf
> @@ -177,9 +177,6 @@ [FV.FvMain]
> INF MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf
> INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>
> - #
> - # UEFI application (Shell Embedded Boot Loader)
> - #
> INF ShellPkg/Application/Shell/Shell.inf
> INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index 5b1d10057545..26f13f6a2115 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -99,9 +99,6 @@ [FV.FvMain]
> INF OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
> INF OvmfPkg/VirtioRngDxe/VirtioRng.inf
>
> - #
> - # UEFI application (Shell Embedded Boot Loader)
> - #
> INF ShellPkg/Application/Shell/Shell.inf
> INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
> --
> 2.31.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-29 10:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-21 8:18 [PATCH v2 1/1] ArmVirtPkg: Remove meaningless comment Philippe Mathieu-Daudé
2021-07-21 8:24 ` Sami Mujawar
2021-07-29 10:14 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox