public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
To: Patrick Georgi <pgeorgi@google.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines
Date: Thu, 20 Sep 2018 04:37:44 +0000	[thread overview]
Message-ID: <FEE48D66-5AD5-419D-8F62-1221CE07412C@intel.com> (raw)
In-Reply-To: <CAE-gjdW89wvX5=EVrMfq7=EwPZUtehjy4fMSuqoiDeHEUXjo-w@mail.gmail.com>

Hi Patrick,

> If the autoconversion is not considered good enough, I'd propose keeping out patch 1 of this series that adds the #! line and the executable bit, and instead expect people to always call the script with "python $path/SplitFspBin.py" to keep confusion at a minimum. 

There was quite a debate on this a few years ago. Without getting into the details, the decision was made that people on Windows platforms would set core.autocrlf=false and that source code would be stored in CR-LF format. Per your recommendation, it sounds like we should only merge patch 2 then.

Thanks,
Nate


  reply	other threads:[~2018-09-20  4:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 13:32 [PATCH 1/3] IntelFsp2Pkg: Allow calling SplitFspBin.py directly Patrick Georgi
2018-09-18 13:32 ` [PATCH 2/3] IntelFsp2Pkg: Fix typo in SplitFspBin Patrick Georgi
2018-09-18 15:04   ` Desimone, Nathaniel L
2018-09-20 23:28     ` Chiu, Chasel
2018-09-26  3:11       ` Yao, Jiewen
2018-09-18 13:32 ` [PATCH 3/3] IntelFsp2Pkg: Tell git to format SplitFspBin.py with native newlines Patrick Georgi
2018-09-18 15:10   ` Desimone, Nathaniel L
2018-09-18 15:53     ` Patrick Georgi
2018-09-20  4:37       ` Desimone, Nathaniel L [this message]
2018-09-26  3:12         ` Yao, Jiewen
2018-09-26 15:58           ` Patrick Georgi
2018-09-27  0:40             ` Yao, Jiewen
2018-09-18 15:03 ` [PATCH 1/3] IntelFsp2Pkg: Allow calling SplitFspBin.py directly Desimone, Nathaniel L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FEE48D66-5AD5-419D-8F62-1221CE07412C@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox