public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhang, Chao B" <chao.b.zhang@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 2/2] IntelFrameworkModulePkg FwVolDxe: Return correct AuthStatus for FvReadFile
Date: Mon, 29 Aug 2016 01:26:41 +0000	[thread overview]
Message-ID: <FF72C7E4248F3C4E9BDF19D4918E90F2472175BE@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <1472201116-194368-3-git-send-email-star.zeng@intel.com>

Serial Reviewed by: Chao Zhang <chao.b.zhang@intel.com>





Thanks & Best regards
Chao Zhang

-----Original Message-----
From: Zeng, Star 
Sent: Friday, August 26, 2016 4:45 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star; Yao, Jiewen; Gao, Liming; Zhang, Chao B
Subject: [PATCH 2/2] IntelFrameworkModulePkg FwVolDxe: Return correct AuthStatus for FvReadFile

Inherit the authentication status from FV.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 .../Universal/FirmwareVolume/FwVolDxe/FwVolRead.c                  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
index 8e2706bb8a72..0d9021914f33 100644
--- a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
+++ b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
@@ -1,7 +1,7 @@
 /** @file
   Implements functions to read firmware file.
 
-  Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions
@@ -405,7 +405,10 @@ FvReadFile (
    if ((FvDevice->FwVolHeader->Attributes & EFI_FVB2_MEMORY_MAPPED) == EFI_FVB2_MEMORY_MAPPED) {
      *FileAttributes |= EFI_FV_FILE_ATTRIB_MEMORY_MAPPED;
    }
-  *AuthenticationStatus = 0;
+  //
+  // Inherit the authentication status.
+  //
+  *AuthenticationStatus = FvDevice->AuthenticationStatus;
 
   //
   // If Buffer is NULL, we only want to get some information
-- 
2.7.0.windows.1



  reply	other threads:[~2016-08-29  1:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26  8:45 [PATCH 0/2] Return correct AuthenticationStatus for FvReadFile() Star Zeng
2016-08-26  8:45 ` [PATCH 1/2] MdeModulePkg DxeCore: Return correct AuthStatus for FvReadFile Star Zeng
2016-08-26  8:45 ` [PATCH 2/2] IntelFrameworkModulePkg FwVolDxe: " Star Zeng
2016-08-29  1:26   ` Zhang, Chao B [this message]
2016-08-26 22:48 ` [PATCH 0/2] Return correct AuthenticationStatus for FvReadFile() Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FF72C7E4248F3C4E9BDF19D4918E90F2472175BE@SHSMSX152.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox