[PATCH 0/2] Return correct AuthenticationStatus for FvReadFile()

[PATCH 0/2] Return correct AuthenticationStatus for FvReadFile()

[Star Zeng]

Inherit the authentication status from FV.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>

Star Zeng (2):
  MdeModulePkg DxeCore: Return correct AuthStatus for FvReadFile
  IntelFrameworkModulePkg FwVolDxe: Return correct AuthStatus for
    FvReadFile

 .../Universal/FirmwareVolume/FwVolDxe/FwVolRead.c                  | 7 +++++--
 MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c                            | 7 +++++--
 2 files changed, 10 insertions(+), 4 deletions(-)

-- 
2.7.0.windows.1

[PATCH 1/2] MdeModulePkg DxeCore: Return correct AuthStatus for FvReadFile

[Star Zeng]

Inherit the authentication status from FV.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c b/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
index 1acac5d8fd79..00e0d7d289ec 100644
--- a/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
+++ b/MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
@@ -1,7 +1,7 @@
 /** @file
   Implements functions to read firmware file
 
-Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
@@ -347,7 +347,10 @@ FvReadFile (
    if ((FvDevice->FwVolHeader->Attributes & EFI_FVB2_MEMORY_MAPPED) == EFI_FVB2_MEMORY_MAPPED) {
      *FileAttributes |= EFI_FV_FILE_ATTRIB_MEMORY_MAPPED;
    }
-  *AuthenticationStatus = 0;
+  //
+  // Inherit the authentication status.
+  //
+  *AuthenticationStatus = FvDevice->AuthenticationStatus;
   *BufferSize = FileSize;
 
   if (Buffer == NULL) {
-- 
2.7.0.windows.1

[PATCH 2/2] IntelFrameworkModulePkg FwVolDxe: Return correct AuthStatus for FvReadFile

[Star Zeng]

Inherit the authentication status from FV.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 .../Universal/FirmwareVolume/FwVolDxe/FwVolRead.c                  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
index 8e2706bb8a72..0d9021914f33 100644
--- a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
+++ b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
@@ -1,7 +1,7 @@
 /** @file
   Implements functions to read firmware file.
 
-  Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions
@@ -405,7 +405,10 @@ FvReadFile (
    if ((FvDevice->FwVolHeader->Attributes & EFI_FVB2_MEMORY_MAPPED) == EFI_FVB2_MEMORY_MAPPED) {
      *FileAttributes |= EFI_FV_FILE_ATTRIB_MEMORY_MAPPED;
    }
-  *AuthenticationStatus = 0;
+  //
+  // Inherit the authentication status.
+  //
+  *AuthenticationStatus = FvDevice->AuthenticationStatus;
 
   //
   // If Buffer is NULL, we only want to get some information
-- 
2.7.0.windows.1

Re: [PATCH 0/2] Return correct AuthenticationStatus for FvReadFile()

[Yao, Jiewen]

Reviewed-by: Jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, August 26, 2016 4:45 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Gao, Liming <liming.gao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [PATCH 0/2] Return correct AuthenticationStatus for FvReadFile()
> 
> Inherit the authentication status from FV.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> 
> Star Zeng (2):
>   MdeModulePkg DxeCore: Return correct AuthStatus for FvReadFile
>   IntelFrameworkModulePkg FwVolDxe: Return correct AuthStatus for
>     FvReadFile
> 
>  .../Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
> | 7 +++++--
>  MdeModulePkg/Core/Dxe/FwVol/FwVolRead.c
> | 7 +++++--
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> --
> 2.7.0.windows.1

Re: [PATCH 2/2] IntelFrameworkModulePkg FwVolDxe: Return correct AuthStatus for FvReadFile

[Zhang, Chao B]

Serial Reviewed by: Chao Zhang <chao.b.zhang@intel.com>





Thanks & Best regards
Chao Zhang

-----Original Message-----
From: Zeng, Star 
Sent: Friday, August 26, 2016 4:45 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star; Yao, Jiewen; Gao, Liming; Zhang, Chao B
Subject: [PATCH 2/2] IntelFrameworkModulePkg FwVolDxe: Return correct AuthStatus for FvReadFile

Inherit the authentication status from FV.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 .../Universal/FirmwareVolume/FwVolDxe/FwVolRead.c                  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
index 8e2706bb8a72..0d9021914f33 100644
--- a/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
+++ b/IntelFrameworkModulePkg/Universal/FirmwareVolume/FwVolDxe/FwVolRead.c
@@ -1,7 +1,7 @@
 /** @file
   Implements functions to read firmware file.
 
-  Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions
@@ -405,7 +405,10 @@ FvReadFile (
    if ((FvDevice->FwVolHeader->Attributes & EFI_FVB2_MEMORY_MAPPED) == EFI_FVB2_MEMORY_MAPPED) {
      *FileAttributes |= EFI_FV_FILE_ATTRIB_MEMORY_MAPPED;
    }
-  *AuthenticationStatus = 0;
+  //
+  // Inherit the authentication status.
+  //
+  *AuthenticationStatus = FvDevice->AuthenticationStatus;
 
   //
   // If Buffer is NULL, we only want to get some information
-- 
2.7.0.windows.1