public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* DxeCapsuleLib returns Status Issue
@ 2016-08-29  7:51 Ankit_Singh3
  2016-08-29  7:58 ` Yao, Jiewen
       [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14B3D62F7@SHSMSX104.ccr.corp.intel.com>
  0 siblings, 2 replies; 8+ messages in thread
From: Ankit_Singh3 @ 2016-08-29  7:51 UTC (permalink / raw)
  To: edk2-devel

Dell - Internal Use - Confidential
Hi EDK2 Developers,

We are incorporating DxeCapsuleLib for FMP Capsule Update into our UEFI product, but we are hitting few issues as described below.

In case of Capsule Update "SetImage" is randomly done for all the FMP Handles in case Image Type Id GUID and Image Index  matches (this is expected as there might be multiple similar hardware), but looks like the returns of each FMP update is not handled.
For example if there are 5 FMP handles (can be for different-different devices) and assume that any particular device handle is at 3rd index, therefore the update goes through successfully on the 3rd attempt but since HandleCount value is 5 it tries further with 4th and 5th Handle. This 4th & 5th Handle attempt can fail for any of the calls within the FMP Handle "for loop" (HandleProtocol/GetImageInfo) and hence the final status is returned as FAILURE to application layer.

Below is the code-snippet from DxeCapsuleLib.c , in case of HandleProtocol & GetImageInfo failure, "for" loop for Handle count is continued and the previous Status value is over-written with this new return (return from HandleProtocol & GetImageInfo) and finally returned to application.
[cid:image001.jpg@01D201F8.38564220]


Proposed Solution:-
Can ProcessFmpCapsuleImage() have an extra OUT parameter which gives the list of all successful FMP Handles along with the updated GUID values, so that any application can make the judgment of Update SUCCESS/FAILURE based on FMP Handle and proceed accordingly at application layer.

Regards,
Ankit Singh



^ permalink raw reply	[flat|nested] 8+ messages in thread
* DxeCapsuleLib returns Status Issue
@ 2016-08-24 10:22 Ankit_Singh3
  0 siblings, 0 replies; 8+ messages in thread
From: Ankit_Singh3 @ 2016-08-24 10:22 UTC (permalink / raw)
  To: edk2-devel; +Cc: Sumanth_Vidyadhara, Dileesh_Onniyil, Mark_Shutt

Dell - Internal Use - Confidential
Hi EDK2 Developers,

We are incorporating DxeCapsuleLib for FMP Capsule Update into our UEFI product, but we are hitting few issues as described below.

In case of Capsule Update "SetImage" is randomly done for all the FMP Handles in case Image Type Id GUID and Image Index  matches (this is expected as there might be multiple similar hardware), but looks like the returns of each FMP update is not handled.
For example if there are 5 FMP handles (can be for different-different devices) and assume that any particular device handle is at 3rd index, therefore the update goes through successfully on the 3rd attempt but since HandleCount value is 5 it tries further with 4th and 5th Handle. This 4th & 5th Handle attempt can fail for any of the calls within the FMP Handle "for loop" (HandleProtocol/GetImageInfo) and hence the final status is returned as FAILURE to application layer.

Below is the code-snippet from DxeCapsuleLib.c , in case of HandleProtocol & GetImageInfo failure, "for" loop for Handle count is continued and the previous Status value is over-written with this new return (return from HandleProtocol & GetImageInfo) and finally returned to application.
[cid:image001.jpg@01D1FE1F.828C9E70]


Proposed Solution:-
Can ProcessFmpCapsuleImage() have an extra OUT parameter which gives the list of all successful FMP Handles along with the updated GUID values, so that any application can make the judgment of Update SUCCESS/FAILURE based on FMP Handle and proceed accordingly at application layer.

Regards,
Ankit Singh



^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-09-02  3:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-29  7:51 DxeCapsuleLib returns Status Issue Ankit_Singh3
2016-08-29  7:58 ` Yao, Jiewen
     [not found]   ` <F99FFC4B77F8B14CBD8ED39478A5FA211D4BA333AE@BLRX7MCDC203.AMER.DELL.COM>
2016-08-31  0:54     ` Yao, Jiewen
2016-09-02  1:51       ` Yao, Jiewen
2016-09-02  3:24         ` Ankit_Singh3
2016-09-02  3:30           ` Yao, Jiewen
     [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14B3D62F7@SHSMSX104.ccr.corp.intel.com>
2016-08-29 15:24   ` Zhang, Chao B
  -- strict thread matches above, loose matches on Subject: below --
2016-08-24 10:22 Ankit_Singh3

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox