From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CE4B281DC7 for ; Sun, 13 Nov 2016 19:12:15 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP; 13 Nov 2016 19:12:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,488,1473145200"; d="scan'208";a="30683146" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 13 Nov 2016 19:12:19 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 13 Nov 2016 19:12:19 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 13 Nov 2016 19:12:18 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.142]) with mapi id 14.03.0248.002; Mon, 14 Nov 2016 11:12:17 +0800 From: "Zhang, Chao B" To: Gary Lin , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 29/33] SecurityPkg: Fix typos in comments Thread-Index: AQHSKdb73TJH2gj810yy2mZQZecPyqDX9WbA Date: Mon, 14 Nov 2016 03:12:16 +0000 Message-ID: References: <20161019070138.16424-1-glin@suse.com> <20161019070138.16424-30-glin@suse.com> In-Reply-To: <20161019070138.16424-30-glin@suse.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzkzNzM2ZmEtOGQ2NC00YjI3LTkxYzgtNTM5MTA2YWRiZmIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNZWXRIQ3FNd2xwMEQyRHI1dGIyRXhOUlIrODJFeEg5MU5OK1M2YlltYVE9In0= x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 29/33] SecurityPkg: Fix typos in comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 03:12:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Gary: I see some warnings while running PatchChecy.py with this patch.=20 Please help to update the patch, run PatchCheck.py(BaseTools/Scripts) & re-= send the patch. Thanks & Best regards Chao Zhang -----Original Message----- From: Gary Lin [mailto:glin@suse.com]=20 Sent: Wednesday, October 19, 2016 3:02 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [PATCH 29/33] SecurityPkg: Fix typos in comments - intialized -> initialized - TURE -> TRUE - successull -> successfully - hanlder -> handler - funciton -> function - Seperator -> Separator - Sumbit -> Submit Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c = | 2 +- SecurityPkg/Include/Library/TcgPpVendorLib.h = | 4 ++-- SecurityPkg/Include/Library/TcgStorageOpalLib.h = | 2 +- SecurityPkg/Include/Library/TrEEPpVendorLib.h = | 4 ++-- SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c = | 6 +++--- SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa2048Sha2= 56GuidedSectionExtractLib.c | 2 +- SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa2048Sha2= 56GuidedSectionExtractLib.c | 2 +- SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c = | 2 +- SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c = | 2 +- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c = | 2 +- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c = | 2 +- SecurityPkg/Tcg/TcgDxe/TcgDxe.c = | 2 +- SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c = | 2 +- SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPolicy.= c | 2 +- SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileManager.h = | 2 +- 15 files changed, 19 insertions(+), 19 deletions(-) diff --git a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c b/SecurityPkg/Hash= 2DxeCrypto/Hash2DxeCrypto.c index ab34de7..93e3273 100644 --- a/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c +++ b/SecurityPkg/Hash2DxeCrypto/Hash2DxeCrypto.c @@ -64,7 +64,7 @@ BOOLEAN =20 This function performs Hash digest on a data buffer of the specified siz= e. It can be called multiple times to compute the digest of long or discont= inuous data streams. - Hash context should be already correctly intialized by HashInit(), and s= hould not be finalized + Hash context should be already correctly initialized by HashInit(), and = should not be finalized by HashFinal(). Behavior with invalid context is undefined. =20 If HashContext is NULL, then return FALSE. diff --git a/SecurityPkg/Include/Library/TcgPpVendorLib.h b/SecurityPkg/Inc= lude/Library/TcgPpVendorLib.h index 08b3690..284aa9e 100644 --- a/SecurityPkg/Include/Library/TcgPpVendorLib.h +++ b/SecurityPkg/Include/Library/TcgPpVendorLib.h @@ -42,8 +42,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #define TCG_PP_OPERATION_RESPONSE_BIOS_FAILURE 0xFFFFFFF1 =20 // -// The return code for Sumbit TPM Request to Pre-OS Environment -// and Sumbit TPM Request to Pre-OS Environment 2 +// The return code for Submit TPM Request to Pre-OS Environment +// and Submit TPM Request to Pre-OS Environment 2 // #define TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS = 0 #define TCG_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED = 1 diff --git a/SecurityPkg/Include/Library/TcgStorageOpalLib.h b/SecurityPkg/= Include/Library/TcgStorageOpalLib.h index 108affc..9b64a8e 100644 --- a/SecurityPkg/Include/Library/TcgStorageOpalLib.h +++ b/SecurityPkg/Include/Library/TcgStorageOpalLib.h @@ -290,7 +290,7 @@ OpalGlobalLockingRangeGenKey( /** =20 The function updates the ReadLocked and WriteLocked columns of the Globa= l Locking Range. - This funciton is required for a user1 authority, since a user1 authority= shall only have access to ReadLocked and WriteLocked columns + This function is required for a user1 authority, since a user1 authority= shall only have access to ReadLocked and WriteLocked columns (not ReadLockEnabled and WriteLockEnabled columns). =20 @param[in] LockingSpSession OPAL_SESSION with OPAL_UID_LOCKING_S= P to generate key diff --git a/SecurityPkg/Include/Library/TrEEPpVendorLib.h b/SecurityPkg/In= clude/Library/TrEEPpVendorLib.h index d3a0767..f0dcfd9 100644 --- a/SecurityPkg/Include/Library/TrEEPpVendorLib.h +++ b/SecurityPkg/Include/Library/TrEEPpVendorLib.h @@ -45,8 +45,8 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER= EXPRESS OR IMPLIED. #define TREE_PP_OPERATION_RESPONSE_BIOS_FAILURE 0xFFFFFFF1 =20 // -// The return code for Sumbit TPM Request to Pre-OS Environment -// and Sumbit TPM Request to Pre-OS Environment 2 +// The return code for Submit TPM Request to Pre-OS Environment +// and Submit TPM Request to Pre-OS Environment 2 // #define TREE_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS = 0 #define TREE_PP_SUBMIT_REQUEST_TO_PREOS_NOT_IMPLEMENTED = 1 diff --git a/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.= c b/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c index 142b546..02a87f9 100644 --- a/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c +++ b/SecurityPkg/Library/DxeDeferImageLoadLib/DxeDeferImageLoadLib.c @@ -469,7 +469,7 @@ Done: @param[in] DevicePath Points to device path. @param[in] AccessType The type of user access control. =20 - @retval TURE The DevicePath is in the specified List. + @retval TRUE The DevicePath is in the specified List. @retval FALSE The DevicePath is not in the specified List. =20 **/ @@ -512,7 +512,7 @@ IsDevicePathInList ( =20 @param[in] DevicePath Points to device path =20 - @retval TURE The image pointed by DevicePath is permitted to l= oad. + @retval TRUE The image pointed by DevicePath is permitted to l= oad. @retval FALSE The image pointed by DevicePath is forbidden to l= oad. =20 **/ @@ -545,7 +545,7 @@ VerifyDevicePath ( =20 @param[in] DevicePath Points to device path. =20 - @retval TURE The image pointed by DevicePath is a boot option. + @retval TRUE The image pointed by DevicePath is a boot option. @retval FALSE The image pointed by DevicePath is not a boot opt= ion. =20 **/ diff --git a/SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/Dx= eRsa2048Sha256GuidedSectionExtractLib.c b/SecurityPkg/Library/DxeRsa2048Sha= 256GuidedSectionExtractLib/DxeRsa2048Sha256GuidedSectionExtractLib.c index 5f5d242..39768fb 100644 --- a/SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa204= 8Sha256GuidedSectionExtractLib.c +++ b/SecurityPkg/Library/DxeRsa2048Sha256GuidedSectionExtractLib/DxeRsa204= 8Sha256GuidedSectionExtractLib.c @@ -59,7 +59,7 @@ CONST UINT8 mRsaE[] =3D { 0x01, 0x00, 0x01 }; @param SectionAttribute The attribute of the input guided section. =20 @retval EFI_SUCCESS The size of destination buffer, the size = of scratch buffer and=20 - the attribute of the input section are su= ccessull retrieved. + the attribute of the input section are su= ccessfully retrieved. @retval EFI_INVALID_PARAMETER The GUID in InputSection does not match t= his instance guid. =20 **/ diff --git a/SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/Pe= iRsa2048Sha256GuidedSectionExtractLib.c b/SecurityPkg/Library/PeiRsa2048Sha= 256GuidedSectionExtractLib/PeiRsa2048Sha256GuidedSectionExtractLib.c index 4733703..ba1c700 100644 --- a/SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa204= 8Sha256GuidedSectionExtractLib.c +++ b/SecurityPkg/Library/PeiRsa2048Sha256GuidedSectionExtractLib/PeiRsa204= 8Sha256GuidedSectionExtractLib.c @@ -57,7 +57,7 @@ CONST UINT8 mRsaE[] =3D { 0x01, 0x00, 0x01 }; @param SectionAttribute The attribute of the input guided section. =20 @retval EFI_SUCCESS The size of destination buffer, the size = of scratch buffer and=20 - the attribute of the input section are su= ccessull retrieved. + the attribute of the input section are su= ccessfully retrieved. @retval EFI_INVALID_PARAMETER The GUID in InputSection does not match t= his instance guid. =20 **/ diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c b/Secur= ityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c index 30808cd..286f5b6 100644 --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageUtil.c @@ -881,7 +881,7 @@ TcgIsProtocolSupported( =20 @param Discovery =20 - @retval TURE if lock, FALSE if not lock. + @retval TRUE if lock, FALSE if not lock. **/ BOOLEAN EFIAPI diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c b/S= ecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c index a0eac33..90cc51a 100644 --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c @@ -1055,7 +1055,7 @@ OpalGlobalLockingRangeGenKey( /** =20 The function updates the ReadLocked and WriteLocked columns of the Globa= l Locking Range. - This funciton is required for a user1 authority, since a user1 authority= shall only have access to ReadLocked and WriteLocked columns + This function is required for a user1 authority, since a user1 authority= shall only have access to ReadLocked and WriteLocked columns (not ReadLockEnabled and WriteLockEnabled columns). =20 @param[in] LockingSpSession OPAL_SESSION with OPAL_UID_LOCKING_S= P to generate key diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c b/SecurityPk= g/Tcg/Opal/OpalPasswordDxe/OpalDriver.c index 9bf1ced..bd12d5a 100644 --- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c +++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c @@ -406,7 +406,7 @@ OpalDriverGetDeviceList( ReadyToBoot callback to send BlockSid command. =20 @param Event Pointer to this event - @param Context Event hanlder private Data + @param Context Event handler private Data =20 **/ VOID diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tc= g2Dxe.c index db8d662..804929e 100644 --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c @@ -2073,7 +2073,7 @@ OnReadyToBoot ( for (PcrIndex =3D 0; PcrIndex < 7; PcrIndex++) { Status =3D MeasureSeparatorEvent (PcrIndex); if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "Seperator Event not Measured. Error!\n")); + DEBUG ((EFI_D_ERROR, "Separator Event not Measured. Error!\n")); } } =20 diff --git a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c b/SecurityPkg/Tcg/TcgDxe/TcgDx= e.c index 0d7e32a..3e6d87b 100644 --- a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c +++ b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c @@ -1160,7 +1160,7 @@ OnReadyToBoot ( for (PcrIndex =3D 0; PcrIndex < 8; PcrIndex++) { Status =3D MeasureSeparatorEvent (PcrIndex); if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "Seperator Event not Measured. Error!\n")); + DEBUG ((EFI_D_ERROR, "Separator Event not Measured. Error!\n")); } } =20 diff --git a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c b/SecurityPkg/Tcg/TrEEDxe/Tr= EEDxe.c index fb69fa1..fa51b64 100644 --- a/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c +++ b/SecurityPkg/Tcg/TrEEDxe/TrEEDxe.c @@ -1500,7 +1500,7 @@ OnReadyToBoot ( for (PcrIndex =3D 0; PcrIndex < 7; PcrIndex++) { Status =3D MeasureSeparatorEvent (PcrIndex); if (EFI_ERROR (Status)) { - DEBUG ((EFI_D_ERROR, "Seperator Event not Measured. Error!\n")); + DEBUG ((EFI_D_ERROR, "Separator Event not Measured. Error!\n")); } } =20 diff --git a/SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIde= ntityPolicy.c b/SecurityPkg/UserIdentification/UserProfileManagerDxe/Modify= IdentityPolicy.c index 9f157f8..8382744 100644 --- a/SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPo= licy.c +++ b/SecurityPkg/UserIdentification/UserProfileManagerDxe/ModifyIdentityPo= licy.c @@ -409,7 +409,7 @@ CheckNewIdentityPolicy ( /** Save the identity policy and update UI with it. =20 - This funciton will verify the new identity policy, in current implementa= tion,=20 + This function will verify the new identity policy, in current implementa= tion, the identity policy can be: T, P & P & P & ..., P | P | P | ... Here, "T" means "True", "P" means "Credential Provider", "&" means "and"= , "|" means "or". Other identity policies are not supported. =20 diff --git a/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfi= leManager.h b/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProf= ileManager.h index afa420e..6491dc2 100644 --- a/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileManag= er.h +++ b/SecurityPkg/UserIdentification/UserProfileManagerDxe/UserProfileManag= er.h @@ -254,7 +254,7 @@ AddIdentityPolicyItem ( /** Save the identity policy and update UI with it. =20 - This funciton will verify the new identity policy, in current implementa= tion,=20 + This function will verify the new identity policy, in current implementa= tion, the identity policy can be: T, P & P & P & ..., P | P | P | ... Here, "T" means "True", "P" means "Credential Provider", "&" means "and"= , "|" means "or". Other identity policies are not supported. =20 --=20 2.10.1