From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ED45D817B4 for ; Sun, 8 Jan 2017 21:51:47 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 08 Jan 2017 21:51:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="1109831839" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 08 Jan 2017 21:51:47 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 8 Jan 2017 21:51:47 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 8 Jan 2017 21:51:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Mon, 9 Jan 2017 13:51:31 +0800 From: "Zhang, Chao B" To: "Zeng, Star" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] SecurityPkg Tcg2ConfigDxe: Refine debug message and comments Thread-Index: AQHSajrrIvcYLvw0z0qDaNmViPQrgKEvpEyg Date: Mon, 9 Jan 2017 05:51:30 +0000 Message-ID: References: <1483940419-139088-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1483940419-139088-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SecurityPkg Tcg2ConfigDxe: Refine debug message and comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 05:51:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by : Chao Zhang -----Original Message----- From: Zeng, Star=20 Sent: Monday, January 9, 2017 1:40 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Zhang, Chao B Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Refine debug message and commen= ts Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 6 +++--- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c b/SecurityPkg/Tc= g/Tcg2Config/Tcg2ConfigDriver.c index 34828eed7d64..050e43a3371d 100644 --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c @@ -137,7 +137,7 @@ InitializeTcg2VersionInfo ( } } else { // - // EFI variable doesn't exist. + // EFI variable doesn't exist or variable size is not expected. // =20 // @@ -182,7 +182,7 @@ InitializeTcg2VersionInfo ( // // Get the PCD value again. // If the PCD value is not equal to the value in variable, - // the PCD is not DynamicHii type and maps to the setup option. + // the PCD is not DynamicHii type and does not map to the setup option. // PcdTcg2PpiVersion =3D 0; CopyMem ( @@ -191,7 +191,7 @@ InitializeTcg2VersionInfo ( AsciiStrSize ((CHAR8 *) PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer)= ) ); if (PcdTcg2PpiVersion !=3D Tcg2Version.PpiVersion) { - DEBUG ((DEBUG_WARN, "WARNING: PcdTcgPhysicalPresenceInterfaceVer is no= t DynamicHii type and maps to TCG2_VERSION.PpiVersion\n")); + DEBUG ((DEBUG_WARN, "WARNING: PcdTcgPhysicalPresenceInterfaceVer is no= t DynamicHii type and does not map to TCG2_VERSION.PpiVersion\n")); DEBUG ((DEBUG_WARN, "WARNING: The TCG2 PPI version configuring from se= tup page will not work\n")); } =20 diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/= Tcg2Config/Tcg2ConfigImpl.c index 4432daea81b6..f4a07c642009 100644 --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c @@ -489,7 +489,7 @@ Tcg2VersionInfoCallback ( // Get the PCD value after EFI_BROWSER_ACTION_SUBMITTED, // the SetVariable to TCG2_VERSION_NAME should have been done. // If the PCD value is not equal to the value set to variable, - // the PCD is not DynamicHii type and maps to the setup option. + // the PCD is not DynamicHii type and does not map to the setup option= . // PcdTcg2PpiVersion =3D 0; CopyMem ( @@ -501,7 +501,7 @@ Tcg2VersionInfoCallback ( CreatePopUp ( EFI_LIGHTGRAY | EFI_BACKGROUND_BLUE, &Key, - L"WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii ty= pe and maps to this option!", + L"WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii ty= pe and does not map to this option!", L"The version configuring by this setup option will not work!", NULL ); --=20 2.7.0.windows.1