Re: [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible change

["Zhang, Chao B" <chao.b.zhang@intel.com>]

Hi Jiewen:
   I will give another patch for the PCD configuration. Thanks for your comment.

-----Original Message-----
From: Yao, Jiewen 
Sent: Wednesday, January 11, 2017 4:18 PM
To: Zhang, Chao B <chao.b.zhang@intel.com>; edk2-devel@lists.01.org
Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible change

Hi
I think we should add assign PlatformClass to PcdGet8 (PcdTpmPlatformClass), if version is 4, to follow TCG spec.

You may want to submit another patch to resolve.

Reviewed-by: Jiewen.yao@intel.com


Thank you
Yao Jiewen

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Zhang, Chao B
> Sent: Wednesday, January 11, 2017 4:13 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B 
> <chao.b.zhang@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible 
> change
> 
> Address incompatible change introduced in patch 
> 8f07a374b1d0497b6676491de8cbe2f08f4f7e9f
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> index 1df2da8..0c3b19c 100644
> --- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> +++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> @@ -77,14 +77,14 @@ EFI_TPM2_ACPI_TABLE  mTpm2AcpiTemplate = {
>    {
>      EFI_ACPI_5_0_TRUSTED_COMPUTING_PLATFORM_2_TABLE_SIGNATURE,
>      sizeof (mTpm2AcpiTemplate),
> -    EFI_TPM2_ACPI_TABLE_REVISION_4,
> +    EFI_TPM2_ACPI_TABLE_REVISION,
>      //
>      // Compiler initializes the remaining bytes to 0
>      // These fields should be filled in in production
>      //
>    },
> -  0, // 16-bit PlatformClass
> -  0, // 16-bit Reserved
> +  0, // BIT0~15:  PlatformClass
> +     // BIT16~31: Reserved
>    0, // Control Area
>    EFI_TPM2_ACPI_TABLE_START_METHOD_TIS, // StartMethod  };
> --
> 1.9.5.msysgit.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel