public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhang, Chao B" <chao.b.zhang@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible change
Date: Wed, 11 Jan 2017 08:28:50 +0000	[thread overview]
Message-ID: <FF72C7E4248F3C4E9BDF19D4918E90F2494F393F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A8DE7D4@shsmsx102.ccr.corp.intel.com>

Hi Jiewen:
   I will give another patch for the PCD configuration. Thanks for your comment.

-----Original Message-----
From: Yao, Jiewen 
Sent: Wednesday, January 11, 2017 4:18 PM
To: Zhang, Chao B <chao.b.zhang@intel.com>; edk2-devel@lists.01.org
Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible change

Hi
I think we should add assign PlatformClass to PcdGet8 (PcdTpmPlatformClass), if version is 4, to follow TCG spec.

You may want to submit another patch to resolve.

Reviewed-by: Jiewen.yao@intel.com


Thank you
Yao Jiewen

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of 
> Zhang, Chao B
> Sent: Wednesday, January 11, 2017 4:13 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B 
> <chao.b.zhang@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH 2/2] SecurityPkg: Tcg2Smm: Fix incompatible 
> change
> 
> Address incompatible change introduced in patch 
> 8f07a374b1d0497b6676491de8cbe2f08f4f7e9f
> 
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Yao Jiewen <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chao Zhang <chao.b.zhang@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> index 1df2da8..0c3b19c 100644
> --- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> +++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c
> @@ -77,14 +77,14 @@ EFI_TPM2_ACPI_TABLE  mTpm2AcpiTemplate = {
>    {
>      EFI_ACPI_5_0_TRUSTED_COMPUTING_PLATFORM_2_TABLE_SIGNATURE,
>      sizeof (mTpm2AcpiTemplate),
> -    EFI_TPM2_ACPI_TABLE_REVISION_4,
> +    EFI_TPM2_ACPI_TABLE_REVISION,
>      //
>      // Compiler initializes the remaining bytes to 0
>      // These fields should be filled in in production
>      //
>    },
> -  0, // 16-bit PlatformClass
> -  0, // 16-bit Reserved
> +  0, // BIT0~15:  PlatformClass
> +     // BIT16~31: Reserved
>    0, // Control Area
>    EFI_TPM2_ACPI_TABLE_START_METHOD_TIS, // StartMethod  };
> --
> 1.9.5.msysgit.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-01-11  8:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  8:12 [PATCH 1/2] MdePkg: Tpm2Acpi.h: Fix incompatible change Zhang, Chao B
2017-01-11  8:12 ` [PATCH 2/2] SecurityPkg: Tcg2Smm: " Zhang, Chao B
2017-01-11  8:17   ` Yao, Jiewen
2017-01-11  8:28     ` Zhang, Chao B [this message]
2017-01-11  8:15 ` [PATCH 1/2] MdePkg: Tpm2Acpi.h: " Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FF72C7E4248F3C4E9BDF19D4918E90F2494F393F@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox