From: "Zhang, Chao B" <chao.b.zhang@intel.com>
To: "thuth@redhat.com" <thuth@redhat.com>,
"edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [PATCH] SecurityPkg: Remove superfluous return statement
Date: Fri, 3 Feb 2017 05:23:13 +0000 [thread overview]
Message-ID: <FF72C7E4248F3C4E9BDF19D4918E90F2494FD072@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D630C@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thomas Huth
Sent: Wednesday, January 25, 2017 5:59 PM
To: edk2-devel@ml01.01.org
Cc: Zhang, Chao B <chao.b.zhang@intel.com>
Subject: [edk2] [PATCH] SecurityPkg: Remove superfluous return statement
If the code eventually returns "Status" anyway, it does not make sense to explicitly return "Status" in case of an error, too.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
index 33f77bd..a95ea2f 100644
--- a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
+++ b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c
@@ -1286,10 +1286,6 @@ AhciModeInitialize (
EFI_TIMER_PERIOD_SECONDS(16)
);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
return Status;
}
--
1.8.3.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-02-03 5:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 9:58 [PATCH] SecurityPkg: Remove superfluous return statement Thomas Huth
[not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D630C@shsmsx102.ccr.corp.intel.com>
2017-02-03 5:23 ` Zhang, Chao B [this message]
2017-02-16 9:44 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF72C7E4248F3C4E9BDF19D4918E90F2494FD072@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox