From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3325F81F0A for ; Thu, 2 Feb 2017 21:23:32 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP; 02 Feb 2017 21:23:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,327,1477983600"; d="scan'208";a="54965653" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 02 Feb 2017 21:23:31 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Feb 2017 21:23:31 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Feb 2017 21:23:16 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX103.ccr.corp.intel.com ([10.239.4.69]) with mapi id 14.03.0248.002; Fri, 3 Feb 2017 13:23:14 +0800 From: "Zhang, Chao B" To: "thuth@redhat.com" , "edk2-devel@ml01.01.org" Thread-Topic: [edk2] [PATCH] SecurityPkg: Remove superfluous return statement Thread-Index: AQHSdvGvf2XkQEPoY06Vv6fsALqP2aFWRhcAgACGT0A= Date: Fri, 3 Feb 2017 05:23:13 +0000 Message-ID: References: <1485338335-29716-1-git-send-email-thuth@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D630C@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D6D630C@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SecurityPkg: Remove superfluous return statement X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 05:23:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chao Zhang -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Thom= as Huth Sent: Wednesday, January 25, 2017 5:59 PM To: edk2-devel@ml01.01.org Cc: Zhang, Chao B Subject: [edk2] [PATCH] SecurityPkg: Remove superfluous return statement If the code eventually returns "Status" anyway, it does not make sense to e= xplicitly return "Status" in case of an error, too. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Thomas Huth --- SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c b/Security= Pkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c index 33f77bd..a95ea2f 100644 --- a/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c +++ b/SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalAhciMode.c @@ -1286,10 +1286,6 @@ AhciModeInitialize ( EFI_TIMER_PERIOD_SECONDS(16) ); =20 - if (EFI_ERROR (Status)) { - return Status; - } - return Status; } =20 -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel