From: "Zhang, Chao B" <chao.b.zhang@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Chan, Amy" <amy.chan@intel.com>, "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly"
Date: Fri, 9 Jun 2017 05:08:29 +0000 [thread overview]
Message-ID: <FF72C7E4248F3C4E9BDF19D4918E90F249573D12@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A96677A@shsmsx102.ccr.corp.intel.com>
Reviewed-by: Chao Zhang <chao.b.zhang@intel.com>
From: Yao, Jiewen
Sent: Thursday, June 8, 2017 4:39 PM
To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Chan, Amy <amy.chan@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
Subject: RE: [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly"
Reviewed-by: Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>
-----Original Message-----
From: Zeng, Star
Sent: Thursday, June 8, 2017 10:33 AM
To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Chan, Amy <amy.chan@intel.com<mailto:amy.chan@intel.com>>; Chiu, Chasel <chasel.chiu@intel.com<mailto:chasel.chiu@intel.com>>; Zhang, Chao B <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
Subject: [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly"
Current code for case "TPM not working properly" uses the predefined macro __FILE__ in debug format string, but uses predefined macro __LINE__ as parameter, and it also uses multiple pairs of "" in debug format string.
To be simple and clear, this patch is to update the code to just use
"DriverEntry: TPM not working properly\n" as the debug message.
Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
Cc: Amy Chan <amy.chan@intel.com<mailto:amy.chan@intel.com>>
Cc: Chasel Chiu <chasel.chiu@intel.com<mailto:chasel.chiu@intel.com>>
Cc: Chao Zhang <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com<mailto:star.zeng@intel.com>>
---
SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c index 5b7c5c3e165b..4a90c5ccef16 100644
--- a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
+++ b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c
@@ -1406,9 +1406,7 @@ DriverEntry (
if (EFI_ERROR (Status)) {
DEBUG ((
EFI_D_ERROR,
- "Line %d in file " __FILE__ ":\n "
- "DriverEntry: TPM not working properly\n",
- __LINE__
+ "DriverEntry: TPM not working properly\n"
));
return Status;
}
--
2.7.0.windows.1
prev parent reply other threads:[~2017-06-09 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 2:33 [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly" Star Zeng
[not found] ` <0C09AFA07DD0434D9E2A0C6AEB0483103B8E4B96@shsmsx102.ccr.corp.intel.com>
2017-06-08 8:39 ` Yao, Jiewen
2017-06-09 5:08 ` Zhang, Chao B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF72C7E4248F3C4E9BDF19D4918E90F249573D12@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox