From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EEC4920082E7E for ; Thu, 8 Jun 2017 22:07:22 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 08 Jun 2017 22:08:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,316,1493708400"; d="scan'208,217";a="1180237548" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 08 Jun 2017 22:08:32 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Jun 2017 22:08:32 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Fri, 9 Jun 2017 13:08:30 +0800 From: "Zhang, Chao B" To: "Yao, Jiewen" , "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Chan, Amy" , "Chiu, Chasel" Thread-Topic: [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly" Thread-Index: AQHS4DHhhdh5g9hcsUmMxR4dNZSWY6IaHtkAgAHdJeA= Date: Fri, 9 Jun 2017 05:08:29 +0000 Message-ID: References: <1496889199-60988-1-git-send-email-star.zeng@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8E4B96@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A96677A@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A96677A@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not working properly" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 05:07:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chao Zhang From: Yao, Jiewen Sent: Thursday, June 8, 2017 4:39 PM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen ; Chan, Amy ; Chi= u, Chasel ; Zhang, Chao B Subject: RE: [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not w= orking properly" Reviewed-by: Jiewen.yao@intel.com -----Original Message----- From: Zeng, Star Sent: Thursday, June 8, 2017 10:33 AM To: edk2-devel@lists.01.org Cc: Zeng, Star >; Yao, Jiew= en >; Chan, Amy >; Chiu, Chasel >; Zhang, Chao B > Subject: [PATCH] SecurityPkg TcgDxe: Simplify debug msg when "TPM not worki= ng properly" Current code for case "TPM not working properly" uses the predefined macro = __FILE__ in debug format string, but uses predefined macro __LINE__ as para= meter, and it also uses multiple pairs of "" in debug format string. To be simple and clear, this patch is to update the code to just use "DriverEntry: TPM not working properly\n" as the debug message. Cc: Jiewen Yao > Cc: Amy Chan > Cc: Chasel Chiu > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng > --- SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c b/SecurityPkg/Tcg/TcgDxe/TcgDx= e.c index 5b7c5c3e165b..4a90c5ccef16 100644 --- a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c +++ b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c @@ -1406,9 +1406,7 @@ DriverEntry ( if (EFI_ERROR (Status)) { DEBUG (( EFI_D_ERROR, - "Line %d in file " __FILE__ ":\n " - "DriverEntry: TPM not working properly\n", - __LINE__ + "DriverEntry: TPM not working properly\n" )); return Status; } -- 2.7.0.windows.1