From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=chao.b.zhang@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 84F7A21A143EF for ; Wed, 27 Jun 2018 07:51:10 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 07:51:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="62634886" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 27 Jun 2018 07:51:09 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Jun 2018 07:51:09 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Jun 2018 07:51:04 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.82]) with mapi id 14.03.0319.002; Wed, 27 Jun 2018 22:51:02 +0800 From: "Zhang, Chao B" To: "Gao, Liming" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [Patch] SecurityPkg Tpm2DeviceLibDTpm: Update enum type name to match the one in lib Thread-Index: AQHUDiYWzgJ9oMge6UirBcoTiwY+GqR0MBwQ Date: Wed, 27 Jun 2018 14:51:01 +0000 Message-ID: References: <20180627144929.24548-1-liming.gao@intel.com> In-Reply-To: <20180627144929.24548-1-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTU3ZDgzNjctMDY4Yy00OGY3LWE0MjQtMzI1ZDIxZGVmZWZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0FES0k1XC9lcHdYTVNFSVhiZE04VWhVME1tQlhaczVLakJ0WkxyNjlSZEc1QzFGQmRsaVBIQXdvVmViK2tYXC85In0= dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] SecurityPkg Tpm2DeviceLibDTpm: Update enum type name to match the one in lib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 14:51:10 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming: Thanks for catching this. Reviewed-by: Chao Zhang -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Limi= ng Gao Sent: Wednesday, June 27, 2018 10:49 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] SecurityPkg Tpm2DeviceLibDTpm: Update enum type nam= e to match the one in lib Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c | 2 +- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c b/Se= curityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c index 29b7d8e..815a149 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2DeviceLibDTpm.c @@ -162,7 +162,7 @@ Tpm2DeviceLibConstructor ( PcdSet8S(PcdActiveTpmInterfaceType, PtpInterface); } =20 - if (PcdGet8(PcdActiveTpmInterfaceType) =3D=3D PtpInterfaceCrb && PcdGet8= (PcdCRBIdleByPass) =3D=3D 0xFF) { + if (PcdGet8(PcdActiveTpmInterfaceType) =3D=3D Tpm2PtpInterfaceCrb && Pcd= Get8(PcdCRBIdleByPass) =3D=3D 0xFF) { IdleByPass =3D Tpm2GetIdleByPass((VOID *) (UINTN) PcdGet64 (PcdTpmBase= Address)); PcdSet8S(PcdCRBIdleByPass, IdleByPass); } diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c b/= SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c index 9301e68..9bcf7a8 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2InstanceLibDTpm.c @@ -125,7 +125,7 @@ Tpm2InstanceLibDTpmConstructor ( PcdSet8S(PcdActiveTpmInterfaceType, PtpInterface); } =20 - if (PcdGet8(PcdActiveTpmInterfaceType) =3D=3D PtpInterfaceCrb && Pcd= Get8(PcdCRBIdleByPass) =3D=3D 0xFF) { + if (PcdGet8(PcdActiveTpmInterfaceType) =3D=3D Tpm2PtpInterfaceCrb &&= PcdGet8(PcdCRBIdleByPass) =3D=3D 0xFF) { IdleByPass =3D Tpm2GetIdleByPass((VOID *) (UINTN) PcdGet64 (PcdTpm= BaseAddress)); PcdSet8S(PcdCRBIdleByPass, IdleByPass); } --=20 2.10.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel