public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Zhang, Chao B" <chao.b.zhang@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"Andrew Fish (afish@apple.com)" <afish@apple.com>,
	"Richardson, Brian" <brian.richardson@intel.com>
Subject: Re: EDK II Stable Tag release edk2-stable201808 and quiet period starting today
Date: Wed, 15 Aug 2018 02:05:46 +0000	[thread overview]
Message-ID: <FF72C7E4248F3C4E9BDF19D4918E90F24982CF23@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <84fd5fe6-0c94-393d-313c-5ae8ca3f088c@redhat.com>

Hi Laszlo:
   8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2.
   9  df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
  10  04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
  11  4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from edk2.
  12  87f9867f5536 QuarkPlatformPkg: Removing ipf which is no longer supported from edk2.
  13  fda6abd64f02 QuarkSocPkg: Removing ipf which is no longer supported from edk2.
  14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf which from edk2.

  These patches are in a patch series to remove IPF. The community review has been started a very long time before silent period.  And part of patch series was already in EDK2.
There is no source code change but only removes some useless sections in INF & DSC. And from feature complete perspective, I think it is OK to check-in.
Anyway, We will learn from this process and be more careful.


From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Tuesday, August 14, 2018 11:12 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Andrew Fish (afish@apple.com) <afish@apple.com>; Richardson, Brian <brian.richardson@intel.com>
Subject: Re: [edk2] EDK II Stable Tag release edk2-stable201808 and quiet period starting today

On 08/08/18 16:16, Kinney, Michael D wrote:
> Hello,
>
> I sent an RFC for review on EDK II stable tags.
>
> https://lists.01.org/pipermail/edk2-devel/2018-June/026474.html
>
> There were no objections and we would like to move forward
> with the an EDK II Stable Tag release.  The original goal was
> 8/10/2018.  I have seen a request to move the stable tag
> release out a few days.
>
> I recommend we target 8/15/2018 and start a quiet period
> on edk2/master starting today.  This means critical bug
> fixes only on edk2/master.  New features and large changes
> should be held until the edk2-stable201808 tag is created.
>
> Please use Bugzilla for the critical issues that must be
> fixed before the tag is created.
>
> https://bugzilla.tianocore.org/

The following commits have been pushed since we entered the quiet period
(the last commit before it was 9e6c4f1527e6, "FmpDevicePkg FmpDxe: Lock
variables in entrypoint instead of callback"):

   1  3781f14c31e0 SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR

This is a critical bugfix, satisfying the requirement.

   2  b3e1e343fe34 SecurityPkg: HashLib: Update HashLib file GUID

Can also be considered an important bugfix (GUID duplication), although
the commit does not name a TianoCore BZ.

   3  10ea1b6853f9 Maintainers.txt: Add FmpDevicePkg maintainers

Can be considered an important bugfix (no maintainers listed for a
top-level package). Misses a TianoCore BZ reference.

   4  45e076b7a720 Vlv2TbltDevicePkg/Override/Bds: Add test key notification
   5  dc65dd5be697 Vlv2TbltDevicePkg/Feature/Capsule: Add FmpDeviceLib instances
   6  d3049066ca25 Vlv2TbltDevicePkg/Capsule: Add scripts to generate capsules
   7  1aa9314e3a84 Vlv2TbltDevicePkg: Update DSC/FDF to use FmpDevicePkg

These commits violate the quiet period. They add a feature.

   8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2.
   9  df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
  10  04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
  11  4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from edk2.
  12  87f9867f5536 QuarkPlatformPkg: Removing ipf which is no longer supported from edk2.
  13  fda6abd64f02 QuarkSocPkg: Removing ipf which is no longer supported from edk2.
  14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf which from edk2.

These commits also violate the quiet period. They implement a valid
cleanup, but not a critical bugfix. They should have been delayed.

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel


  parent reply	other threads:[~2018-08-15  2:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08 14:16 EDK II Stable Tag release edk2-stable201808 and quiet period starting today Kinney, Michael D
2018-08-14 15:11 ` Laszlo Ersek
2018-08-14 18:42   ` Kinney, Michael D
2018-08-15 16:52     ` Kinney, Michael D
2018-08-15  2:05   ` Zhang, Chao B [this message]
2018-08-15 11:13     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FF72C7E4248F3C4E9BDF19D4918E90F24982CF23@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox