EDK II Stable Tag release edk2-stable201808 and quiet period starting today

EDK II Stable Tag release edk2-stable201808 and quiet period starting today

[Kinney, Michael D]

Hello,

I sent an RFC for review on EDK II stable tags.

https://lists.01.org/pipermail/edk2-devel/2018-June/026474.html

There were no objections and we would like to move forward
with the an EDK II Stable Tag release.  The original goal was
8/10/2018.  I have seen a request to move the stable tag
release out a few days.

I recommend we target 8/15/2018 and start a quiet period
on edk2/master starting today.  This means critical bug 
fixes only on edk2/master.  New features and large changes
should be held until the edk2-stable201808 tag is created.

Please use Bugzilla for the critical issues that must be
fixed before the tag is created.  

https://bugzilla.tianocore.org/

Thanks,

Mike
 

Re: EDK II Stable Tag release edk2-stable201808 and quiet period starting today

[Laszlo Ersek]

On 08/08/18 16:16, Kinney, Michael D wrote:
> Hello,
>
> I sent an RFC for review on EDK II stable tags.
>
> https://lists.01.org/pipermail/edk2-devel/2018-June/026474.html
>
> There were no objections and we would like to move forward
> with the an EDK II Stable Tag release.  The original goal was
> 8/10/2018.  I have seen a request to move the stable tag
> release out a few days.
>
> I recommend we target 8/15/2018 and start a quiet period
> on edk2/master starting today.  This means critical bug
> fixes only on edk2/master.  New features and large changes
> should be held until the edk2-stable201808 tag is created.
>
> Please use Bugzilla for the critical issues that must be
> fixed before the tag is created.
>
> https://bugzilla.tianocore.org/

The following commits have been pushed since we entered the quiet period
(the last commit before it was 9e6c4f1527e6, "FmpDevicePkg FmpDxe: Lock
variables in entrypoint instead of callback"):

   1  3781f14c31e0 SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR

This is a critical bugfix, satisfying the requirement.

   2  b3e1e343fe34 SecurityPkg: HashLib: Update HashLib file GUID

Can also be considered an important bugfix (GUID duplication), although
the commit does not name a TianoCore BZ.

   3  10ea1b6853f9 Maintainers.txt: Add FmpDevicePkg maintainers

Can be considered an important bugfix (no maintainers listed for a
top-level package). Misses a TianoCore BZ reference.

   4  45e076b7a720 Vlv2TbltDevicePkg/Override/Bds: Add test key notification
   5  dc65dd5be697 Vlv2TbltDevicePkg/Feature/Capsule: Add FmpDeviceLib instances
   6  d3049066ca25 Vlv2TbltDevicePkg/Capsule: Add scripts to generate capsules
   7  1aa9314e3a84 Vlv2TbltDevicePkg: Update DSC/FDF to use FmpDevicePkg

These commits violate the quiet period. They add a feature.

   8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2.
   9  df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
  10  04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
  11  4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from edk2.
  12  87f9867f5536 QuarkPlatformPkg: Removing ipf which is no longer supported from edk2.
  13  fda6abd64f02 QuarkSocPkg: Removing ipf which is no longer supported from edk2.
  14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf which from edk2.

These commits also violate the quiet period. They implement a valid
cleanup, but not a critical bugfix. They should have been delayed.

Laszlo

Re: EDK II Stable Tag release edk2-stable201808 and quiet period starting today

[Kinney, Michael D]

Laszlo,

Thank you for this valuable feedback on the commit
activity in the quiet period.  I agree with your analysis.

Bugzillas should have been entered for all of these
changes and discussed on the mailing list and approved
before commit.

We will learn from this experience and apply it as we
complete the current quiet period and apply to future
ones.

At this time, I am only aware of one additional change
request before adding the edk2-stable201808 tag:

https://bugzilla.tianocore.org/show_bug.cgi?id=1087

Thanks,

Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, August 14, 2018 8:12 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> edk2-devel@lists.01.org; leif.lindholm@linaro.org;
> Andrew Fish (afish@apple.com) <afish@apple.com>;
> Richardson, Brian <brian.richardson@intel.com>
> Subject: Re: [edk2] EDK II Stable Tag release edk2-
> stable201808 and quiet period starting today
> 
> On 08/08/18 16:16, Kinney, Michael D wrote:
> > Hello,
> >
> > I sent an RFC for review on EDK II stable tags.
> >
> > https://lists.01.org/pipermail/edk2-devel/2018-
> June/026474.html
> >
> > There were no objections and we would like to move
> forward
> > with the an EDK II Stable Tag release.  The original
> goal was
> > 8/10/2018.  I have seen a request to move the stable
> tag
> > release out a few days.
> >
> > I recommend we target 8/15/2018 and start a quiet
> period
> > on edk2/master starting today.  This means critical
> bug
> > fixes only on edk2/master.  New features and large
> changes
> > should be held until the edk2-stable201808 tag is
> created.
> >
> > Please use Bugzilla for the critical issues that must
> be
> > fixed before the tag is created.
> >
> > https://bugzilla.tianocore.org/
> 
> The following commits have been pushed since we entered
> the quiet period
> (the last commit before it was 9e6c4f1527e6,
> "FmpDevicePkg FmpDxe: Lock
> variables in entrypoint instead of callback"):
> 
>    1  3781f14c31e0
> SecurityPkg/Library/Tpm2DeviceLibDTpm: fix
> s/Constructor/CONSTRUCTOR
> 
> This is a critical bugfix, satisfying the requirement.
> 
>    2  b3e1e343fe34 SecurityPkg: HashLib: Update HashLib
> file GUID
> 
> Can also be considered an important bugfix (GUID
> duplication), although
> the commit does not name a TianoCore BZ.
> 
>    3  10ea1b6853f9 Maintainers.txt: Add FmpDevicePkg
> maintainers
> 
> Can be considered an important bugfix (no maintainers
> listed for a
> top-level package). Misses a TianoCore BZ reference.
> 
>    4  45e076b7a720 Vlv2TbltDevicePkg/Override/Bds: Add
> test key notification
>    5  dc65dd5be697 Vlv2TbltDevicePkg/Feature/Capsule:
> Add FmpDeviceLib instances
>    6  d3049066ca25 Vlv2TbltDevicePkg/Capsule: Add
> scripts to generate capsules
>    7  1aa9314e3a84 Vlv2TbltDevicePkg: Update DSC/FDF to
> use FmpDevicePkg
> 
> These commits violate the quiet period. They add a
> feature.
> 
>    8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no
> longer supported from edk2.
>    9  df49a85dbcc6 CorebootModulePkg: Removing ipf from
> edk2.
>   10  04c7f9023ffe CorebootPayloadPkg: Removing ipf
> from edk2.
>   11  4fcb0d54584f NetworkPkg: Removing ipf which is no
> longer supported from edk2.
>   12  87f9867f5536 QuarkPlatformPkg: Removing ipf which
> is no longer supported from edk2.
>   13  fda6abd64f02 QuarkSocPkg: Removing ipf which is
> no longer supported from edk2.
>   14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf
> which from edk2.
> 
> These commits also violate the quiet period. They
> implement a valid
> cleanup, but not a critical bugfix. They should have
> been delayed.
> 
> Laszlo

Re: EDK II Stable Tag release edk2-stable201808 and quiet period starting today

[Kinney, Michael D]

Hello,

I have committed the patch and closed the following
issue:

https://bugzilla.tianocore.org/show_bug.cgi?id=1087

I have not seen any additional requests for critical
bug fixes.  If I do not see any additional requests
in the next few hours, then I will add the following
tag to edk2/master.

	edk2-stable201808

Thanks,

Mike

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Tuesday, August 14, 2018 11:43 AM
> To: Laszlo Ersek <lersek@redhat.com>; edk2-
> devel@lists.01.org; leif.lindholm@linaro.org; Andrew
> Fish (afish@apple.com) <afish@apple.com>; Richardson,
> Brian <brian.richardson@intel.com>; Kinney, Michael D
> (michael.d.kinney@intel.com)
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2] EDK II Stable Tag release edk2-
> stable201808 and quiet period starting today
> 
> Laszlo,
> 
> Thank you for this valuable feedback on the commit
> activity in the quiet period.  I agree with your
> analysis.
> 
> Bugzillas should have been entered for all of these
> changes and discussed on the mailing list and approved
> before commit.
> 
> We will learn from this experience and apply it as we
> complete the current quiet period and apply to future
> ones.
> 
> At this time, I am only aware of one additional change
> request before adding the edk2-stable201808 tag:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1087
> 
> Thanks,
> 
> Mike
> 
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Tuesday, August 14, 2018 8:12 AM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > edk2-devel@lists.01.org; leif.lindholm@linaro.org;
> > Andrew Fish (afish@apple.com) <afish@apple.com>;
> > Richardson, Brian <brian.richardson@intel.com>
> > Subject: Re: [edk2] EDK II Stable Tag release edk2-
> > stable201808 and quiet period starting today
> >
> > On 08/08/18 16:16, Kinney, Michael D wrote:
> > > Hello,
> > >
> > > I sent an RFC for review on EDK II stable tags.
> > >
> > > https://lists.01.org/pipermail/edk2-devel/2018-
> > June/026474.html
> > >
> > > There were no objections and we would like to move
> > forward
> > > with the an EDK II Stable Tag release.  The
> original
> > goal was
> > > 8/10/2018.  I have seen a request to move the
> stable
> > tag
> > > release out a few days.
> > >
> > > I recommend we target 8/15/2018 and start a quiet
> > period
> > > on edk2/master starting today.  This means critical
> > bug
> > > fixes only on edk2/master.  New features and large
> > changes
> > > should be held until the edk2-stable201808 tag is
> > created.
> > >
> > > Please use Bugzilla for the critical issues that
> must
> > be
> > > fixed before the tag is created.
> > >
> > > https://bugzilla.tianocore.org/
> >
> > The following commits have been pushed since we
> entered
> > the quiet period
> > (the last commit before it was 9e6c4f1527e6,
> > "FmpDevicePkg FmpDxe: Lock
> > variables in entrypoint instead of callback"):
> >
> >    1  3781f14c31e0
> > SecurityPkg/Library/Tpm2DeviceLibDTpm: fix
> > s/Constructor/CONSTRUCTOR
> >
> > This is a critical bugfix, satisfying the
> requirement.
> >
> >    2  b3e1e343fe34 SecurityPkg: HashLib: Update
> HashLib
> > file GUID
> >
> > Can also be considered an important bugfix (GUID
> > duplication), although
> > the commit does not name a TianoCore BZ.
> >
> >    3  10ea1b6853f9 Maintainers.txt: Add FmpDevicePkg
> > maintainers
> >
> > Can be considered an important bugfix (no maintainers
> > listed for a
> > top-level package). Misses a TianoCore BZ reference.
> >
> >    4  45e076b7a720 Vlv2TbltDevicePkg/Override/Bds:
> Add
> > test key notification
> >    5  dc65dd5be697 Vlv2TbltDevicePkg/Feature/Capsule:
> > Add FmpDeviceLib instances
> >    6  d3049066ca25 Vlv2TbltDevicePkg/Capsule: Add
> > scripts to generate capsules
> >    7  1aa9314e3a84 Vlv2TbltDevicePkg: Update DSC/FDF
> to
> > use FmpDevicePkg
> >
> > These commits violate the quiet period. They add a
> > feature.
> >
> >    8  667abfaf8a16 UefiCpuPkg: Removing ipf which is
> no
> > longer supported from edk2.
> >    9  df49a85dbcc6 CorebootModulePkg: Removing ipf
> from
> > edk2.
> >   10  04c7f9023ffe CorebootPayloadPkg: Removing ipf
> > from edk2.
> >   11  4fcb0d54584f NetworkPkg: Removing ipf which is
> no
> > longer supported from edk2.
> >   12  87f9867f5536 QuarkPlatformPkg: Removing ipf
> which
> > is no longer supported from edk2.
> >   13  fda6abd64f02 QuarkSocPkg: Removing ipf which is
> > no longer supported from edk2.
> >   14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf
> > which from edk2.
> >
> > These commits also violate the quiet period. They
> > implement a valid
> > cleanup, but not a critical bugfix. They should have
> > been delayed.
> >
> > Laszlo

Re: EDK II Stable Tag release edk2-stable201808 and quiet period starting today

[Zhang, Chao B]

Hi Laszlo：
   8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2.
   9  df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
  10  04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
  11  4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from edk2.
  12  87f9867f5536 QuarkPlatformPkg: Removing ipf which is no longer supported from edk2.
  13  fda6abd64f02 QuarkSocPkg: Removing ipf which is no longer supported from edk2.
  14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf which from edk2.

  These patches are in a patch series to remove IPF. The community review has been started a very long time before silent period.  And part of patch series was already in EDK2.
There is no source code change but only removes some useless sections in INF & DSC. And from feature complete perspective, I think it is OK to check-in.
Anyway, We will learn from this process and be more careful.


From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Tuesday, August 14, 2018 11:12 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org; leif.lindholm@linaro.org; Andrew Fish (afish@apple.com) <afish@apple.com>; Richardson, Brian <brian.richardson@intel.com>
Subject: Re: [edk2] EDK II Stable Tag release edk2-stable201808 and quiet period starting today

On 08/08/18 16:16, Kinney, Michael D wrote:
> Hello,
>
> I sent an RFC for review on EDK II stable tags.
>
> https://lists.01.org/pipermail/edk2-devel/2018-June/026474.html
>
> There were no objections and we would like to move forward
> with the an EDK II Stable Tag release.  The original goal was
> 8/10/2018.  I have seen a request to move the stable tag
> release out a few days.
>
> I recommend we target 8/15/2018 and start a quiet period
> on edk2/master starting today.  This means critical bug
> fixes only on edk2/master.  New features and large changes
> should be held until the edk2-stable201808 tag is created.
>
> Please use Bugzilla for the critical issues that must be
> fixed before the tag is created.
>
> https://bugzilla.tianocore.org/

The following commits have been pushed since we entered the quiet period
(the last commit before it was 9e6c4f1527e6, "FmpDevicePkg FmpDxe: Lock
variables in entrypoint instead of callback"):

   1  3781f14c31e0 SecurityPkg/Library/Tpm2DeviceLibDTpm: fix s/Constructor/CONSTRUCTOR

This is a critical bugfix, satisfying the requirement.

   2  b3e1e343fe34 SecurityPkg: HashLib: Update HashLib file GUID

Can also be considered an important bugfix (GUID duplication), although
the commit does not name a TianoCore BZ.

   3  10ea1b6853f9 Maintainers.txt: Add FmpDevicePkg maintainers

Can be considered an important bugfix (no maintainers listed for a
top-level package). Misses a TianoCore BZ reference.

   4  45e076b7a720 Vlv2TbltDevicePkg/Override/Bds: Add test key notification
   5  dc65dd5be697 Vlv2TbltDevicePkg/Feature/Capsule: Add FmpDeviceLib instances
   6  d3049066ca25 Vlv2TbltDevicePkg/Capsule: Add scripts to generate capsules
   7  1aa9314e3a84 Vlv2TbltDevicePkg: Update DSC/FDF to use FmpDevicePkg

These commits violate the quiet period. They add a feature.

   8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2.
   9  df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
  10  04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
  11  4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from edk2.
  12  87f9867f5536 QuarkPlatformPkg: Removing ipf which is no longer supported from edk2.
  13  fda6abd64f02 QuarkSocPkg: Removing ipf which is no longer supported from edk2.
  14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf which from edk2.

These commits also violate the quiet period. They implement a valid
cleanup, but not a critical bugfix. They should have been delayed.

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel

Re: EDK II Stable Tag release edk2-stable201808 and quiet period starting today

[Laszlo Ersek]

On 08/15/18 04:05, Zhang, Chao B wrote:
> Hi Laszlo
>    8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no longer supported from edk2.
>    9  df49a85dbcc6 CorebootModulePkg: Removing ipf from edk2.
>   10  04c7f9023ffe CorebootPayloadPkg: Removing ipf from edk2.
>   11  4fcb0d54584f NetworkPkg: Removing ipf which is no longer supported from edk2.
>   12  87f9867f5536 QuarkPlatformPkg: Removing ipf which is no longer supported from edk2.
>   13  fda6abd64f02 QuarkSocPkg: Removing ipf which is no longer supported from edk2.
>   14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf which from edk2.
>
> These patches are in a patch series to remove IPF. The community
> review has been started a very long time before silent period.  And
> part of patch series was already in EDK2.
> There is no source code change but only removes some useless sections
> in INF & DSC. And from feature complete perspective, I think it is OK
> to check-in.
> Anyway, We will learn from this process and be more careful.

We should distinguish two things here.

- The first is the scope of the quiet period. That is, what kinds of
commits are permitted, for what packages.

- The second is whether (and how) we honor the quiet period.

My email was about the 2nd point; that is, that we should respect the
quiet period, with whatever scope that had been set.

The scope was set by Mike's earlier announcement (1st point), and it
said "critical issues only" and "bugzillas required".

I'm fine with updating the scope, even during the quiet period, but it
should be a discussion. Most other open source projects do something
similar; for example they tag release candidates (RCs) before an actual
release, and they keep iterating release candidates until all known
regressions or critical bugs are fixed. Sometimes they might even
postpone a release (and then the tag name could be necessary to update)
-- such projects say, "it's done when it's done, and not when a specific
date arrives".


In the QEMU project there are two kinds of "freezes", for entering the
quiet period.

https://wiki.qemu.org/Planning/SoftFeatureFreeze
https://wiki.qemu.org/Planning/HardFeatureFreeze

* Using that terminology, and considering the quiet period announcement
from 8 Aug a "soft freeze", merging the remaining IPF removal patches
would have been fine, between the soft freeze and the hard freeze,
because the patches had been posted and reviewed before the soft freeze.

On the other hand, Mike's series "[edk2] [Patch 0/4] Vlv2TbltDevicePkg:
Add FmpDevicePkg support" wouldn't qualify, because it was posted on 10
Aug (the quiet period, now interpreted as "soft freeze", was announced
on 8 Aug).

* Alternatively, considering the quiet period announcement from 8 Aug a
"hard freeze", neither patch set should have been pushed, because none
of them are bug fixes.


Personally I took the announcement as a "hard freeze", because it said
"critical bug fixes only".

Again, if we'd really like to complete some pending features before
tagging a commit as "stable", I'm fine if we move out the tag a few
weeks. The point is, once we determine a scope, we should stick to it;
and if modifications are necessary, discuss them on the list (or in
BZs). Otherwise different maintainers will gate commits against
different criteria.


Another thing I believe QEMU does well is a "planning" wiki page, for
the next release. This helps developers keep the scope up-to-date, and
compare feature / bugfix status (e.g. list of BZs) against the most
recently set release date.

https://wiki.qemu.org/Planning/3.0

Thanks
Laszlo