From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chao.b.zhang@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 17 Apr 2019 20:30:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 20:30:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,364,1549958400"; d="scan'208";a="135302807" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 17 Apr 2019 20:30:47 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 17 Apr 2019 20:30:47 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 17 Apr 2019 20:30:47 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.164]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 11:30:45 +0800 From: "Zhang, Chao B" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Gao, Liming" , Sean Brogan , "Michael Turner" , Bret Barkelew Subject: Re: [PATCH V2 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Thread-Topic: [PATCH V2 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Thread-Index: AQHU9ObB2HjGpcIoIkq9LyyS2o4ReaZBRFSw Date: Thu, 18 Apr 2019 03:30:44 +0000 Message-ID: References: <20190417062722.8568-1-zhichao.gao@intel.com> <20190417062722.8568-6-zhichao.gao@intel.com> In-Reply-To: <20190417062722.8568-6-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDZmMWI2NGEtMzNmNC00YTgxLTlmNmItMWU5NDgwZDgxNDAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQWo2VnRXSG9pVGp6WFlhM21wQ081Z0dMSFRGSk1WbmlHWjU5MUNCUFB4dkQwbURUZ2xFRDYrTUh3OTZLUkhyZiJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: chao.b.zhang@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chao Zhang -----Original Message----- From: Gao, Zhichao=20 Sent: Wednesday, April 17, 2019 2:27 PM To: devel@edk2.groups.io Cc: Zhang, Chao B ; Yao, Jiewen ; Gao, Liming ; Sean Brogan ; Michael Turner ; Bret Barkelew Subject: [PATCH V2 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownT= pmOnReset REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus is EFI_SUC= CESS regardless of the ResetType is EfiResetPlatformSpecific or not. Cc: Chao Zhang Cc: Jiewen Yao Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tc= g2Dxe.c index b3e21f0947..a2729457b7 100644 --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c @@ -1,7 +1,7 @@ /** @file This module implements Tcg2 Protocol. =20 -Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
+Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.
(C) Copyright 2016 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -2419,10 +2419,7 @@ OnExitBootServicesFailed ( EfiResetShutdown the data buffer starts wi= th a Null-terminated string, optionally followed by additional = binary data. The string is a description that the calle= r may use to further - indicate the reason for the system reset. = ResetData is only - valid if ResetStatus is something other th= an EFI_SUCCESS - unless the ResetType is EfiResetPlatformSp= ecific - where a minimum amount of ResetData is alw= ays required. + indicate the reason for the system reset. For a ResetType of EfiResetPlatformSpecifi= c the data buffer also starts with a Null-terminated string = that is followed by an EFI_GUID that describes the specific= type of reset to perform. -- 2.21.0.windows.1