Hi Andrew:
Tks for your explanation.
The middle octet of StartingCHS (0x000200) is for Sector. Based on CHS to LBA conversion rule. It should be 0x02. I think it is an spec compliance issue.
Partition Dxe driver doesn’t apply such check so there is no problem. Partition Pei is in BIOS TCB,
we applied stronger check and exposed this issue.
We need carefully document such limitation somewhere.
BTW the whole GPT support in PEI is new in Q1 stable tag,
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
On Behalf Of Andrew Fish via Groups.Io
Sent: Thursday, April 25, 2019 12:07 AM
To: devel@edk2.groups.io; Xu, Wei6 <wei6.xu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] Question about the Protective MBR in RedHat/Ubuntu
The intent of the protective MBR was to prevent tools that did not understand GPT to not think a GPT disk was blank. 20 years ago that made a lot of sense, today it is kind of an obsolete concept.
The protective MBR was never intended to identify the disk as GPT, but it seems it got used as a short cut to not have to read a variable number of blocks from the disk to validate the GPT header.
From a practical sense the DXE Partition driver uses this algorithm to validate the Protective MBR. It would be a good idea for the PEI code to do the same thing.
|
// |
|
|
// Verify that the Protective MBR is valid |
|
|
// |
|
|
for
(Index = 0; Index < MAX_MBR_PARTITIONS; Index++) { |
|
|
if
(ProtectiveMbr->Partition[Index].BootIndicator ==
0x00 && |
|
|
ProtectiveMbr->Partition[Index].OSIndicator == PMBR_GPT_PARTITION && |
|
|
UNPACK_UINT32
(ProtectiveMbr->Partition[Index].StartingLBA) ==
1 |
|
|
) { |
|
|
break; |
|
|
} |
|
|
} |
|
|
if
(Index == MAX_MBR_PARTITIONS) { |
|
|
goto
Done; |
|
|
} |
|
I'd also point out that that ATA-6 specification obsoleted CHS addressing in 2002 and I think the 0x200 has to do with the sector size of 512 bytes, which is also kind of an obsolete concept. So I'm not sure what the 0x100 is about in your
example?
Thanks,
Andrew Fish