From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: chao.b.zhang@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 12 Jun 2019 01:13:49 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 01:13:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,363,1557212400"; d="scan'208,217";a="184167907" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 12 Jun 2019 01:13:47 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Jun 2019 01:13:47 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Jun 2019 01:13:46 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.33]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.98]) with mapi id 14.03.0415.000; Wed, 12 Jun 2019 16:13:45 +0800 From: "Zhang, Chao B" To: "Wu, Hao A" , "devel@edk2.groups.io" , "Xu, Wei6" CC: "Wang, Jian J" , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. Thread-Topic: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. Thread-Index: AQHVG7VFddka4HU8Yk2VUGE0K/vSRqaXKMIAgACNMuA= Date: Wed, 12 Jun 2019 08:13:44 +0000 Message-ID: References: <20190605154203.11012-1-wei6.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmYzYmMwNmMtNWJmOS00YTM1LWFjZTctOGE3NTRmMGMxY2M4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSXNCTzdnQ2hvMWxFZWg0Q2ROMERyYUJCQzlWM05UV1lkbmJsWW5TK2FWT09CVmQrbFBjOXViNldrRTRDNnlyZCJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: chao.b.zhang@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_FF72C7E4248F3C4E9BDF19D4918E90F24DED8D85shsmsx102ccrcor_" --_000_FF72C7E4248F3C4E9BDF19D4918E90F24DED8D85shsmsx102ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Hao: I don't have extra comments for the whole patch From: Wu, Hao A Sent: Wednesday, June 12, 2019 3:48 PM To: devel@edk2.groups.io; Xu, Wei6 ; Zhang, Chao B Cc: Wang, Jian J ; Kinney, Michael D ; Gao, Liming Subject: RE: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. Hello Chao, Do you have any comment/feedback on this series? One comment with regard to the series below: > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@ed= k2.groups.io] On Behalf Of > Xu, Wei6 > Sent: Wednesday, June 05, 2019 11:42 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Kinney, Michael D; Gao, Liming; Zhang, Chao= B > Subject: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk. > > V2: > Fix Ecc check failure. > > V1: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1852 > > This patch set implements Capsule On Disk. > Depends on whether platform supports Capsule-In-Ram, Capsule On Disk > feature is composed of 2 solutions: > Solution A): Load capsules out of TCB, rely on UpdateCapsule() runtime > service to deliver Capsule-On-Disk. > Solution B): Relocate capsules into a temp file which will be stored in = root > directory on a platform specific storage device. > Leverage existing storage stack in PEI to load all capsule on disk image= s and > create capsule hobs for the capsules. > This solution has bigger TCB, but can work without Capsule-In-RAM suppor= t. > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Chao B Zhang > > > xuwei6 (7): > MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition. > MdeModulePkg: Add Capsule On Disk related definition. > MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM. > MdeModulePkg/BdsDxe: Support Capsule On Disk. > MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature. > MdeModulePkg/DxeIpl: Support Capsule On Disk. > MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib. Please re-order the sequence of the patches. I found that the below patch: MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM. depends on some definitions added in patch (last one): MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib. Best Regards, Hao Wu > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 3 +- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 20 +- > MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 37 +- > MdeModulePkg/Include/Library/CapsuleLib.h | 94 +- > MdeModulePkg/Include/Ppi/CapsuleOnDisk.h | 48 + > .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.c | 1983 > ++++++++++++++++++++ > .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.h | 63 + > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 56 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | 21 +- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | 121 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c | 67 +- > .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | 3 +- > .../Library/DxeCapsuleLibNull/DxeCapsuleLibNull.c | 85 +- > MdeModulePkg/MdeModulePkg.dec | 43 + > MdeModulePkg/MdeModulePkg.dsc | 4 + > MdeModulePkg/MdeModulePkg.uni | 32 + > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 3 +- > MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 6 +- > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.c | 442 +++++ > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.inf | 64 + > .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.uni | 15 + > .../CapsuleOnDiskLoadPeiExtra.uni | 14 + > .../CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 1 + > .../Universal/CapsuleRuntimeDxe/CapsuleService.c | 10 +- > MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 +- > MdePkg/MdePkg.dec | 3 + > 26 files changed, 3205 insertions(+), 42 deletions(-) > create mode 100644 MdeModulePkg/Include/Ppi/CapsuleOnDisk.h > create mode 100644 > MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c > create mode 100644 > MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.h > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.c > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.i > nf > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.u > ni > create mode 100644 > MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPeiE > xtra.uni > > -- > 2.16.2.windows.1 > > >=20 --_000_FF72C7E4248F3C4E9BDF19D4918E90F24DED8D85shsmsx102ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

HI Hao:

  I don’t have extra commen= ts for the whole patch

 = ;

From: Wu, Hao A
Sent: Wednesday, June 12, 2019 3:48 PM
To: devel@edk2.groups.io; Xu, Wei6 <wei6.xu@intel.com>; Zhang= , Chao B <chao.b.zhang@intel.com>
Cc: Wang, Jian J <jian.j.wang@intel.com>; Kinney, Michael D &= lt;michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>=
Subject: RE: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.<= o:p>

 

Hello Chao,

Do you have any comment/fe= edback on this series?

One comment with regard to=  the series below:

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Xu, Wei6
> Sent: Wednesday, June&nbs= p;05, 2019 11:42 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J;&nb= sp;Wu, Hao A; Kinney, Michael D; Gao, Li= ming; Zhang, Chao B
> Subject: [edk2-devel][Patch&nb= sp;v2 0/7] Implement Capsule On Disk.
> 
> V2:
> Fix Ecc check failur= e.
> 
> V1:
> BZ: https://bugzilla.tianocore.org/show= _bug.cgi?id=3D1852
> 
> This patch set imple= ments Capsule On Disk.
> Depends on whether p= latform supports Capsule-In-Ram, Capsule On Disk
> feature is composed = of 2 solutions:
> Solution A): Load ca= psules out of TCB, rely on UpdateCapsule()&nb= sp;runtime
> service to deliver C= apsule-On-Disk.
> Solution B): Relocate&nbs= p;capsules into a temp file which will b= e stored in root
> directory on a platf= orm specific storage device.
> Leverage existing storage=  stack in PEI to load all capsule o= n disk images and
> create capsule hobs = for the capsules.
> This solution has bi= gger TCB, but can work without Capsule-In-RAM=  support.
> 
> 
> Cc: Jian J Wang = ;<jian.j.wang@intel.com>=
> Cc: Hao A Wu &l= t;hao.a.wu@intel.com> > Cc: Michael D Kinney=  <michael.d.kinney@in= tel.com>
> Cc: Liming Gao <<= a href=3D"mailto:liming.gao@intel.com">liming.gao@intel.com><= br> > Cc: Chao B Zhang&nbs= p;<chao.b.zhang@intel.com&= gt;
> 
> xuwei6 (7):
>   MdePkg: Add P= ei Boot In CapsuleOnDisk Mode Ppi definition.=
>   MdeModulePkg: Add&= nbsp;Capsule On Disk related definition.
>   MdeModulePkg: Add&= nbsp;CapsuleOnDiskLoadPei PEIM.
>   MdeModulePkg/BdsDxe:&nb= sp;Support Capsule On Disk.
>   MdeModulePkg/CapsuleRun= timeDxe: Introduce PCD to control this featur= e.
>   MdeModulePkg/DxeIpl:&nb= sp;Support Capsule On Disk.
>   MdeModulePkg: Add&= nbsp;Capsule On Disk APIs into CapsuleLib.<= br>

Please re-order the sequence&nb= sp;of the patches.
I found that the below&nbs= p;patch:
MdeModulePkg: Add CapsuleOnDiskLoadP= ei PEIM.

depends on some definitions&nbs= p;added in patch (last one):
MdeModulePkg: Add Capsule On&nb= sp;Disk APIs into CapsuleLib.

Best Regards,
Hao Wu


> 
>  MdeModulePkg/Core/DxeIplPeim/= DxeIpl.h           &= nbsp;  |    3 +-
>  MdeModulePkg/Core/DxeIplPeim/= DxeIpl.inf           = ; |   20 +-
>  MdeModulePkg/Core/DxeIplPeim/= DxeLoad.c           =   |   37 +-
>  MdeModulePkg/Include/Library/= CapsuleLib.h          |&n= bsp;  94 +-
>  MdeModulePkg/Include/Ppi/Caps= uleOnDisk.h          &nbs= p;|   48 +
>  .../Library/DxeCapsuleLibFmp/= CapsuleOnDisk.c       | 1983=
> +++++++= +++++++++++++ >  .../Library/DxeCapsuleLibFmp/= CapsuleOnDisk.h       |   = ;63 +
>  .../Library/DxeCapsuleLibFmp/= DxeCapsuleLib.c       |   = ;56 +-
>  .../Library/DxeCapsuleLibFmp/= DxeCapsuleLib.inf     |   21 &= #43;-
>  .../DxeCapsuleLibFmp/DxeCapsu= leProcessLib.c        |  = 121 +-
>  .../Library/DxeCapsuleLibFmp/= DxeCapsuleReportLib.c |   67 +-
>  .../DxeCapsuleLibFmp/DxeRunti= meCapsuleLib.inf      |   &nbs= p;3 +-
>  .../Library/DxeCapsuleLibNull= /DxeCapsuleLibNull.c  |   85 +- >  MdeModulePkg/MdeModulePkg.dec=             &nb= sp;         |   = ;43 +
>  MdeModulePkg/MdeModulePkg.dsc=             &nb= sp;         |   = ; 4 +
>  MdeModulePkg/MdeModulePkg.uni=             &nb= sp;         |   = ;32 +
>  MdeModulePkg/Universal/BdsDxe= /BdsDxe.inf          &nbs= p;|    3 +-
>  MdeModulePkg/Universal/BdsDxe= /BdsEntry.c          &nbs= p;|    6 +-
>  .../CapsuleOnDiskLoadPei/Caps= uleOnDiskLoadPei.c    |  442 ++&= #43;++
>  .../CapsuleOnDiskLoadPei/Caps= uleOnDiskLoadPei.inf  |   64 +
>  .../CapsuleOnDiskLoadPei/Caps= uleOnDiskLoadPei.uni  |   15 +
>  .../CapsuleOnDiskLoadPeiExtra= .uni            = ;      |   14 +
>  .../CapsuleRuntimeDxe/Capsule= RuntimeDxe.inf        |  =   1 +
>  .../Universal/CapsuleRuntimeD= xe/CapsuleService.c   |   10 +-
>  MdePkg/Include/Ppi/BootInReco= veryMode.h           = ; |    9 +-
>  MdePkg/MdePkg.dec  =             &nb= sp;            =        |    3 &= #43;
>  26 files changed,&n= bsp;3205 insertions(+), 42 deletions(-)
>  create mode 100644&= nbsp;MdeModulePkg/Include/Ppi/CapsuleOnDisk.h
>  create mode 100644<= /span>
> MdeModulePkg/Library/DxeCapsuleLibF= mp/CapsuleOnDisk.c
>  create mode 100644<= /span>
> MdeModulePkg/Library/DxeCapsuleLibF= mp/CapsuleOnDisk.h
>  create mode 100644<= /span>
> MdeModulePkg/Universal/CapsuleOnDis= kLoadPei/CapsuleOnDiskLoadPei.c
>  create mode 100644<= /span>
> MdeModulePkg/Universal/CapsuleOnDis= kLoadPei/CapsuleOnDiskLoadPei.i
> nf
>  create mode 100644<= /span>
> MdeModulePkg/Universal/CapsuleOnDis= kLoadPei/CapsuleOnDiskLoadPei.u
> ni
>  create mode 100644<= /span>
> MdeModulePkg/Universal/CapsuleOnDis= kLoadPei/CapsuleOnDiskLoadPeiE
> xtra.uni
> 
> --
> 2.16.2.windows.1
> 
> 
> 

--_000_FF72C7E4248F3C4E9BDF19D4918E90F24DED8D85shsmsx102ccrcor_--