From: "Zhang, Chao B" <chao.b.zhang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"derek.lin2@hpe.com" <derek.lin2@hpe.com>
Subject: Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode
Date: Tue, 9 Jul 2019 15:39:12 +0000 [thread overview]
Message-ID: <FF72C7E4248F3C4E9BDF19D4918E90F24DEF062A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <7564.1562045108414671150@groups.io>
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
Hi Derek:
The patch is good to me.
Reviewed-by : Chao Zhang <chao.b.zhang@intel.com>
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of derek.lin2@hpe.com
Sent: Tuesday, July 2, 2019 1:25 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode
Patch is attached from group.io.
Since ECR785, which is added UEFI 2.3.1 errata A, enrolling a PK in setup mode doesn't need to verify the PK.
Below is the sentence about it in UEFI spec
```
3. If the firmware is in setup mode and the variable is one of:
- The global PK variable;
- The global KEK variable;
- The "db" variable with GUID EFI_IMAGE_SECURITY_DATABASE_GUID; or
- The "dbx" variable with GUID EFI_IMAGE_SECURITY_DATABASE_GUID,
then the firmware implementation shall consider the checks in the following steps 4 and 5 to
have passed, and proceed with updating the variable value as outlined below.
```
The step 4 is to verify the signature and the step 5 is to verify the cert.
After this change, when system is in Setup mode, setting a PK does not require authenticated variable descriptor.
Signed-off-by: Derek Lin <derek.lin2@hpe.com<mailto:derek.lin2@hpe.com>>
Signed-off-by: cinnamon shia <cinnamon.shia@hpe.com<mailto:cinnamon.shia@hpe.com>>
[-- Attachment #2: Type: text/html, Size: 5438 bytes --]
next prev parent reply other threads:[~2019-07-09 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 5:25 [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode derek.lin2
2019-07-04 6:29 ` [edk2-devel] " derek.lin2
2019-07-09 15:39 ` Zhang, Chao B [this message]
2019-07-10 8:50 ` Wang, Jian J
2019-07-10 17:04 ` Laszlo Ersek
2019-07-11 3:20 ` Zhang, Chao B
2019-07-11 11:47 ` Laszlo Ersek
2019-07-12 1:41 ` Zhang, Chao B
2019-08-23 3:20 ` Lin, Derek (HPS SW)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FF72C7E4248F3C4E9BDF19D4918E90F24DEF062A@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox