From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mx.groups.io with SMTP id smtpd.web08.2364.1665134102931628536 for ; Fri, 07 Oct 2022 02:15:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@9elements.com header.s=google header.b=Ik+zVE2J; spf=pass (domain: 9elements.com, ip: 209.85.208.182, mailfrom: sheng.tan@9elements.com) Received: by mail-lj1-f182.google.com with SMTP id by36so5010857ljb.4 for ; Fri, 07 Oct 2022 02:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=p3nt0ac7pepbUcMiUS2BRArRJeG2tyqY7Zk3HucKnMI=; b=Ik+zVE2JF3uzRl6WsbpesePxXJWEfUH+I2+TdKdkPHkZmn9XhTRUT+KRopZxBJbaN8 BYmoSp/zFD9QRoFxnI6a4k1atPM8i/EetylvcJScCNwk/Z2pHe8NPw+sB/kyuDHMIy0f fiXHZdI1j2Sqyk90i3YK0FNO+74abQPuhoaYM5bp2XWC03KI8Ff+Ie0eyOlEa11lsZ4n aa2kUTTN+GlnLq99MUpNYhmeFlSD4ZBnkyG2IFOx1GkqF8Y8kIHcKeoTdnqSNkSvusT6 C2rh1bTVqtu70X/XkL4OJLtV2GP4crhmKQ8wRw6B69wHSu17fh4+dWF6K28LioxN7Pk3 AkSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p3nt0ac7pepbUcMiUS2BRArRJeG2tyqY7Zk3HucKnMI=; b=wW3BNpBLIVHbVdDHbMuQfkV6BIgmKI50uZa9P9oXt+qUSOTO8pJ4lA7IGYFaTq+cU+ 2QxhhJPW3BFGP5grAS7RoSnSlfpM5Zge1AyuEpnTL1vPXbagXH5mfhYVhoX16V8dMSmp 2/J2lBpOTDCO8pLimHF14LXdjwHqIgLQllqx34Kgexfp1vxqwrFGWoNPqm7qckdsMC2a npCierUk98Lx5LmRIpiklSh8YS+WnYgVsYJUxEKSg9h744YOr7BUT0L03pB+gkBtrmRA ULldToJ22wMK3XTrO7wAchsQYOhcMhMXPo9nh167x5BjzyHMZuHOTKE/j9u6viqozHIJ HFyA== X-Gm-Message-State: ACrzQf1LzcYg7V/cavYxs829iQpX16mSs7LKZD20jKy4gVdPW8yA0t6A vNreNzb/OUMnWy4ohBXYbJ3IVz+Ul2I8LZfv X-Google-Smtp-Source: AMsMyM4KwRUCR80TBgIsum8JUpaBWbLppX490SveGkutcD3fS57ZQeSZ8hEG3Xr3ANyV+FOCEeTHNg== X-Received: by 2002:a05:651c:506:b0:26e:6fa:8a53 with SMTP id o6-20020a05651c050600b0026e06fa8a53mr1253526ljp.93.1665134100439; Fri, 07 Oct 2022 02:15:00 -0700 (PDT) Return-Path: Received: from GV2P195MB2090.EURP195.PROD.OUTLOOK.COM ([2603:1026:c11:c37::5]) by smtp.gmail.com with ESMTPSA id h15-20020ac250cf000000b00499b27a329esm211838lfm.300.2022.10.07.02.14.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2022 02:15:00 -0700 (PDT) From: "Sheng Lean Tan" To: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations Thread-Topic: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations Thread-Index: AW45OTcwbalRE96pGc2GiiM1dVLf4tU7n2dPgAZIp9o= X-MS-Exchange-MessageSentRepresentingType: 1 Date: Fri, 7 Oct 2022 09:14:58 +0000 Message-ID: References: <9c3d2f03a7f021c5044301f7b4d869b70e8990e0.1664179796.git.sean@starlabs.systems> <171A84BCA8A12F72.28182@groups.io> In-Reply-To: <171A84BCA8A12F72.28182@groups.io> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 MIME-Version: 1.0 Content-Language: en-GB Content-Type: multipart/alternative; boundary="_000_GV2P195MB20903EBC25F53D82F166787BFC5F9GV2P195MB2090EURP_" --_000_GV2P195MB20903EBC25F53D82F166787BFC5F9GV2P195MB2090EURP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reminder for review, thanks. From: devel@edk2.groups.io on behalf of Sheng Lean T= an via groups.io Date: Monday, 3. October 2022 at 11:22 To: devel@edk2.groups.io , sean@starlabs.systems Cc: Sean Rhodes , Zhichao Gao , Ray Ni , Jian J Wang , Liming G= ao , Dong, Guo , Guo, Gua Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option = to follow Microsoft Recommendations Hi Liming, Mind to help to take a look at these 2 patches? Sean has updated the initia= l patches per your recommendation: https://edk2.groups.io/g/devel/message/94318?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A= %3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922542 https://edk2.groups.io/g/devel/message/94320?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A= %3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922544 Previous feedback: https://edk2.groups.io/g/devel/message/92385?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A= %3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C92974182 https://edk2.groups.io/g/devel/message/92146?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A= %3ACreated%2C%2Cboot+logo+sean%2C20%2C2%2C0%2C92830014 Thanks, Sheng From: devel@edk2.groups.io on behalf of Sean Rhodes = Date: Monday, 26. September 2022 at 10:10 To: devel@edk2.groups.io Cc: Sean Rhodes , Zhichao Gao , Ray Ni , Jian J Wang , Liming G= ao Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to f= ollow Microsoft Recommendations Add an option to position the logo 38.2% from the top of the screen, which follows the recommendations from Microsoft. These can be found here: https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/boot-scre= en-components Cc: Zhichao Gao Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Sean Rhodes --- MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h b/MdeModulePkg/In= clude/Protocol/PlatformLogo.h index 08e1dc35a4..b24d7d5b79 100644 --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h @@ -29,7 +29,8 @@ typedef enum { EdkiiPlatformLogoDisplayAttributeCenterBottom, EdkiiPlatformLogoDisplayAttributeLeftBottom, EdkiiPlatformLogoDisplayAttributeCenterLeft, - EdkiiPlatformLogoDisplayAttributeCenter + EdkiiPlatformLogoDisplayAttributeCenter, + EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE; /** diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/= Library/BootLogoLib/BootLogoLib.c index 478ec2d40e..9065e5281b 100644 --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c @@ -169,7 +169,6 @@ BootLogoEnableLogo ( DestX =3D SizeOfX - Image.Width; DestY =3D 0; break; - case EdkiiPlatformLogoDisplayAttributeCenterLeft: DestX =3D 0; DestY =3D (SizeOfY - Image.Height) / 2; @@ -182,7 +181,6 @@ BootLogoEnableLogo ( DestX =3D SizeOfX - Image.Width; DestY =3D (SizeOfY - Image.Height) / 2; break; - case EdkiiPlatformLogoDisplayAttributeLeftBottom: DestX =3D 0; DestY =3D SizeOfY - Image.Height; @@ -195,7 +193,10 @@ BootLogoEnableLogo ( DestX =3D SizeOfX - Image.Width; DestY =3D SizeOfY - Image.Height; break; - + case EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended: + DestX =3D (SizeOfX - Image.Width) / 2; + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2; + break; default: ASSERT (FALSE); continue; -- 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94318): https://edk2.groups.io/g/devel/message/94318 Mute This Topic: https://groups.io/mt/93922542/6757431 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [sheng.tan@9elements.com] -=3D-=3D-=3D-=3D-=3D-=3D --_000_GV2P195MB20903EBC25F53D82F166787BFC5F9GV2P195MB2090EURP_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Remi= nder for review, thanks.

 

From: devel@edk2.groups.i= o <devel@edk2.groups.io> on behalf of Sheng Lean Tan via groups.io &l= t;sheng.tan=3D9elements.com@groups.io>
Date: Monday, 3. October 2022 at 11:22
To: devel@edk2.groups.io <devel@edk2.groups.io>, sean@starlabs= .systems <sean@starlabs.systems>
Cc: Sean Rhodes <sean@starlabs.systems>, Zhichao Gao <zhich= ao.gao@intel.com>, Ray Ni <ray.ni@intel.com>, Jian J Wang <jian= .j.wang@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>, Dong, G= uo <guo.dong@intel.com>, Guo, Gua <gua.guo@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add = option to follow Microsoft Recommendations

Hi L= iming,

Mind= to help to take a look at these 2 patches? Sean has updated the initial pa= tches per your recommendation:

https://edk2= .groups.io/g/devel/message/94318?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2= C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922542

&nbs= p;

https://edk2= .groups.io/g/devel/message/94320?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2= C%2Cboot+logo+sean%2C20%2C2%2C0%2C93922544

&nbs= p;

Prev= ious feedback:

https://edk2= .groups.io/g/devel/message/92385?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2= C%2Cboot+logo+sean%2C20%2C2%2C0%2C92974182

&nbs= p;

https://edk2= .groups.io/g/devel/message/92146?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2= C%2Cboot+logo+sean%2C20%2C2%2C0%2C92830014

&nbs= p;

Than= ks,

Shen= g

 <= /o:p>

From: devel@edk2.groups.i= o <devel@edk2.groups.io> on behalf of Sean Rhodes <sean@starlabs.s= ystems>
Date: Monday, 26. September 2022 at 10:10
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Sean Rhodes <sean@starlabs.systems>, Zhichao Gao <zhich= ao.gao@intel.com>, Ray Ni <ray.ni@intel.com>, Jian J Wang <jian= .j.wang@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add opti= on to follow Microsoft Recommendations

Add an option to position the logo 38.2% from the top of the sc= reen,
which follows the recommendations from Microsoft. These can be found
here:
https://docs.microsoft.com/en-us/windows-hardware= /drivers/bringup/boot-screen-components

Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
 MdeModulePkg/Include/Protocol/PlatformLogo.h   | 3 ++-
 MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h b/MdeModulePkg/In= clude/Protocol/PlatformLogo.h
index 08e1dc35a4..b24d7d5b79 100644
--- a/MdeModulePkg/Include/Protocol/PlatformLogo.h
+++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h
@@ -29,7 +29,8 @@ typedef enum {
   EdkiiPlatformLogoDisplayAttributeCenterBottom,

   EdkiiPlatformLogoDisplayAttributeLeftBottom,

   EdkiiPlatformLogoDisplayAttributeCenterLeft,

-  EdkiiPlatformLogoDisplayAttributeCenter

+  EdkiiPlatformLogoDisplayAttributeCenter,

+  EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended

 } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE;

 

 /**

diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c b/MdeModulePkg/= Library/BootLogoLib/BootLogoLib.c
index 478ec2d40e..9065e5281b 100644
--- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
+++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
@@ -169,7 +169,6 @@ BootLogoEnableLogo (
         DestX =3D SizeOfX - Image.= Width;

         DestY =3D 0;

         break;

-

       case EdkiiPlatformLogoDisplayAttribute= CenterLeft:

         DestX =3D 0;

         DestY =3D (SizeOfY - Image= .Height) / 2;

@@ -182,7 +181,6 @@ BootLogoEnableLogo (
         DestX =3D SizeOfX - Image.= Width;

         DestY =3D (SizeOfY - Image= .Height) / 2;

         break;

-

       case EdkiiPlatformLogoDisplayAttribute= LeftBottom:

         DestX =3D 0;

         DestY =3D SizeOfY - Image.= Height;

@@ -195,7 +193,10 @@ BootLogoEnableLogo (
         DestX =3D SizeOfX - Image.= Width;

         DestY =3D SizeOfY - Image.= Height;

         break;

-

+      case EdkiiPlatformLogoDisplayAttributeMicro= softRecommended:

+        DestX =3D (SizeOfX - Image.Widt= h) / 2;

+        DestY =3D (SizeOfY * 382) / 100= 0 - Image.Height / 2;

+        break;

       default:

         ASSERT (FALSE);

         continue;

--
2.34.1



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94318): https://edk2.groups.io/g/devel/message/94318
Mute This Topic: https://= groups.io/mt/93922542/6757431
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.= groups.io/g/devel/unsub [sheng.tan@9elements.com]
-=3D-=3D-=3D-=3D-=3D-=3D


--_000_GV2P195MB20903EBC25F53D82F166787BFC5F9GV2P195MB2090EURP_--