From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.7.70; helo=eur04-he1-obe.outbound.protection.outlook.com; envelope-from=pankaj.bansal@nxp.com; receiver=edk2-devel@lists.01.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70070.outbound.protection.outlook.com [40.107.7.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 75ED12116DFB5 for ; Sat, 13 Oct 2018 02:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5X1dlSmCOz2O61i+Z/1xz8oQHdS5LGOdS6a6sGJWluU=; b=OW/NXfuqtbxarLfZohk4Bzn7HrcDMOETeRvMPcWX5NUmFVf0eCeb/XaKXWWJE0Aiw3woZEBwkIda+5cisMftxKx++3T4v7Zzfp0GcVhZQNjirT6Ma5hAmhUPxy+e34hbXMapqh1ciKUKQl4SNBvqgx9lV9oFN/8btDrm8b99cIU= Received: from HE1PR0402MB3323.eurprd04.prod.outlook.com (10.167.125.20) by HE1PR0402MB2747.eurprd04.prod.outlook.com (10.175.35.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.21; Sat, 13 Oct 2018 09:00:37 +0000 Received: from HE1PR0402MB3323.eurprd04.prod.outlook.com ([fe80::e920:5bb3:9bdd:4e73]) by HE1PR0402MB3323.eurprd04.prod.outlook.com ([fe80::e920:5bb3:9bdd:4e73%2]) with mapi id 15.20.1207.029; Sat, 13 Oct 2018 09:00:37 +0000 From: Pankaj Bansal To: Yonghong Zhu , Liming Gao CC: "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi Thread-Topic: PACKAGES_PATH in !include path in Dsc files Thread-Index: AdRi0VkZgDJjRBnmQAu3SgG7JULGpg== Date: Sat, 13 Oct 2018 09:00:37 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=pankaj.bansal@nxp.com; x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0402MB2747; 6:QPGrQjoX3rfSI8wvebG0vBoKUeSZE4mtTtPS0qVmWPoePaUeH39AHY34Zfx9YkfX+vXN+nYbf8pcVUX8VT4LbnZgQkOJgdw34aY2z0zYhDwr2JXS+y0Whfx1PokW+Zn+q6R/uKtXY4G42bY/4VQha2VKLmNy3mdEmy1SG7RVWbMbqd+GU2eEOvGqeyvXfdcNpic2xqbiFKwMOySl4fG4GCbyPoUJsLqFIoGFqsvcGgW4A1OrgU6NwEdUZ8xM93QZJ63EMCqeUGGIlZU5Bt8KN/z6BK9VwfCI00oYweJucp7WURt3Vngfxn+rRMO5x+d/BNNWYOPhqWcuN3Y7DdIgEDGIr/+F0c8gX3gwcYQlWPY/gmh7qYyip9r6Vu9my5c8oxZEAmR2FCaniQQGPFOjXzl3mw18SNXUsHO9yZey83uXRbXPsmL/FoOvCSr7h9KFtf1LIdbS/06I0PIIO2M45A==; 5:N8o+2MRi4jNIZ3/a3TvXetduM7mu/IP7zFJDRN2qDuUGvAqwW+4+Czzmx7+6tZVqoRxAUi701Au8JxJBFd51r4W6yfjKimMRDdcK0SBicmMj6XxmEwxqWl96591k+SJtBvbnoALaPKlyJkWKVvacjmiPWVzvB34YMrtS5KNz0uw=; 7:8kNz3+Nr3UsETWZr1KwfVpQNyAd+8FuynQ4eUc3aF8v41UXGgQa/r6/wScuvaP5kxIUGbmytHFqwglvDfSSvacFuCnB4Pa/8NMCFogCkWZpS4cSbWG4MN4yt3tcHfiQhFH1VC4x2DsukemR9ky2x0Z8BI0H/rrrtLaWZNkLPL2VYIkVR9JYXZBWCZF0ROS++TgPQ9me7YTuala1KbZhzM+VvzjeFwGnQCMPoQxBzsSODsi8e/18ijdirStviACGU x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 76014f10-6e53-428b-df7b-08d630ea581b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2747; x-ms-traffictypediagnostic: HE1PR0402MB2747: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(162533806227266)(21748063052155)(28532068793085)(190501279198761)(227612066756510); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:HE1PR0402MB2747; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2747; x-forefront-prvs: 082465FB26 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(396003)(346002)(376002)(366004)(189003)(199004)(53754006)(7696005)(2900100001)(186003)(55016002)(9686003)(106356001)(5250100002)(66066001)(99286004)(97736004)(78486010)(71190400001)(71200400001)(575784001)(86362001)(105586002)(6306002)(55236004)(6506007)(14454004)(54896002)(53936002)(68736007)(102836004)(26005)(7736002)(256004)(74316002)(5024004)(14444005)(25786009)(6116002)(3846002)(790700001)(19627235002)(8676002)(81166006)(54906003)(81156014)(8936002)(316002)(9326002)(2906002)(44832011)(5660300001)(6436002)(110136005)(33656002)(4326008)(486006)(476003)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2747; H:HE1PR0402MB3323.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: qVMcIis/ThxBryutiilX0Anmy7ImiqXMy/XIbmT6wM22AdWMFBsO1fC8PeZ76jKBuoBv2vvHooCkz1bMKjZKRCzRy/wUzuO0TK/AxCtf6lT6UVF4V1NNIMSi5S3Vk95/JIilKBpZNWSeP5uVQnKKoOa9vY7FkMQh2FpLI1P2ED74pO7m0HlZtR4e+9VFp/bnA0Z25PSKJ30xKV/x2BPkGZ6+7o30wTS3O1RWSLqx3J/vcLmQw16W7P3RcfOIIgXZqQMDKq1/p6+jhm/Jj5chDAQ2G8ef5SD0DMvE7YA6oIpZucp2MhyJEj8wPJi3PSU0KJJmDNN4f8jKFSev5wyT27mpt94wIxYBcsQ3YWIqmpI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76014f10-6e53-428b-df7b-08d630ea581b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2018 09:00:37.6765 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2747 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: PACKAGES_PATH in !include path in Dsc files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 09:00:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello All, I am trying to add this functionality that we can specify PACKAGES_PATH in = !include path in Dsc files just like we can specify WORKSPACE. I did below changes for it: --- a/BaseTools/Source/Python/Workspace/MetaFileParser.py +++ b/BaseTools/Source/Python/Workspace/MetaFileParser.py @@ -1530,6 +1530,7 @@ class DscParser(MetaFileParser): # Allow using system environment variables in path after !inc= lude # __IncludeMacros['WORKSPACE'] =3D GlobalData.gGlobalDefines['WO= RKSPACE'] + __IncludeMacros['PACKAGES_PATH'] =3D GlobalData.gGlobalDefines= ['PACKAGES_PATH']^M if "ECP_SOURCE" in GlobalData.gGlobalDefines: __IncludeMacros['ECP_SOURCE'] =3D GlobalData.gGlobalDefine= s['ECP_SOURCE'] # diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index d74082fc26..61dce3a856 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -197,6 +197,7 @@ def CheckEnvVariable(): GlobalData.gEcpSource =3D EcpSourceDir GlobalData.gGlobalDefines["WORKSPACE"] =3D WorkspaceDir + GlobalData.gGlobalDefines["PACKAGES_PATH"] =3D PackagesPath^M GlobalData.gGlobalDefines["EFI_SOURCE"] =3D EfiSourceDir GlobalData.gGlobalDefines["EDK_SOURCE"] =3D EdkSourceDir GlobalData.gGlobalDefines["ECP_SOURCE"] =3D EcpSourceDir With these changes the compilation starts OK, but I get this error later on= : GenFds.py... : error C0DE: Tools code failure Please send email to edk2-devel@lists.01.org for help, attaching fo= llowing call stack trace! Traceback (most recent call last): File "/home/nxa34148/Desktop/uefi/BaseTools/Source/Python/GenFds/GenFds.p= y", line 246, in main TargetArchList =3D set(BuildWorkSpace.BuildObject[GenFdsGlobalVariable.= ActivePlatform, TAB_COMMON, Options.BuildTarget, Options.ToolChain].SupArch= List) & set(ArchList) File "/home/nxa34148/Desktop/uefi/BaseTools/Source/Python/Workspace/Works= paceDatabase.py", line 132, in __getitem__ Toolchain File "/home/nxa34148/Desktop/uefi/BaseTools/Source/Python/Workspace/DscBu= ildData.py", line 221, in __init__ self._HandleOverridePath() File "/home/nxa34148/Desktop/uefi/BaseTools/Source/Python/Workspace/DscBu= ildData.py", line 282, in _HandleOverridePath RecordList =3D self._RawData[MODEL_META_DATA_COMPONENT, self._Arch] File "/home/nxa34148/Desktop/uefi/BaseTools/Source/Python/Workspace/MetaF= ileParser.py", line 257, in __getitem__ self._PostProcess() File "/home/nxa34148/Desktop/uefi/BaseTools/Source/Python/Workspace/MetaF= ileParser.py", line 1358, in _PostProcess Processer[self._ItemType]() File "/home/nxa34148/Desktop/uefi/BaseTools/Source/Python/Workspace/MetaF= ileParser.py", line 1533, in __ProcessDirective __IncludeMacros['PACKAGES_PATH'] =3D GlobalData.gGlobalDefines['PACKAGE= S_PATH'] KeyError: 'PACKAGES_PATH' build.py... : error 7000: Failed to execute command GenFds -f /home/nxa34148/Desktop/uefi/edk2-platforms/Platform/NXP/L= S1043aRdbPkg/LS1043aRdbPkg.fdf --conf=3D/home/nxa34148/Desktop/uefi/Conf -o= /home/nxa34148/Desktop/uefi/Build/LS1043aRdbPkg/RELEASE_GCC49 -t GCC49 -b = RELEASE -p /home/nxa34148/Desktop/uefi/edk2-platforms/Platform/NXP/LS1043aR= dbPkg/LS1043aRdbPkg.dsc -a AARCH64 -D "EFI_SOURCE=3D/home/nxa34148/Desktop/= uefi/EdkCompatibilityPkg" -D "EDK_SOURCE=3D/home/nxa34148/Desktop/uefi/EdkC= ompatibilityPkg" -D "TOOL_CHAIN_TAG=3DGCC49" -D "TOOLCHAIN=3DGCC49" -D "FAM= ILY=3DGCC" -D "PACKAGES_PATH=3D/home/nxa34148/Desktop/uefi/edk2-platforms" = -D "EDK_TOOLS_PATH=3D/home/nxa34148/Desktop/uefi/BaseTools" -D "WORKSPACE= =3D/home/nxa34148/Desktop/uefi" -D "ARCH=3DAARCH64" -D "ECP_SOURCE=3D/home/= nxa34148/Desktop/uefi/EdkCompatibilityPkg" -D "TARGET=3DRELEASE" [/home/nxa= 34148/Desktop/uefi] - Failed - I am not able to understand the cause of this error. Can you please help? Regards, Pankaj Bansal