public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Pankaj Bansal <pankaj.bansal@nxp.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Udit Kumar <udit.kumar@nxp.com>, Varun Sethi <V.Sethi@nxp.com>
Subject: Re: PACKAGES_PATH in !include path in Dsc files
Date: Tue, 16 Oct 2018 06:00:00 +0000	[thread overview]
Message-ID: <HE1PR0402MB3323F78C0B6D12210132E68DF1FE0@HE1PR0402MB3323.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E33AAA3@SHSMSX104.ccr.corp.intel.com>

> -----Original Message-----
> From: Gao, Liming [mailto:liming.gao@intel.com]
> Sent: Tuesday, October 16, 2018 10:58 AM
> To: Pankaj Bansal <pankaj.bansal@nxp.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>
> Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>;
> edk2-devel@lists.01.org; Udit Kumar <udit.kumar@nxp.com>; Varun Sethi
> <V.Sethi@nxp.com>
> Subject: RE: PACKAGES_PATH in !include path in Dsc files
> 
> Hi,
>   You can directly include it. BaseTools will search it from WORKSPACE and
> PACKAGES_PATH. So, you only need to set edk2-platforms directory into
> PACKAGES_PATH env.
> 
> !include Silicon/NXP/<Silicon Name>.dsc


Thanks You Liming Gao.
It worked for me.

> 
> Thanks
> Liming
> >-----Original Message-----
> >From: Pankaj Bansal [mailto:pankaj.bansal@nxp.com]
> >Sent: Tuesday, October 16, 2018 1:24 PM
> >To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong
> ><yonghong.zhu@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>;
> >Kinney, Michael D <michael.d.kinney@intel.com>;
> >edk2-devel@lists.01.org; Udit Kumar <udit.kumar@nxp.com>; Varun Sethi
> ><V.Sethi@nxp.com>
> >Subject: RE: PACKAGES_PATH in !include path in Dsc files
> >
> >
> >
> >> -----Original Message-----
> >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> >> Sent: Tuesday, October 16, 2018 8:41 AM
> >> To: Pankaj Bansal <pankaj.bansal@nxp.com>
> >> Cc: Gao, Liming <liming.gao@intel.com>; Zhu, Yonghong
> >> <yonghong.zhu@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>;
> >Michael
> >> D Kinney <michael.d.kinney@intel.com>; edk2-devel@lists.01.org; Udit
> >Kumar
> >> <udit.kumar@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
> >> Subject: Re: PACKAGES_PATH in !include path in Dsc files
> >>
> >> On 16 October 2018 at 10:40, Pankaj Bansal <pankaj.bansal@nxp.com>
> >wrote:
> >> > +edk2-platforms maintainers in To list
> >> >
> >> >
> >> >
> >> > Thank you Liming for replying.
> >> >
> >> >
> >> >
> >> > Our entire code is in edk2-platforms
> >> >
> >(https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> >> > thub.com%2Ftianocore%2Fedk2-
> >>
> >platforms&amp;data=02%7C01%7Cpankaj.bansal%40nxp.com%7C552da3f22b
> >5
> >>
> 84b7fac6008d63315ec8b%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> >>
> %7C636752566592695047&amp;sdata=JJWbAcZkj%2FtFaZC0bWONPb7ulCcj1
> >L2
> >> 4VKwCDGDx9OE%3D&amp;reserved=0) which is denoted by
> >PACKAGES_PATH.
> >> >
> >> > The PACKAGES_PATH directory can be anywhere in WORKSPACE
> >depending on
> >> > the sync directory defined by user.
> >> >
> >> > i.e. it can be $(WORKSPACE)/edk2-platforms or $(WORKSPACE)/<any
> >> > directory name that user can define during git sync>
> >> >
> >> > As our dsc files are relative to PACKAGES_PATH, I want to specify
> >> > their path in dsc file like this:
> >> >
> >> >
> >> >
> >> > !include $(PACKAGES_PATH)/Silicon/NXP/<Silicon Name>.dsc
> >> >
> >> >
> >> >
> >> > Using $(WORKSPACE), I cannot specify above path, as it can be at
> >> > place other than $(WORKSPACE)/edk2-platforms
> >> >
> >>
> >> But why do you need to !include things in the first place?
> >>
> >> Can you explain how you are trying to organize the files, and which
> >> file
> >includes
> >> which?
> >
> >I am trying to keep Silicon (SOC) specific dsc file in
> >Silicon/NXP/<Chassis
> >Name>/<Silicon Name>
> >This silicon can be used in multiple Boards (Platforms).
> >All these Platforms are present in Platform/NXP/<Platform Name> fd/fv
> >binaries would be created for each platform.
> >The chassis dsc file has description of components/PCDs that are
> >specific to chassis to which the silicon belongs. It would be same for
> >all silicons that belong to same chassis.
> >The Silicon dsc file has description of components/PCDs that are
> >specific to silicon and would be same for all platforms that use this
> >silicon. It would include chassis dsc file The Platform dsc file would
> >include the silicon dsc file.
> >
> >___________________________________
> >| Platform (in Platform/NXP)                        |
> >|    _____________________________      |
> >|   | Silicon (in Silicon/NXP/<Chassis>) |     |
> >|   |   _______________________        |     |
> >|   |  | Chassis  (in Silicon/NXP)     |       |    |
> >|   |  |______________________|       |     |
> >|   |____________________________|     |
> >|_________________________________|
> >
> >Regards,
> >Pankaj Bansal

      reply	other threads:[~2018-10-16  6:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13  9:00 PACKAGES_PATH in !include path in Dsc files Pankaj Bansal
2018-10-16  1:35 ` Gao, Liming
2018-10-16  2:40   ` Pankaj Bansal
2018-10-16  3:11     ` Ard Biesheuvel
2018-10-16  5:23       ` Pankaj Bansal
2018-10-16  5:28         ` Gao, Liming
2018-10-16  6:00           ` Pankaj Bansal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR0402MB3323F78C0B6D12210132E68DF1FE0@HE1PR0402MB3323.eurprd04.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox