Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

[edhaya.chandran@arm.com]

Hello Irene,

   Sure. Will review and send my comments soon.

With Warm Regards,
Edhay


-----Original Message-----
From: Irene Park <ipark@nvidia.com>
Sent: 03 June 2020 13:00
To: devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: eric.jin@intel.com
Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

Thank you Samer for this help.

Hi Edhaya,
Would you please review this simple change ?
SCT build fails with the latest EDK2 due to lack of this change.
Thank you,
Irene

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-Haj-Mahmoud
Sent: Monday, June 1, 2020 4:51 PM
To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; eric.jin@intel.com
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

External email: Use caution opening links or attachments


+Edhaya

Irene, Edhaya is an SCT maintainer now, so please include him on future SCT patches.

Thanks,
--Samer

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene
> Park via groups.io
> Sent: Monday, June 1, 2020 4:33 PM
> To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>;
> eric.jin@intel.com
> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove
> gEfiFormBrowserExProtocolGuid
>
> Hi Eric,
> Would you please help review this change?
> SCT build fails with the latest EDK2 due to lack of this change.
> Thanks,
> Irene
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene
> Park
> Sent: Thursday, May 28, 2020 4:07 PM
> To: devel@edk2.groups.io
> Cc: eric.jin@intel.com
> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove
> gEfiFormBrowserExProtocolGuid
>
> External email: Use caution opening links or attachments
>
>
> -----Original Message-----
> From: Irene Park <ipark@nvidia.com>
> Sent: Thursday, May 28, 2020 3:19 PM
> To: devel@edk2.groups.io
> Cc: Irene Park <ipark@nvidia.com>
> Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid
>
> From: Irene Park <ipark@nvidia.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
>
> Replace the gEfiFormBrowserExProtocolGuid with
> gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
>
> Signed-off-by: Irene Park <ipark@nvidia.com>
> ---
>  .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c               | 4 ++--
>  .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf          | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes
> t/Dependency/SampleDriver/DriverSample.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes
> t/Dependency/SampleDriver/DriverSample.c
> index d495afd..fe973a3 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes
> t/Dependency/SampleDriver/DriverSample.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl
> +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c
> @@ -1893,7 +1893,7 @@ DriverSampleInit (
>    EFI_STRING                      NameRequestHdr;
>    MY_EFI_VARSTORE_DATA            *VarStoreConfig;
>    EFI_INPUT_KEY                   HotKey;
> -  EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx;
> +  EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx;
>  #if 1
>      EFI_STRING                      Progress;
>    EFI_STRING                      Results;
> @@ -2190,7 +2190,7 @@ DriverSampleInit (
>    //
>    // Example of how to use BrowserEx protocol to register HotKey.
>    //
> -  Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL,
> (VOID **) &FormBrowserEx);
> +  Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid,
> + NULL, (VOID **) &FormBrowserEx);
>    if (!EFI_ERROR (Status)) {
>      //
>      // First unregister the default hot key F9 and F10.
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes
> t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes
> t/Dependency/SampleDriver/DriverSampleDxe.inf
> index cfa049e..75cb6fb 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes
> t/Dependency/SampleDriver/DriverSampleDxe.inf
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl
> +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf
> @@ -99,7 +99,7 @@
>    gEfiFormBrowser2ProtocolGuid                  ## CONSUMES
>    gEfiHiiDatabaseProtocolGuid                   ## CONSUMES
>    gEfiSimpleTextInputExProtocolGuid             ## SOMETIMES_CONSUMES
> -  gEfiFormBrowserExProtocolGuid                 ## CONSUMES
> +  gEdkiiFormBrowserExProtocolGuid               ## CONSUMES
>    gBlackBoxEfiConfigKeywordHandlerProtocolGuid  ## CONSUMES
>
>  [Depex]
> --
> 2.7.4
>
>
>
>
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.



IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.