From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (EUR03-AM5-obe.outbound.protection.outlook.com [40.107.3.50]) by mx.groups.io with SMTP id smtpd.web12.8884.1591170827016170225 for ; Wed, 03 Jun 2020 00:53:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Io+bfXm7; spf=pass (domain: arm.com, ip: 40.107.3.50, mailfrom: edhaya.chandran@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oiaKJJwURBWLALlkj4KOzF2HFkCAqwMPDFiN+B+cpbs=; b=Io+bfXm7c69EN+bcfsBXgYtzLYLT9CATtsO3sY7sicyvsMLZt1wDMiv7lzL+nBe//CNO3k5875o0awDEuJZpmGClmBPpU73V4e52EfOinc9y+0DSebf4SrwQnsOJLMCeJCfT8OS+LQplTfFbOTg8WINMoiicocY03LtRbXmJ+rQ= Received: from AM5PR04CA0011.eurprd04.prod.outlook.com (2603:10a6:206:1::24) by VI1PR0801MB1726.eurprd08.prod.outlook.com (2603:10a6:800:52::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Wed, 3 Jun 2020 07:53:44 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::79) by AM5PR04CA0011.outlook.office365.com (2603:10a6:206:1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18 via Frontend Transport; Wed, 3 Jun 2020 07:53:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18 via Frontend Transport; Wed, 3 Jun 2020 07:53:44 +0000 Received: ("Tessian outbound cff7dd4de28a:v57"); Wed, 03 Jun 2020 07:53:44 +0000 X-CR-MTA-TID: 64aa7808 Received: from 1b96ce147866.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5043EE6E-7829-490C-B322-E08843B36A3B.1; Wed, 03 Jun 2020 07:53:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1b96ce147866.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Jun 2020 07:53:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYEPUplVLdLHgcQIzhAxlPVE2spXmyasmKwlZIUDXgrcwFHqa0yJjwdJQAdQSCG6rdJcObm5b9MBbwx6MNhZqWB2o+XyLl5aKckN3+jSt39r8AQzjxvvRXPTok0B1fOz9lLe6fKE+Fnim8ORHVC2DP93yVYMC8rPn/46ekGGEqBOFJ8k71rts+NnCNeJsMtmHyViuUFHGvyEwqUQfxzz+0o2nug6K3NnvaCKi8l3m01TsllXQuFKUB9DLDFxoI2HzVvOQKLYaOjMKbUuqndf3RstoWJebkQAYABFYxDWFjdCrnHunj8kVN7aEgTfa55RtfGWG2+QweHaQqLhb5Y5zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oiaKJJwURBWLALlkj4KOzF2HFkCAqwMPDFiN+B+cpbs=; b=PapyD1vcCpNkAclT8QQ8CxSYc0wcO/KMwZ1E8DknnV3oNCS6LsIt/lnzoXL9kxJA39pIzQOy4sJr21902rGPuJCLET+cYQvMN5nGM2i52JbHWEYYkGFecs72MxJQfU3MGDjpu9tTf1QU62E/B420jvXCwJ1ZEHhvS+Bszs/IiHVUkF31mY7WdjsMWChqH48cB3F7sl+iKUoQzS5EzJE4rj/wbElR9JnV/CSJFEUgwl9dUfzLzxGIpVsQ2Cau6ZMJlSeZd/KyG/PXePb3kot8dBJuG/VNMucK+oviNQyw7zoqc8cb9lg8xSt9e/+y1QutvYf6JNwFYSca7KFts5B2Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oiaKJJwURBWLALlkj4KOzF2HFkCAqwMPDFiN+B+cpbs=; b=Io+bfXm7c69EN+bcfsBXgYtzLYLT9CATtsO3sY7sicyvsMLZt1wDMiv7lzL+nBe//CNO3k5875o0awDEuJZpmGClmBPpU73V4e52EfOinc9y+0DSebf4SrwQnsOJLMCeJCfT8OS+LQplTfFbOTg8WINMoiicocY03LtRbXmJ+rQ= Received: from HE1PR0801MB1691.eurprd08.prod.outlook.com (2603:10a6:3:7b::13) by HE1PR0801MB1820.eurprd08.prod.outlook.com (2603:10a6:3:85::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Wed, 3 Jun 2020 07:53:37 +0000 Received: from HE1PR0801MB1691.eurprd08.prod.outlook.com ([fe80::30d9:af2f:185b:fd8]) by HE1PR0801MB1691.eurprd08.prod.outlook.com ([fe80::30d9:af2f:185b:fd8%3]) with mapi id 15.20.3045.024; Wed, 3 Jun 2020 07:53:36 +0000 From: edhaya.chandran@arm.com To: Irene Park , "devel@edk2.groups.io" , Samer El-Haj-Mahmoud CC: "eric.jin@intel.com" Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Topic: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thread-Index: AQHWNSYOx7AxJtKzI0afITc1Z4hmdqi97gqQgAZQmVCAAAPggIACRNwAgAAGQ2A= Date: Wed, 3 Jun 2020 07:53:36 +0000 Message-ID: References: <16134CAE37D4DAC5.10634@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Enabled=True; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SiteId=43083d15-7273-40c1-b7db-39efd9ccc17a; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Owner=ipark@nvidia.com; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_SetDate=2020-05-28T20:06:39.6568840Z; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Name=Unrestricted; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Application=Microsoft Azure Information Protection; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_ActionId=e5f65812-950b-44cd-a6f2-718925f50870; MSIP_Label_6b558183-044c-4105-8d9c-cea02a2a3d86_Extended_MSFT_Method=Automatic x-ts-tracking-id: 0fa8ef30-98f5-487a-be25-d29786227714.0 x-checkrecipientchecked: true Authentication-Results-Original: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.105.53] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6486320b-ef3c-407f-659e-08d807933d5e x-ms-traffictypediagnostic: HE1PR0801MB1820:|VI1PR0801MB1726: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 04238CD941 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Vb7W4Mnz1cYCRLz/l1LgWfo3lIZX9s3BSxsn/0ghkXqCzW60Dd02pFyiHm25KP3w8pyfefx5LCTyJVCqDjf/nrtJ9W3hhp8R9zpMMVVMrUa++JUSYOiQHZNJ1v/v/b1mVEH4txrxjmp/hEQKsN3ul0bZjkbWgHkCYdEsxl9WyUgRkVh+pchqLMDfpkazWa+OQAEB9EEtNRFUE3gLBTLr5Dbd/oPKTMM6IfcErCZVby2TnHLSOTJE08LimIj4BrTLJqlRO0q/VODZ2qYOEaKTh9ACvLj7+77vg5FVT6eEITGfLBCVqouSvTKGv8ftavKA5W+aicw6Q48abF6PR6dPq/achfkSEAFKY9nHdlS+Ke3bwHWzmhGkdfg7aDKSDWwZj9QO0Pz5E8wZFp5oFuaZ3Ebya/5iBcKMwqmIX+mPB1NzTEoFkBDq5M5NXY95dfTyDVo4ItoAm87K8Bzl+WFxx9V/hqXYrnFO4Gf2ocGuT3A= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0801MB1691.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(366004)(396003)(39850400004)(346002)(136003)(376002)(6636002)(5660300002)(66476007)(8936002)(7696005)(19627235002)(76116006)(66556008)(66946007)(6506007)(186003)(86362001)(26005)(53546011)(66446008)(33656002)(52536014)(64756008)(8676002)(83380400001)(4326008)(966005)(66574014)(71200400001)(2906002)(9686003)(55016002)(478600001)(110136005)(316002)(145543001)(145603002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: 6PDc9/fI/Ch3LmxR2TbnNRx9u/s1Y+kqlT6E9QO46feH1P5xBoTzwWlmvOGQDsq0kW389YU84FLXeuH3GnYIW4t/lbo+PxbaPxGq1fhzCaF7w96QiLxV9Iqc8PCGf2ZCeOMaaUeCYUONwrYp3bCtu01UL+XmbNtgGA9Kl1QXvA9huajIeC3V/KqIzsRvZzgpB0X70+yZ2N5pkUX21XZfEohXH6GXyXJRB120KkwawpJdvyjPSGdEnldfZ9qJYKDnX++2uvl8gt6/vhf7OXhrpRGwZNmYwgwDXNblCbpQfHfQMa+XJHF12nU63hGgDGu87GLi7xnx5SI7Ab2P/7oTi9QG90P2HAwcvwQMEYFyOGbpBl/DD2JRaWRCDTVV0agWq6rLCx5fD/qiTBueSU/GMYXmJsgl9GELvbhoso0q8MDydQrzRvcPnsJLTgdakG07MZVSI00W4m6khGgcba9BwiQ5a4p2mYXTuIgaHgoYwkSRDlwRt3bp3cKcoxGSZVGz MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1820 Original-Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; Return-Path: Edhaya.Chandran@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(6029001)(4636009)(396003)(376002)(39850400004)(136003)(346002)(46966005)(8936002)(5660300002)(33656002)(47076004)(86362001)(83380400001)(66574014)(8676002)(336012)(82740400003)(316002)(110136005)(36906005)(4326008)(53546011)(6506007)(107886003)(7696005)(478600001)(52536014)(966005)(70586007)(356005)(6636002)(82310400002)(81166007)(19627235002)(2906002)(186003)(26005)(55016002)(9686003)(70206006)(145543001)(145603002);DIR:OUT;SFP:1101; X-MS-Office365-Filtering-Correlation-Id-Prvs: 16069ad1-eb95-4cc2-db59-08d8079338e8 X-Forefront-PRVS: 04238CD941 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fMgfCHYkOALV44tQHta2VlLEr7OnJWB1Hgn5h9uqIKr4DfSDbarpZ3PwVXrx9PXSDX6KAibxBwTz90xXHndSlrvWR2/AMS64rM0DPym0WI1d2TNabu2ClMmublEDTwF9Wm6qPlXkbpFxTUV/7F+ZvjujKH44wo0D4E4IDHckQbcBUXkhjDHLS84umTR2Q6V2fSGR2laccQklE323u2JFTMsf9OV9XCJTjnz7ykKI7EHFNE/mBAB5egDQBn3Y1AwptPW+3VdZdLljofTdIF6F2saEmTflkqBKI2VEQNLCY5ykU2nStsR6cL49tnpxvFdRbqHMFvU8M+4zjDW3JL3QLG2zlJzU7PnXx191l0d8Z4yx1R6H4XHMSAl6Pdgv4HwleerGLxZER+JYIUqZPj50fMe7Kb79QBXCk/XT0OlOK52QISYOeTLYt6BahjcRFl4NwfJCStBfU+oEf8X8K0gAGZOl6GYDQGf04uwHtZwCvgnY///CX8h5sRmFo81r/r5I6r/ka3RojyrThPsHRdyZoQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2020 07:53:44.3439 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6486320b-ef3c-407f-659e-08d807933d5e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1726 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Irene, Sure. Will review and send my comments soon. With Warm Regards, Edhay -----Original Message----- From: Irene Park Sent: 03 June 2020 13:00 To: devel@edk2.groups.io; Samer El-Haj-Mahmoud ; G Edhaya Chandran Cc: eric.jin@intel.com Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserE= xProtocolGuid Thank you Samer for this help. Hi Edhaya, Would you please review this simple change ? SCT build fails with the latest EDK2 due to lack of this change. Thank you, Irene -----Original Message----- From: devel@edk2.groups.io On Behalf Of Samer El-Ha= j-Mahmoud Sent: Monday, June 1, 2020 4:51 PM To: devel@edk2.groups.io; Irene Park ; eric.jin@intel.co= m Cc: G Edhaya Chandran Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserE= xProtocolGuid External email: Use caution opening links or attachments +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SC= T patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park ; > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Irene > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2145 > > Replace the gEfiFormBrowserExProtocolGuid with > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c |= 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf |= 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status =3D gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, > (VOID **) &FormBrowserEx); > + Status =3D gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, > + NULL, (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.