* [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid @ 2020-05-28 19:19 Name 2020-05-28 20:06 ` ipark ` (2 more replies) 0 siblings, 3 replies; 13+ messages in thread From: Name @ 2020-05-28 19:19 UTC (permalink / raw) To: devel; +Cc: Irene Park From: Irene Park <ipark@nvidia.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 Replace the gEfiFormBrowserExProtocolGuid with gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. Signed-off-by: Irene Park <ipark@nvidia.com> --- .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c index d495afd..fe973a3 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c @@ -1893,7 +1893,7 @@ DriverSampleInit ( EFI_STRING NameRequestHdr; MY_EFI_VARSTORE_DATA *VarStoreConfig; EFI_INPUT_KEY HotKey; - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; #if 1 EFI_STRING Progress; EFI_STRING Results; @@ -2190,7 +2190,7 @@ DriverSampleInit ( // // Example of how to use BrowserEx protocol to register HotKey. // - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, (VOID **) &FormBrowserEx); + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NULL, (VOID **) &FormBrowserEx); if (!EFI_ERROR (Status)) { // // First unregister the default hot key F9 and F10. diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf index cfa049e..75cb6fb 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf @@ -99,7 +99,7 @@ gEfiFormBrowser2ProtocolGuid ## CONSUMES gEfiHiiDatabaseProtocolGuid ## CONSUMES gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES - gEfiFormBrowserExProtocolGuid ## CONSUMES + gEdkiiFormBrowserExProtocolGuid ## CONSUMES gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES [Depex] -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-05-28 19:19 [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Name @ 2020-05-28 20:06 ` ipark [not found] ` <16134CAE37D4DAC5.10634@groups.io> 2020-06-05 8:11 ` G Edhaya Chandran 2 siblings, 0 replies; 13+ messages in thread From: ipark @ 2020-05-28 20:06 UTC (permalink / raw) To: devel@edk2.groups.io; +Cc: eric.jin@intel.com -----Original Message----- From: Irene Park <ipark@nvidia.com> Sent: Thursday, May 28, 2020 3:19 PM To: devel@edk2.groups.io Cc: Irene Park <ipark@nvidia.com> Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid From: Irene Park <ipark@nvidia.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 Replace the gEfiFormBrowserExProtocolGuid with gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. Signed-off-by: Irene Park <ipark@nvidia.com> --- .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c index d495afd..fe973a3 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c @@ -1893,7 +1893,7 @@ DriverSampleInit ( EFI_STRING NameRequestHdr; MY_EFI_VARSTORE_DATA *VarStoreConfig; EFI_INPUT_KEY HotKey; - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; #if 1 EFI_STRING Progress; EFI_STRING Results; @@ -2190,7 +2190,7 @@ DriverSampleInit ( // // Example of how to use BrowserEx protocol to register HotKey. // - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, (VOID **) &FormBrowserEx); + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NULL, + (VOID **) &FormBrowserEx); if (!EFI_ERROR (Status)) { // // First unregister the default hot key F9 and F10. diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf index cfa049e..75cb6fb 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf @@ -99,7 +99,7 @@ gEfiFormBrowser2ProtocolGuid ## CONSUMES gEfiHiiDatabaseProtocolGuid ## CONSUMES gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES - gEfiFormBrowserExProtocolGuid ## CONSUMES + gEdkiiFormBrowserExProtocolGuid ## CONSUMES gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES [Depex] -- 2.7.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <16134CAE37D4DAC5.10634@groups.io>]
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid [not found] ` <16134CAE37D4DAC5.10634@groups.io> @ 2020-06-01 20:33 ` Irene Park 2020-06-01 20:51 ` Samer El-Haj-Mahmoud 0 siblings, 1 reply; 13+ messages in thread From: Irene Park @ 2020-06-01 20:33 UTC (permalink / raw) To: devel@edk2.groups.io, Irene Park, eric.jin@intel.com Hi Eric, Would you please help review this change? SCT build fails with the latest EDK2 due to lack of this change. Thanks, Irene -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene Park Sent: Thursday, May 28, 2020 4:07 PM To: devel@edk2.groups.io Cc: eric.jin@intel.com Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments -----Original Message----- From: Irene Park <ipark@nvidia.com> Sent: Thursday, May 28, 2020 3:19 PM To: devel@edk2.groups.io Cc: Irene Park <ipark@nvidia.com> Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid From: Irene Park <ipark@nvidia.com> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 Replace the gEfiFormBrowserExProtocolGuid with gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. Signed-off-by: Irene Park <ipark@nvidia.com> --- .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c index d495afd..fe973a3 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSample.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c @@ -1893,7 +1893,7 @@ DriverSampleInit ( EFI_STRING NameRequestHdr; MY_EFI_VARSTORE_DATA *VarStoreConfig; EFI_INPUT_KEY HotKey; - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; #if 1 EFI_STRING Progress; EFI_STRING Results; @@ -2190,7 +2190,7 @@ DriverSampleInit ( // // Example of how to use BrowserEx protocol to register HotKey. // - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, (VOID **) &FormBrowserEx); + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NULL, + (VOID **) &FormBrowserEx); if (!EFI_ERROR (Status)) { // // First unregister the default hot key F9 and F10. diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf index cfa049e..75cb6fb 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf @@ -99,7 +99,7 @@ gEfiFormBrowser2ProtocolGuid ## CONSUMES gEfiHiiDatabaseProtocolGuid ## CONSUMES gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES - gEfiFormBrowserExProtocolGuid ## CONSUMES + gEdkiiFormBrowserExProtocolGuid ## CONSUMES gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES [Depex] -- 2.7.4 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-06-01 20:33 ` [edk2-devel] " Irene Park @ 2020-06-01 20:51 ` Samer El-Haj-Mahmoud 2020-06-03 7:30 ` Irene Park 0 siblings, 1 reply; 13+ messages in thread From: Samer El-Haj-Mahmoud @ 2020-06-01 20:51 UTC (permalink / raw) To: devel@edk2.groups.io, ipark@nvidia.com, eric.jin@intel.com Cc: G Edhaya Chandran +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SCT patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park <ipark@nvidia.com> > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park <ipark@nvidia.com> > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park <ipark@nvidia.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 > > Replace the gEfiFormBrowserExProtocolGuid with > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park <ipark@nvidia.com> > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, > (VOID **) &FormBrowserEx); > + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, NULL, > + (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-06-01 20:51 ` Samer El-Haj-Mahmoud @ 2020-06-03 7:30 ` Irene Park 2020-06-03 7:53 ` edhaya.chandran 0 siblings, 1 reply; 13+ messages in thread From: Irene Park @ 2020-06-03 7:30 UTC (permalink / raw) To: devel@edk2.groups.io, samer.el-haj-mahmoud@arm.com, G Edhaya Chandran Cc: eric.jin@intel.com Thank you Samer for this help. Hi Edhaya, Would you please review this simple change ? SCT build fails with the latest EDK2 due to lack of this change. Thank you, Irene -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-Haj-Mahmoud Sent: Monday, June 1, 2020 4:51 PM To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; eric.jin@intel.com Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SCT patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park <ipark@nvidia.com> > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park <ipark@nvidia.com> > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park <ipark@nvidia.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 > > Replace the gEfiFormBrowserExProtocolGuid with > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park <ipark@nvidia.com> > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, > (VOID **) &FormBrowserEx); > + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, > + NULL, (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-06-03 7:30 ` Irene Park @ 2020-06-03 7:53 ` edhaya.chandran 2020-06-05 7:30 ` Irene Park 0 siblings, 1 reply; 13+ messages in thread From: edhaya.chandran @ 2020-06-03 7:53 UTC (permalink / raw) To: Irene Park, devel@edk2.groups.io, Samer El-Haj-Mahmoud; +Cc: eric.jin@intel.com Hello Irene, Sure. Will review and send my comments soon. With Warm Regards, Edhay -----Original Message----- From: Irene Park <ipark@nvidia.com> Sent: 03 June 2020 13:00 To: devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya Chandran <Edhaya.Chandran@arm.com> Cc: eric.jin@intel.com Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thank you Samer for this help. Hi Edhaya, Would you please review this simple change ? SCT build fails with the latest EDK2 due to lack of this change. Thank you, Irene -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-Haj-Mahmoud Sent: Monday, June 1, 2020 4:51 PM To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; eric.jin@intel.com Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SCT patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park <ipark@nvidia.com> > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park <ipark@nvidia.com> > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park <ipark@nvidia.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 > > Replace the gEfiFormBrowserExProtocolGuid with > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park <ipark@nvidia.com> > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, > (VOID **) &FormBrowserEx); > + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, > + NULL, (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-06-03 7:53 ` edhaya.chandran @ 2020-06-05 7:30 ` Irene Park 0 siblings, 0 replies; 13+ messages in thread From: Irene Park @ 2020-06-05 7:30 UTC (permalink / raw) To: G Edhaya Chandran, devel@edk2.groups.io, Samer El-Haj-Mahmoud Cc: eric.jin@intel.com Hello Edhaya, Would you please kindly review this change? Thank you, Irene -----Original Message----- From: G Edhaya Chandran <Edhaya.Chandran@arm.com> Sent: Wednesday, June 3, 2020 3:54 AM To: Irene Park <ipark@nvidia.com>; devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com> Cc: eric.jin@intel.com Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Hello Irene, Sure. Will review and send my comments soon. With Warm Regards, Edhay -----Original Message----- From: Irene Park <ipark@nvidia.com> Sent: 03 June 2020 13:00 To: devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; G Edhaya Chandran <Edhaya.Chandran@arm.com> Cc: eric.jin@intel.com Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Thank you Samer for this help. Hi Edhaya, Would you please review this simple change ? SCT build fails with the latest EDK2 due to lack of this change. Thank you, Irene -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Samer El-Haj-Mahmoud Sent: Monday, June 1, 2020 4:51 PM To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; eric.jin@intel.com Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments +Edhaya Irene, Edhaya is an SCT maintainer now, so please include him on future SCT patches. Thanks, --Samer > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park via groups.io > Sent: Monday, June 1, 2020 4:33 PM > To: devel@edk2.groups.io; Irene Park <ipark@nvidia.com>; > eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > Hi Eric, > Would you please help review this change? > SCT build fails with the latest EDK2 due to lack of this change. > Thanks, > Irene > > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Irene > Park > Sent: Thursday, May 28, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: eric.jin@intel.com > Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove > gEfiFormBrowserExProtocolGuid > > External email: Use caution opening links or attachments > > > -----Original Message----- > From: Irene Park <ipark@nvidia.com> > Sent: Thursday, May 28, 2020 3:19 PM > To: devel@edk2.groups.io > Cc: Irene Park <ipark@nvidia.com> > Subject: [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid > > From: Irene Park <ipark@nvidia.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 > > Replace the gEfiFormBrowserExProtocolGuid with > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration. > > Signed-off-by: Irene Park <ipark@nvidia.com> > --- > .../BlackBoxTest/Dependency/SampleDriver/DriverSample.c | 4 ++-- > .../BlackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > index d495afd..fe973a3 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSample.c > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSample.c > @@ -1893,7 +1893,7 @@ DriverSampleInit ( > EFI_STRING NameRequestHdr; > MY_EFI_VARSTORE_DATA *VarStoreConfig; > EFI_INPUT_KEY HotKey; > - EFI_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > + EDKII_FORM_BROWSER_EXTENSION_PROTOCOL *FormBrowserEx; > #if 1 > EFI_STRING Progress; > EFI_STRING Results; > @@ -2190,7 +2190,7 @@ DriverSampleInit ( > // > // Example of how to use BrowserEx protocol to register HotKey. > // > - Status = gBS->LocateProtocol (&gEfiFormBrowserExProtocolGuid, NULL, > (VOID **) &FormBrowserEx); > + Status = gBS->LocateProtocol (&gEdkiiFormBrowserExProtocolGuid, > + NULL, (VOID **) &FormBrowserEx); > if (!EFI_ERROR (Status)) { > // > // First unregister the default hot key F9 and F10. > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > index cfa049e..75cb6fb 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/BlackBoxTes > t/Dependency/SampleDriver/DriverSampleDxe.inf > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/ConfigKeywordHandler/Bl > +++ ackBoxTest/Dependency/SampleDriver/DriverSampleDxe.inf > @@ -99,7 +99,7 @@ > gEfiFormBrowser2ProtocolGuid ## CONSUMES > gEfiHiiDatabaseProtocolGuid ## CONSUMES > gEfiSimpleTextInputExProtocolGuid ## SOMETIMES_CONSUMES > - gEfiFormBrowserExProtocolGuid ## CONSUMES > + gEdkiiFormBrowserExProtocolGuid ## CONSUMES > gBlackBoxEfiConfigKeywordHandlerProtocolGuid ## CONSUMES > > [Depex] > -- > 2.7.4 > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-05-28 19:19 [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Name 2020-05-28 20:06 ` ipark [not found] ` <16134CAE37D4DAC5.10634@groups.io> @ 2020-06-05 8:11 ` G Edhaya Chandran 2020-06-22 18:30 ` Irene Park 2 siblings, 1 reply; 13+ messages in thread From: G Edhaya Chandran @ 2020-06-05 8:11 UTC (permalink / raw) To: Name, devel [-- Attachment #1: Type: text/plain, Size: 60 bytes --] Reviewed-by: G Edhaya Chandran< edhaya.chandran@ arm.com > [-- Attachment #2: Type: text/html, Size: 144 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-06-05 8:11 ` G Edhaya Chandran @ 2020-06-22 18:30 ` Irene Park [not found] ` <HE1PR0801MB1691E592BFCB7B44E6ECAAAAE8970@HE1PR0801MB1691.eurprd08.prod.outlook.com> 0 siblings, 1 reply; 13+ messages in thread From: Irene Park @ 2020-06-22 18:30 UTC (permalink / raw) To: devel@edk2.groups.io, edhaya.chandran@arm.com [-- Attachment #1: Type: text/plain, Size: 586 bytes --] Hi Edhaya, Thank you for the review. By the way, I don’t see it got mainlined yet. Do you mind to share when you’re going to pick it up ? Thank you, Irene From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of G Edhaya Chandran Sent: Friday, June 5, 2020 4:12 AM To: Irene Park <ipark@nvidia.com>; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com<mailto:edhaya.chandran@arm.com>> [-- Attachment #2: Type: text/html, Size: 3537 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <HE1PR0801MB1691E592BFCB7B44E6ECAAAAE8970@HE1PR0801MB1691.eurprd08.prod.outlook.com>]
[parent not found: <BN8PR12MB34583B559CB0E3748D6FCCD3C9920@BN8PR12MB3458.namprd12.prod.outlook.com>]
[parent not found: <MN2PR12MB3469ED3ED21B3D2503942E15C96D0@MN2PR12MB3469.namprd12.prod.outlook.com>]
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid [not found] ` <MN2PR12MB3469ED3ED21B3D2503942E15C96D0@MN2PR12MB3469.namprd12.prod.outlook.com> @ 2020-07-06 16:48 ` Irene Park 2020-07-15 5:56 ` Irene Park 0 siblings, 1 reply; 13+ messages in thread From: Irene Park @ 2020-07-06 16:48 UTC (permalink / raw) To: Jin, Eric, devel@edk2.groups.io; +Cc: G Edhaya Chandran [-- Attachment #1: Type: text/plain, Size: 1935 bytes --] Hello Eric, Would you please kindly review this change? Thank you, Irene From: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>> Sent: Monday, June 22, 2020 3:06 PM To: Jin, Eric <eric.jin@intel.com<mailto:eric.jin@intel.com>> Cc: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Hello Eric, Could you please review this change too. Once complete, I will mainline it. With Warm Regards, Edhay From: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>> Sent: 23 June 2020 00:00 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Hi Edhaya, Thank you for the review. By the way, I don’t see it got mainlined yet. Do you mind to share when you’re going to pick it up ? Thank you, Irene From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of G Edhaya Chandran Sent: Friday, June 5, 2020 4:12 AM To: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com<mailto:edhaya.chandran@arm.com>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. [-- Attachment #2: Type: text/html, Size: 6511 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-07-06 16:48 ` Irene Park @ 2020-07-15 5:56 ` Irene Park 2020-07-15 6:09 ` G Edhaya Chandran 0 siblings, 1 reply; 13+ messages in thread From: Irene Park @ 2020-07-15 5:56 UTC (permalink / raw) To: Jin, Eric, devel@edk2.groups.io, G Edhaya Chandran [-- Attachment #1: Type: text/plain, Size: 2428 bytes --] Hello Edhay, There has been no response from Eric since June 22. Do you have any concerns with this change? It’s very straight forward as indicated in REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145. Thank you, Irene From: Irene Park Sent: Monday, July 6, 2020 12:48 PM To: Jin, Eric <eric.jin@intel.com>; devel@edk2.groups.io Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Hello Eric, Would you please kindly review this change? Thank you, Irene From: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>> Sent: Monday, June 22, 2020 3:06 PM To: Jin, Eric <eric.jin@intel.com<mailto:eric.jin@intel.com>> Cc: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Hello Eric, Could you please review this change too. Once complete, I will mainline it. With Warm Regards, Edhay From: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>> Sent: 23 June 2020 00:00 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Hi Edhaya, Thank you for the review. By the way, I don’t see it got mainlined yet. Do you mind to share when you’re going to pick it up ? Thank you, Irene From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of G Edhaya Chandran Sent: Friday, June 5, 2020 4:12 AM To: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com<mailto:edhaya.chandran@arm.com>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. [-- Attachment #2: Type: text/html, Size: 8000 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-07-15 5:56 ` Irene Park @ 2020-07-15 6:09 ` G Edhaya Chandran 2020-07-26 20:09 ` G Edhaya Chandran 0 siblings, 1 reply; 13+ messages in thread From: G Edhaya Chandran @ 2020-07-15 6:09 UTC (permalink / raw) To: Irene Park, Jin, Eric, devel@edk2.groups.io [-- Attachment #1: Type: text/plain, Size: 3243 bytes --] Hello Irene, I think the code change is okay and have no concerns. Will merge this change in this week. With Warm Regards, Edhay From: Irene Park <ipark@nvidia.com> Sent: 15 July 2020 11:27 To: Jin, Eric <eric.jin@intel.com>; devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Hello Edhay, There has been no response from Eric since June 22. Do you have any concerns with this change? It’s very straight forward as indicated in REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145. Thank you, Irene From: Irene Park Sent: Monday, July 6, 2020 12:48 PM To: Jin, Eric <eric.jin@intel.com<mailto:eric.jin@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Hello Eric, Would you please kindly review this change? Thank you, Irene From: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>> Sent: Monday, June 22, 2020 3:06 PM To: Jin, Eric <eric.jin@intel.com<mailto:eric.jin@intel.com>> Cc: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Hello Eric, Could you please review this change too. Once complete, I will mainline it. With Warm Regards, Edhay From: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>> Sent: 23 June 2020 00:00 To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>> Subject: RE: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Hi Edhaya, Thank you for the review. By the way, I don’t see it got mainlined yet. Do you mind to share when you’re going to pick it up ? Thank you, Irene From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of G Edhaya Chandran Sent: Friday, June 5, 2020 4:12 AM To: Irene Park <ipark@nvidia.com<mailto:ipark@nvidia.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid External email: Use caution opening links or attachments Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com<mailto:edhaya.chandran@arm.com>> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. [-- Attachment #2: Type: text/html, Size: 9690 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid 2020-07-15 6:09 ` G Edhaya Chandran @ 2020-07-26 20:09 ` G Edhaya Chandran 0 siblings, 0 replies; 13+ messages in thread From: G Edhaya Chandran @ 2020-07-26 20:09 UTC (permalink / raw) To: G Edhaya Chandran, devel [-- Attachment #1: Type: text/plain, Size: 150 bytes --] The code is upstreamed to EDK2Test Repository Commit link: https://github.com/tianocore/edk2-test/commit/4a0caaaf7f452723a0cda028c3d702568a62b378 [-- Attachment #2: Type: text/html, Size: 301 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-07-26 20:09 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-05-28 19:19 [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid Name 2020-05-28 20:06 ` ipark [not found] ` <16134CAE37D4DAC5.10634@groups.io> 2020-06-01 20:33 ` [edk2-devel] " Irene Park 2020-06-01 20:51 ` Samer El-Haj-Mahmoud 2020-06-03 7:30 ` Irene Park 2020-06-03 7:53 ` edhaya.chandran 2020-06-05 7:30 ` Irene Park 2020-06-05 8:11 ` G Edhaya Chandran 2020-06-22 18:30 ` Irene Park [not found] ` <HE1PR0801MB1691E592BFCB7B44E6ECAAAAE8970@HE1PR0801MB1691.eurprd08.prod.outlook.com> [not found] ` <BN8PR12MB34583B559CB0E3748D6FCCD3C9920@BN8PR12MB3458.namprd12.prod.outlook.com> [not found] ` <MN2PR12MB3469ED3ED21B3D2503942E15C96D0@MN2PR12MB3469.namprd12.prod.outlook.com> 2020-07-06 16:48 ` Irene Park 2020-07-15 5:56 ` Irene Park 2020-07-15 6:09 ` G Edhaya Chandran 2020-07-26 20:09 ` G Edhaya Chandran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox