public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "G Edhaya Chandran" <edhaya.chandran@arm.com>
To: Daniel Schaefer <daniel.schaefer@hpe.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Barton Gao <gaojie@byosoft.com.cn>,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	Eric Jin <eric.jin@intel.com>, Arvin Chen <arvinx.chen@intel.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Abner Chang <abner.chang@hpe.com>
Subject: Re: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace
Date: Wed, 24 Feb 2021 09:02:01 +0000	[thread overview]
Message-ID: <HE1PR0801MB1691083C99A2BE09B81063C8E89F9@HE1PR0801MB1691.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210209154354.30234-6-daniel.schaefer@hpe.com>

Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com>

> -----Original Message-----
> From: Daniel Schaefer <daniel.schaefer@hpe.com>
> Sent: 09 February 2021 21:14
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen
> <arvinx.chen@intel.com>; Leif Lindholm <leif@nuviainc.com>; Heinrich
> Schuchardt <xypron.glpk@gmx.de>; Abner Chang <abner.chang@hpe.com>
> Subject: [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
>
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> Cc: Eric Jin <eric.jin@intel.com>
> Cc: Arvin Chen <arvinx.chen@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Abner Chang <abner.chang@hpe.com>
> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> |  4 +--
>  uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> |  6 ++---
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> |  7 +++--
>  uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> | 15 ++++++-----
>  uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> | 22 +++++++--------
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> | 28 +++++++-------------
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> | 15 ++++++-----
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> |  6 ++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> |  8 +++---
>  uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> |  8 +++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestCacheFunction.c             |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestExceptionCallbackFunction.c | 18 ++++++-------
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/Pl
> atformIsa.c                                 | 10 +++----
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestCacheFunction.c             |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestExceptionCallbackFunction.c |  6 ++---
>  uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/Pl
> atformIsa.c                                 |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPla
> t.h                                         |  8 +++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c
> |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat
> .h                                         |  6 ++---
>  uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c
> |  6 ++---
>  25 files changed, 109 insertions(+), 122 deletions(-)
>
> diff --git a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> index ee7c656b..b7832e18 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/SctLibPlat.h
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php     THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/initplat.c b/uefi-
> sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> index a48bb2f3..1c247c91 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> +++ b/uefi-sct/SctPkg/Library/SctLib/Aarch64/initplat.c
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h b/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> index 69e7f904..b7832e18 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> +++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/SctLibPlat.h
> @@ -2,16 +2,15 @@
>     Copyright 2006 - 2012 Unified EFI, Inc.<BR>   Copyright (c) 2011 - 2012, ARM
> Ltd. All rights reserved.<BR>-  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.<BR>    This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License-  which accompanies this distribution.  The
> full text of the license may be found at +  which accompanies this distribution.
> The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php     THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ @@ -21,7 +20,7 @@ Module Name:
>   Abstract: -  RISCV64 specific defines+  AArch64 specific defines  --*/ diff --git
> a/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c b/uefi-
> sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> index a48bb2f3..1c247c91 100644
> --- a/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> +++ b/uefi-sct/SctPkg/Library/SctLib/Riscv64/initplat.c
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> index d223b36b..66b5ab6a 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/GoVirtual.S
> @@ -2,15 +2,16 @@
>  # #  Copyright 2010 - 2012 Unified EFI, Inc.<BR> #  Copyright (c) 2012, ARM Ltd.
> All rights reserved.<BR>+#  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP.<BR> # #  This program and the accompanying materials #
> are licensed and made available under the terms and conditions of the BSD
> License-#  which accompanies this distribution.  The full text of the license may
> be found at +#  which accompanies this distribution.  The full text of the license
> may be found at #  http://opensource.org/licenses/bsd-license.php-# +# #  THE
> PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, #
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.-# +# ## # #@@ -23,7 +24,7 @@  #--*/ #start of the code
> section .text-/* FIXME: Should alignment be different on Aarch64? */+/* FIXME:
> Should alignment be different on Riscv64? */ .align 3  .global
> JumpToTestFunc@@ -37,8 +38,8 @@
>  #   ) # JumpToTestFunc:-mov x2, x0-mov x0, x1+mv x2, x0+
> mv x0, x1  // Jump to Virtual function-blr x2+jalr x2diff --git
> a/uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> index 397b3514..c85ea27b 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Aarch64/VirtualMemory.c
> @@ -2,15 +2,16 @@
>     Copyright 2006 - 2012 Unified EFI, Inc.<BR>   Copyright (c) 2012, ARM Ltd.
> All rights reserved.<BR>+  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.<BR>    This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License-  which accompanies this distribution.  The
> full text of the license may be found at +  which accompanies this distribution.
> The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ @@ -22,9 +23,6 @@ Module Name:
>   #include "SCRTApp.h" -#define VIRT_TO_PHYS_OFFSET       (0x80000000)
> //2G--BOOLEAN     HighAddress = FALSE; UINTN       PageTable   = 0;  @@ -
> 49,11 +47,10 @@ Returns:
>   --*/ {-/*Note: It is presumed that on ARM v5, V6 and V7 architectures- * the
> MMU is configured and enabled in PEI phase. As VirtualFunc- * is already
> mapped to virtual memory, don't have to do anything here.+  /* Note: It is
> presumed that on RISCV architectures the MMU is configured and+   * enabled
> in PEI phase. As VirtualFunc is already mapped to virtual memory,+   * don't
> have to do anything here.  */-  /* FIXME: Is it the same on ARM v8? */ }
> @@ -174,9 +171,8 @@ Returns:
>  --*/ {   //-  // Note: It is assumed that the MMU and page tables are configured
> on ARM platforms-  // based on ARM v5 v6 and v7 architecture.+  // Note: It is
> assumed that the MMU and page tables are configured on RISC-V+  //
> platforms.   //-  /* FIXME: Is it the same on ARM v8? */
> JumpToTestFunc(VirtualFunc, HandOffAddr); }diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> index ae33da18..6b727d6e 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> @@ -6,12 +6,12 @@
>  # #  This program and the accompanying materials #  are licensed and made
> available under the terms and conditions of the BSD License-#  which
> accompanies this distribution.  The full text of the license may be found at +#
> which accompanies this distribution.  The full text of the license may be found
> at #  http://opensource.org/licenses/bsd-license.php-# +# #  THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, #  WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.-# +# ## # #diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c b/uefi-
> sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> index 00b59594..c85ea27b 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/VirtualMemory.c
> @@ -6,12 +6,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> index 6161d596..b3e13f63 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Debug.c
> @@ -1,16 +1,17 @@
>  /** @file    Copyright 2006 - 2012 Unified EFI, Inc.<BR>-  Copyright (c) 2011 -
> 2012 ARM Ltd. All rights reserved.<BR>   +  Copyright (c) 2011 - 2012 ARM Ltd.
> All rights reserved.<BR>+  Copyright (c) 2021 Hewlett Packard Enterprise
> Development LP. All rights reserved.<BR>    This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License-  which accompanies this distribution.  The
> full text of the license may be found at +  which accompanies this distribution.
> The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/  /*++@@ -24,7 +25,6 @@ Module Name:
>  #include "SCRTDriver.h"  UINTN                 mHandOffPtr        =  0;-
> EFI_PHYSICAL_ADDRESS  mIoPortSpaceAddress = 0;   EFI_STATUS@@ -42,18
> +42,10 @@ ConsumeHandOff (
>     HandOffPtr  = (RUNTIME_HANDOFF*)mHandOffPtr;    *ConfigData =
> HandOffPtr->ConfigureInfo; -   if (!HandOffPtr->DebuggerInfo.MmioFlag){-
> //-     // If debug port is I/O mapped, fix IoBase Address.-     //-
> FixAddress(&HandOffPtr->DebuggerInfo.IoBase);-     mIoPortSpaceAddress =
> HandOffPtr->DebuggerInfo.IoBase;-   } else {-     //-     // If debug port is MMIO,
> fix MmioBase Address.-     //-     FixAddress(&HandOffPtr-
> >DebuggerInfo.MmioBase);-   }+   //+   // Fix MmioBase Address.+   //+
> FixAddress(&HandOffPtr->DebuggerInfo.MmioBase);     return
> EFI_SUCCESS; }@@ -65,7 +57,7 @@ Send2UART (
>    ) {   //-  // TODO: On ARM platforms use platform specific functions to+  //
> TODO: On RISC-V platforms use platform specific functions to   // write the
> data to UART.   //   return EFI_SUCCESS;diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> index cc8d9869..cb9771b1 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Dump.c
> @@ -1,16 +1,16 @@
>  /** @file    Copyright 2006 - 2012 Unified EFI, Inc.<BR>-  Copyright (c) 2011 -
> 2012 ARM Ltd. All rights reserved.<BR>   +  Copyright (c) 2011 - 2012 ARM Ltd.
> All rights reserved.<BR>    This program and the accompanying materials   are
> licensed and made available under the terms and conditions of the BSD
> License-  which accompanies this distribution.  The full text of the license may
> be found at +  which accompanies this distribution.  The full text of the license
> may be found at   http://opensource.org/licenses/bsd-license.php- +   THE
> PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.- + **/  /*++diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> index b925e151..a728d3ca 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.c
> @@ -1,16 +1,17 @@
>  /** @file    Copyright 2006 - 2012 Unified EFI, Inc.<BR>-  Copyright (c) 2011 -
> 2012 ARM Ltd. All rights reserved.<BR>   +  Copyright (c) 2011 - 2012 ARM Ltd.
> All rights reserved.<BR>+  (C) Copyright 2021 Hewlett Packard Enterprise
> Development LP<BR>    This program and the accompanying materials   are
> licensed and made available under the terms and conditions of the BSD
> License-  which accompanies this distribution.  The full text of the license may
> be found at +  which accompanies this distribution.  The full text of the license
> may be found a    http://opensource.org/licenses/bsd-license.php- +   THE
> PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.- + **/  /*++@@ -21,7 +22,7 @@ Module Name:
>   --*/ -#include "Io.h"+#include "SCRTDriver.h"  EFI_STATUS EFIAPI@@ -119,11
> +120,11 @@ FixAddress (
>    ) { //-//Note: On ARM platforms don't have to do
> this as all the functions are virtually mapped.+//Note: On RISC-V
> platforms don't have to do this as all the functions are virtually mapped.
> // } -// Quick port to ARM+// Quick port to RISC-V. It doesn't have
> traditional I/O-Port 80h POST Codes  VOID Port80 (diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> index 1e78b3e4..10ab372a 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Aarch64/Io.h
> @@ -1,16 +1,16 @@
>  /** @file    Copyright 2006 - 2012 Unified EFI, Inc.<BR>-  Copyright (c) 2011 -
> 2012 ARM Ltd. All rights reserved.<BR>   +  Copyright (c) 2011 - 2012 ARM Ltd.
> All rights reserved.<BR>    This program and the accompanying materials   are
> licensed and made available under the terms and conditions of the BSD
> License-  which accompanies this distribution.  The full text of the license may
> be found at +  which accompanies this distribution.  The full text of the license
> may be found at   http://opensource.org/licenses/bsd-license.php- +   THE
> PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.- + **/  /*++diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> index 2991935a..b3e13f63 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Debug.c
> @@ -6,12 +6,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/  /*++diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> index cc8d9869..cb9771b1 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Dump.c
> @@ -1,16 +1,16 @@
>  /** @file    Copyright 2006 - 2012 Unified EFI, Inc.<BR>-  Copyright (c) 2011 -
> 2012 ARM Ltd. All rights reserved.<BR>   +  Copyright (c) 2011 - 2012 ARM Ltd.
> All rights reserved.<BR>    This program and the accompanying materials   are
> licensed and made available under the terms and conditions of the BSD
> License-  which accompanies this distribution.  The full text of the license may
> be found at +  which accompanies this distribution.  The full text of the license
> may be found at   http://opensource.org/licenses/bsd-license.php- +   THE
> PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.- + **/  /*++diff --git a/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c b/uefi-
> sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> index 255cb9a6..a728d3ca 100644
> --- a/uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> +++ b/uefi-sct/SctPkg/SCRT/SCRTDriver/Riscv64/Io.c
> @@ -1,17 +1,17 @@
>  /** @file    Copyright 2006 - 2012 Unified EFI, Inc.<BR>-  Copyright (c) 2011 -
> 2012 ARM Ltd. All rights reserved.<BR>   +  Copyright (c) 2011 - 2012 ARM Ltd.
> All rights reserved.<BR>   (C) Copyright 2021 Hewlett Packard Enterprise
> Development LP<BR>    This program and the accompanying materials   are
> licensed and made available under the terms and conditions of the BSD
> License-  which accompanies this distribution.  The full text of the license may
> be found at +  which accompanies this distribution.  The full text of the license
> may be found a    http://opensource.org/licenses/bsd-license.php- +   THE
> PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS
> OR IMPLIED.- + **/  /*++diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestCacheFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestCacheFunction.c
> index 96ee7b57..6b54a25f 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestCacheFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTe
> +++ st/Aarch64/DebugSupportBBTestCacheFunction.c
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestExceptionCallbackFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestExceptionCallbackFunction.c
> index c27c0c0c..1cf2dd74 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/D
> ebugSupportBBTestExceptionCallbackFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTe
> +++ st/Aarch64/DebugSupportBBTestExceptionCallbackFunction.c
> @@ -2,15 +2,16 @@
>     Copyright 2006 - 2016 Unified EFI, Inc.<BR>   Copyright (c) 2011 - 2016, ARM
> Ltd. All rights reserved.<BR>+  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.<BR>    This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License-  which accompanies this distribution.  The
> full text of the license may be found at +  which accompanies this distribution.
> The full text of the license may be found a
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ @@ -37,7 +38,7 @@ SoftwareBreak (
>    void   ) {-  // Not ported to ARM yet+  // Not ported to RISC-V yet   ASSERT
> (FALSE); } @@ -99,9 +100,7 @@
> BBTestRegisterExceptionCallbackFunctionManualTest (
>    // Invoke RegisterExceptionCallback() to install an interrupt handler function.
> //   InvokedExceptionCallback = FALSE;-  // FIXME: Is it normal that we use
> EXCEPT_IA32_BREAKPOINT here?-  // Shouldn't we define proper constants for
> ARM exceptions in DebugSupportProtocol.h file?-  Status = DebugSupport-
> >RegisterExceptionCallback (DebugSupport, 0, ExceptionCallback,
> EXCEPT_IA32_BREAKPOINT);+  Status = DebugSupport-
> >RegisterExceptionCallback (DebugSupport, 0, ExceptionCallback,
> EXCEPT_RISCV_BREAKPOINT);    if ((Status == EFI_SUCCESS) || (Status ==
> EFI_ALREADY_STARTED)) {     AssertionType =
> EFI_TEST_ASSERTION_PASSED;@@ -205,7 +204,7 @@
> BBTestRegisterExceptionCallbackFunctionManualTest (
>    // Assertion Point 3.4.2.3   // Invoke RegisterExceptionCallback() to install
> another interrupt handler function.   //-  Status = DebugSupport-
> >RegisterExceptionCallback (DebugSupport, 0, ExceptionCallback1,
> EXCEPT_IA32_BREAKPOINT);+  Status = DebugSupport-
> >RegisterExceptionCallback (DebugSupport, 0, ExceptionCallback1,
> EXCEPT_RISCV_BREAKPOINT);    if (Status != EFI_ALREADY_STARTED)
> {     AssertionType = EFI_TEST_ASSERTION_FAILED;@@ -228,7 +227,7 @@
> BBTestRegisterExceptionCallbackFunctionManualTest (
>    // Assertion Point 3.4.2.4   // Invoke RegisterExceptionCallback() to unstall the
> interrupt handler function.   //-  Status = DebugSupport-
> >RegisterExceptionCallback (DebugSupport, 0, NULL,
> EXCEPT_IA32_BREAKPOINT);+  Status = DebugSupport-
> >RegisterExceptionCallback (DebugSupport, 0, NULL,
> EXCEPT_RISCV_BREAKPOINT);    if (EFI_ERROR(Status)) {     AssertionType =
> EFI_TEST_ASSERTION_FAILED;@@ -273,4 +272,3 @@
> BBTestRegisterExceptionCallbackFunctionManualTest (
>     return EFI_SUCCESS; }-diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/Pl
> atformIsa.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/Pl
> atformIsa.c
> index 8334f601..d91f520e 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Aarch64/Pl
> atformIsa.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTe
> +++ st/Aarch64/PlatformIsa.c
> @@ -2,15 +2,16 @@
>     Copyright 2006 - 2012 Unified EFI, Inc.<BR>   Copyright (c) 2011 - 2012, ARM
> Ltd. All rights reserved.<BR>+  Copyright (c) 2021, Hewlett Packard Enterprise
> Development LP. All rights reserved.<BR>    This program and the
> accompanying materials   are licensed and made available under the terms
> and conditions of the BSD License-  which accompanies this distribution.  The
> full text of the license may be found at +  which accompanies this distribution.
> The full text of the license may be found at
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ @@ -26,5 +27,4 @@ Abstract:
>   #include "DebugSupportBBTestMain.h" -
> EFI_INSTRUCTION_SET_ARCHITECTURE PlatformIsa = IsaAArch64;-
> +EFI_INSTRUCTION_SET_ARCHITECTURE PlatformIsa = IsaRiscv64;diff --git
> a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestCacheFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestCacheFunction.c
> index 96ee7b57..6b54a25f 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestCacheFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTe
> +++ st/Riscv64/DebugSupportBBTestCacheFunction.c
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestExceptionCallbackFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestExceptionCallbackFunction.c
> index c6e72806..1cf2dd74 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/De
> bugSupportBBTestExceptionCallbackFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTe
> +++ st/Riscv64/DebugSupportBBTestExceptionCallbackFunction.c
> @@ -6,12 +6,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found a
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/Pl
> atformIsa.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/Pl
> atformIsa.c
> index 8b23d91b..d91f520e 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTest/Riscv64/Pl
> atformIsa.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DebugSupport/BlackBoxTe
> +++ st/Riscv64/PlatformIsa.c
> @@ -6,12 +6,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found
> at   http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPla
> t.h b/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPla
> t.h
> index ff781aee..41a6c8bf 100644
> --- a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/EntsLibPla
> t.h
> +++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch
> +++ 64/EntsLibPlat.h
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found a
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ @@ -20,7 +20,7 @@ Module Name:
>   Abstract: -  AArch64 specific defines+  RISCV64 specific defines  --*/ diff --git
> a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c
> b/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c
> index 70a509a4..7a66c099 100644
> --- a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch64/InitPlat.c
> +++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Aarch
> +++ 64/InitPlat.c
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found a
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat
> .h b/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat
> .h
> index 7f7835e4..41a6c8bf 100644
> --- a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/EntsLibPlat
> .h
> +++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv
> +++ 64/EntsLibPlat.h
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found a
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ diff --git a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c
> b/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c
> index 70a509a4..7a66c099 100644
> --- a/uefi-
> sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv64/InitPlat.c
> +++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/ENTS/EasLib/Riscv
> +++ 64/InitPlat.c
> @@ -5,12 +5,12 @@
>     This program and the accompanying materials   are licensed and made
> available under the terms and conditions of the BSD License-  which
> accompanies this distribution.  The full text of the license may be found at +
> which accompanies this distribution.  The full text of the license may be found a
> http://opensource.org/licenses/bsd-license.php- +   THE PROGRAM IS
> DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,   WITHOUT
> WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
> IMPLIED.- + **/ /*++ --
> 2.30.0

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  parent reply	other threads:[~2021-02-24  9:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09 15:43 [edk2-test PATCHv2 0/5] Port SCT to RISCV64 Daniel Schaefer
2021-02-09 15:43 ` [edk2-test PATCHv2 1/5] SctPkg: Add RISCV64 support by using Aarch64 sources Daniel Schaefer
2021-02-25  2:44   ` Abner Chang
2021-02-09 15:43 ` [edk2-test PATCHv2 2/5] SctPkg: Adapt Aarch64 sources for Riscv64 Daniel Schaefer
2021-02-25  2:47   ` Abner Chang
2021-02-09 15:43 ` [edk2-test PATCHv2 3/5] SctPkg: Add RISCV64 build support Daniel Schaefer
2021-02-25  5:47   ` Abner Chang
2021-02-09 15:43 ` [edk2-test PATCHv2 4/5] SctPkg: Unify CC_FLAGS for all GCC platforms Daniel Schaefer
2021-02-25  6:56   ` Abner Chang
2021-03-04  3:01     ` Daniel Schaefer
2021-02-09 15:43 ` [edk2-test PATCHv2 5/5] SctPkg: Remove trailing whitespace Daniel Schaefer
2021-02-20 16:04   ` Samer El-Haj-Mahmoud
2021-02-24  9:02   ` G Edhaya Chandran [this message]
2021-02-25  3:07     ` Abner Chang
2021-03-04  3:08       ` Daniel Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR0801MB1691083C99A2BE09B81063C8E89F9@HE1PR0801MB1691.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox