From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.61]) by mx.groups.io with SMTP id smtpd.web10.59306.1606741157705801617 for ; Mon, 30 Nov 2020 04:59:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Pu9RQGll; spf=pass (domain: arm.com, ip: 40.107.22.61, mailfrom: edhaya.chandran@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odYdSfzlw1Gso5oLMiHSQiHh/Bm72+4zKmOuh/1++J8=; b=Pu9RQGllldOAgwQeLYoj9oyl/4KM3Es1arMwqj1ybHjOTzW2khYszkq+4CcI0iykUItFDi8sSiGdV2jPPP0JQ14TuDgE7vTNWkKGmnINXBVNj9bANhd/6PzDr+KHUsZUJafUrFjv0ulXI+Zfn4gBZcJ1RrfCVnPM5V7LdYK4XeE= Received: from AM7PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:20b:100::20) by VI1PR0802MB2416.eurprd08.prod.outlook.com (2603:10a6:800:bb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.25; Mon, 30 Nov 2020 12:59:14 +0000 Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::6c) by AM7PR02CA0010.outlook.office365.com (2603:10a6:20b:100::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.20 via Frontend Transport; Mon, 30 Nov 2020 12:59:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.26 via Frontend Transport; Mon, 30 Nov 2020 12:59:14 +0000 Received: ("Tessian outbound 814be617737e:v71"); Mon, 30 Nov 2020 12:59:13 +0000 X-CR-MTA-TID: 64aa7808 Received: from 286c2fd0f986.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 30D22A68-A23D-4D64-B3F2-B2089A24DF8C.1; Mon, 30 Nov 2020 12:59:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 286c2fd0f986.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 30 Nov 2020 12:59:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DjlmZuIOD7ffKKaO/yWi1E88SywUOhwf859DUak16+wGj00aBIU6pBrJ119u+aN2ZAek2g3J9k28IdC//1uv9m0YohfuY4BYAO5ZBHi7jJ6criTb5PZLxqAxbbH4wNAnkEoEhoz3NCsSc0RITTVrVUnqsj4+jlPpbNFdCdhBGxaXJ81NC3h/J4iR4sLrvIl322i7jeVf8CNb8hICVp+JQLfCACShHCUtrKpr0Dsm65aCS+z5P5B6eT7RojiMxzBd7kJG5jW74d3GeVP62ZCUk5twB3mweoA710VEnmDDcuF0ScrrPnqgK1zdNSwAOg3TwR4+c2fQDOqPtpOklRpQ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odYdSfzlw1Gso5oLMiHSQiHh/Bm72+4zKmOuh/1++J8=; b=ORdz2Tf65zfX3By43yQ8/3F+bld121+HLQ87FX/drcU9CPF/c1AOxUXhYb6YNPOGt9x2ILIeL37Z/npLCFDOHIVX49cg/aRlF2w9o9ZdYg0hhRTpFRrH3h2CJiWekTNomZbgFQF9xi865lorGgHnh51BF3lzuw0zINLCo+urwsWjY+9FKBcDiFMoiXoR6n95HUH5qVylWT5jpXEHUSJ+K3uN1pPWxBI0MVRkMsG4jnmHCFomoTzi2NCGZbVGAzwPhAvkU3xP93yVTm6JOxfpVm8B5kD3G82XsGpxCvSMMIqX0rBquOUPxZPgaorFknBkmQDLDaEuhAtw0i3v7ZpbDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odYdSfzlw1Gso5oLMiHSQiHh/Bm72+4zKmOuh/1++J8=; b=Pu9RQGllldOAgwQeLYoj9oyl/4KM3Es1arMwqj1ybHjOTzW2khYszkq+4CcI0iykUItFDi8sSiGdV2jPPP0JQ14TuDgE7vTNWkKGmnINXBVNj9bANhd/6PzDr+KHUsZUJafUrFjv0ulXI+Zfn4gBZcJ1RrfCVnPM5V7LdYK4XeE= Received: from HE1PR0801MB1691.eurprd08.prod.outlook.com (2603:10a6:3:7b::13) by HE1PR0801MB2027.eurprd08.prod.outlook.com (2603:10a6:3:4f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3611.23; Mon, 30 Nov 2020 12:59:04 +0000 Received: from HE1PR0801MB1691.eurprd08.prod.outlook.com ([fe80::dfe:c28c:4e1e:c163]) by HE1PR0801MB1691.eurprd08.prod.outlook.com ([fe80::dfe:c28c:4e1e:c163%12]) with mapi id 15.20.3611.025; Mon, 30 Nov 2020 12:59:04 +0000 From: "G Edhaya Chandran" To: Heinrich Schuchardt CC: EDK II Development , Eric Jin , Samer El-Haj-Mahmoud , Barton Gao Subject: Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: build failure DevicePathToText test Thread-Topic: [PATCH edk2-test 1/1] uefi-sct/SctPkg: build failure DevicePathToText test Thread-Index: AQHWw181CuwEkWcaN06qaGQD5cG7MKngqJXw Date: Mon, 30 Nov 2020 12:59:04 +0000 Message-ID: References: <20201125191248.9381-1-xypron.glpk@gmx.de> In-Reply-To: <20201125191248.9381-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1CA304DB64286C499B436FC83C66A8E8.0 x-checkrecipientchecked: true Authentication-Results-Original: gmx.de; dkim=none (message not signed) header.d=none;gmx.de; dmarc=none action=none header.from=arm.com; x-originating-ip: [103.130.108.184] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 54c3f22e-6850-4105-fbbc-08d8952fbd55 x-ms-traffictypediagnostic: HE1PR0801MB2027:|VI1PR0802MB2416: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:374;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: O5us3MrUeIcOHZTJJTep4ws0J5dpBf166/HJXu1w4DLN7878LtRHnJx0tkTJVwz3P06Yp77l8nHQVXAq/PTTNPAoMAYtTGR9Fqaw5ZPF442K7bL220PptXmPqPXv77bYWoMJoiLARvI252/taeHCTnHBRzYbWBuJ618Psr8KWnVDhGiPA4e52juPN+nTpuGY5woZ2TdJR8iLHMCNTUmf9y/6KGX2jI3Mb5UWTirKc4gv6jJKtghEn05RluRy0AEXwCW/prZrAygCiIegUET6pJ9HOzdqqlvmnlGMZM7nnG/4JVoXKjnX3evpeZI3GFpGICZucGJWIC5MiWc5aw7sJ25O38etsyrh50MMQLUAzn5CESOWP1SUXtgyiQf7jhlu8ugQ5hiiFiAYjI+BOOGvAQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR0801MB1691.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(55016002)(2906002)(8676002)(478600001)(8936002)(53546011)(6506007)(9686003)(186003)(966005)(5660300002)(26005)(54906003)(71200400001)(52536014)(316002)(66946007)(7696005)(6916009)(66446008)(66476007)(66556008)(64756008)(76116006)(33656002)(86362001)(83380400001)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?KaiSVuNqfTBNM5DWsLz0vLqFBycFjrQQySwa/uxXvEJLn6myhBSB0bE3778l?= =?us-ascii?Q?tSDDtc6QIGaDuO39sxIw6qTPCnq6xrdN3stdnyA+t75zdBLCvaHkjjaSHIa2?= =?us-ascii?Q?7+0RQCRJ62HDH5DlfsFL/OFRgfJrcX6n3wam0UJe2+KcSxOn0a+lv6MEBRWZ?= =?us-ascii?Q?UoKkye5sMxwjYK9rpaHZbLoNhDQ19rEHxbvwAFvk4wP2wTTYkq3sRde+9gR0?= =?us-ascii?Q?aiK1098j89ihQeMaOqp1m8V9sgT/qEuVyxEycT41YD4vwPcbLdevjlJsxKev?= =?us-ascii?Q?Zkh8p+BBOlnSBN4VPlPMMQ0nSOgVhEA4h8RyGPOXgxLEDe/yW1IJKW5y0eT9?= =?us-ascii?Q?pHo8YJP0Dc6qkwusT2/UjPTSu/+RPGRJ3kQvWnPqp1NikHGeqBaye8KhFmFX?= =?us-ascii?Q?0/HYL5wfTKl2Q3hLD+XdqtO4SJltJgNskIAwAOyyJR82eNjuJEhv0ynnfP8e?= =?us-ascii?Q?0Cb5zr4T8ep1yjJAJ8BR89oKMOsNmCDg08nNbBaHJq1uyx91lG05VZzV3CKZ?= =?us-ascii?Q?GjxBB3I345t3SHEa8UyUzrA0tNRQ28v0mtFJzdCrSBh0GHWlxH1JxJMUNWPt?= =?us-ascii?Q?Y6J6xwU6MG4dirhNGcHPsuDvlTwdl1U8WiG3/TLC18aDbKHQi6THT2x0oRrB?= =?us-ascii?Q?M4nuH6ydJaYIWMdIWPK1MrfxVr9aHyeQ/Q6COx/aXAO0Kcxl2ZvXLEIp0MFR?= =?us-ascii?Q?fwBoFhWnZtvW+lSdYCSb5G+wYZrZWSHPOX/Wx0vD0PMNbPFNjgHhb2J7FhEi?= =?us-ascii?Q?m8pmTd4h4g3d0vkloVu5PpuG/TYHEJvYc6nkLTPjkQH92HRpJarqLPEhlnBU?= =?us-ascii?Q?Uqg9/todxByDUJb5yErmEbyAZifeDrZMoJK281/G05ysjrl3DzYOP4DMCprQ?= =?us-ascii?Q?xe6d0+xHZKFnF+O78AiCXqVmwB6LXZdQgnwMSCTxCueEfpTYjtfhw1aEd3RS?= =?us-ascii?Q?+Cw6W984wiv+X0xVpl3ny+zQFb8tL08SgNyRZprOlLQ=3D?= MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2027 Original-Authentication-Results: gmx.de; dkim=none (message not signed) header.d=none;gmx.de; dmarc=none action=none header.from=arm.com; Return-Path: Edhaya.Chandran@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b3eceaa5-9071-41b0-1c28-08d8952fb77a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eQazt3SWy8q+ZIRU5U2+TmZI2oz9RHiOf0eNcvkt+KfCjEfZe0ihRATn5NDyN2wI5aoFBdpi9C6RwQMZKYEns4tI82axNESzdfcIf5xYwbbVygjzSrxM3aO3C6g/BJrkkwr14XepHMK0lWomzm1qYl8mxBnnBveI5Re68cceR97fMIolpPY0t+HkYOEYI6vZZiFTSAP7uMyV//i6Ooan8ESljEqX+kzOMApFRNv4Pd9wpTUsxOPO2rcKSoUVsfrlhA+yWTTB9qZccLFMfk00M1l+AVE1mlN5/jdv+XWp9mtUYx+yqe3Wyc/HS3gnteHjreW2Q6fECFkA3kApQHydPLGkEY8QlCLeffmNJTdzxEN0WdCY0WOPfkJxPW/muMM9GMjx953yfxFYtucruD3gXs5pie3m7Uaw9hl2BSW+mi7cq5cN0xGASNAnXSeK/PygelH3HfcoHO0n9DXIBeSEw3fcCNz4QUyc0dactMPw5LM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(136003)(376002)(396003)(39860400002)(46966005)(26005)(52536014)(81166007)(6862004)(186003)(33656002)(5660300002)(86362001)(107886003)(478600001)(336012)(70206006)(70586007)(356005)(82310400003)(83380400001)(966005)(2906002)(7696005)(8676002)(55016002)(53546011)(8936002)(316002)(4326008)(47076004)(54906003)(9686003)(6506007)(82740400003)(36906005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2020 12:59:14.4895 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54c3f22e-6850-4105-fbbc-08d8952fbd55 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2416 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: G Edhaya Chandran Upstreamed by the commit-id : fb0e695747e2cb45580f7cc3277cda39fa363ed3 With Warm Regards, Edhay > -----Original Message----- > From: Heinrich Schuchardt > Sent: 26 November 2020 00:43 > To: G Edhaya Chandran > Cc: EDK II Development ; Eric Jin ; > Samer El-Haj-Mahmoud ; Barton Gao > ; Heinrich Schuchardt > Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: build failure DevicePathT= oText > test > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3029 > > After commit 75c92b85bf9b ("uefi-sct/SctPkg: NULL deref in DevicePathToTe= xt > test") a build failure was observed. > > Length is a field in MEDIA_OFFSET_DEVICE_PATH.Header and not in > MEDIA_OFFSET_DEVICE_PATH itself. > > Fixes: 75c92b85bf9b ("uefi-sct/SctPkg: NULL deref in DevicePathToText tes= t") > Signed-off-by: Heinrich Schuchardt > --- > .../BlackBoxTest/DevicePathToTextBBTestCoverage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/Devic= e > PathToTextBBTestCoverage.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/Devic= e > PathToTextBBTestCoverage.c > index eb77c3564e95..e83d570662c2 100644 > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/Devic= e > PathToTextBBTestCoverage.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackB > +++ oxTest/DevicePathToTextBBTestCoverage.c > @@ -1200,7 +1200,7 @@ > DevicePathToTextConvertDeviceNodeToTextCoverageTest ( > pDeviceNode2 =3D SctConvertTextToDeviceNode(Text); > SctPrint(L"pDeviceNode2 =3D %p\n", pDeviceNode2); > if (pDeviceNode2 && > - ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Length =3D=3D > + ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Header.Length =3D=3D > sizeof(MEDIA_OFFSET_DEVICE_PATH)) { > ((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Reserved =3D 0; > } > -- > 2.29.2 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.