From: "G Edhaya Chandran" <edhaya.chandran@arm.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
EDK II Development <devel@edk2.groups.io>
Cc: Eric Jin <eric.jin@intel.com>, Barton Gao <gaojie@byosoft.com.cn>,
Arvin Chen <arvinx.chen@intel.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [PATCH 1/1] uefi-sct/SctPkg: format string BBTestFatToStrFunctionAutoTest
Date: Tue, 5 Jan 2021 15:13:43 +0000 [thread overview]
Message-ID: <HE1PR0801MB16916AD9BAE862ECBF75E12DE8D10@HE1PR0801MB1691.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210101195227.59101-1-xypron.glpk@gmx.de>
Reviewed-By: G Edhaya Chandran <edhaya.chandran@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: 02 January 2021 01:22
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
> Subject: [PATCH 1/1] uefi-sct/SctPkg: format string
> BBTestFatToStrFunctionAutoTest
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3146
>
> EFI_UNICODE_COLLATION_PROTOCOL.FatToStr() expects as parameter Fat an
> ASCII string not a wide string.
>
> In function BBTestFatToStrFunctionAutoTest() this string is supplied as
> TestData[Index].
>
> When printing this string we cannot use "%s" but we must use "%a".
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> .../BlackBoxTest/UnicodeCollation2BBTestFunction.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/Unicod
> eCollation2BBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/Unicod
> eCollation2BBTestFunction.c
> index 8bf5170f..22b57f21 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/Unicod
> eCollation2BBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/Black
> +++ BoxTest/UnicodeCollation2BBTestFunction.c
> @@ -636,7 +636,7 @@ BBTestFatToStrFunctionAutoTest (
> AssertionType,
> gUnicodeCollationFunctionTestAssertionGuid007,
> L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification of
> FatToStr interface",
> - L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
> + L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d,
> + StrSize=%d",
> __FILE__,
> (UINTN)__LINE__,
> TestData[Index],
> @@ -668,7 +668,7 @@ BBTestFatToStrFunctionAutoTest (
> AssertionType,
> gUnicodeCollationFunctionTestAssertionGuid008,
> L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification
> of FatToStr interface",
> - L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
> + L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d,
> + StrSize=%d",
> __FILE__,
> (UINTN)__LINE__,
> TestData[Index],
> @@ -701,7 +701,7 @@ BBTestFatToStrFunctionAutoTest (
> AssertionType,
> gUnicodeCollationFunctionTestAssertionGuid009,
> L"EFI_UNICODE_COLLATION_PROTOCOL.FatToStr - Verification
> of FatToStr interface",
> - L"%a:%d: Fat='%s', FatToStr='%s', FatSize=%d, StrSize=%d",
> + L"%a:%d: Fat='%a', FatToStr='%s', FatSize=%d,
> + StrSize=%d",
> __FILE__,
> (UINTN)__LINE__,
> TestData[Index],
> --
> 2.29.2
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
prev parent reply other threads:[~2021-01-05 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 19:52 [PATCH 1/1] uefi-sct/SctPkg: format string BBTestFatToStrFunctionAutoTest Heinrich Schuchardt
2021-01-05 15:13 ` G Edhaya Chandran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0801MB16916AD9BAE862ECBF75E12DE8D10@HE1PR0801MB1691.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox