[edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

[edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

[Heinrich Schuchardt]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2865

QueryVariableInfo() returning EFI_SUCCESS for a legal combination of
attributes is not an error.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 .../BlackBoxTest/AuthVariableServicesBBTestConformance.c        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c
index 23b00e35..f16560ff 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c
@@ -287,7 +287,7 @@ AuthVariableDERConfTest (
                    &MaximumVariableSize
                    );
 
-    if (Status == EFI_UNSUPPORTED) {
+    if (Status == EFI_SUCCESS || Status == EFI_UNSUPPORTED) {
       Result = EFI_TEST_ASSERTION_PASSED;
     } else {
       Result = EFI_TEST_ASSERTION_FAILED;
-- 
2.27.0

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

[Samer El-Haj-Mahmoud]

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heinrich
> Schuchardt via groups.io
> Sent: Monday, July 27, 2020 1:53 PM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
> Subject: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable
> services conformance test
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2865
>
> QueryVariableInfo() returning EFI_SUCCESS for a legal combination of
> attributes is not an error.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  .../BlackBoxTest/AuthVariableServicesBBTestConformance.c        | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxT
> est/AuthVariableServicesBBTestConformance.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxT
> est/AuthVariableServicesBBTestConformance.c
> index 23b00e35..f16560ff 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxT
> est/AuthVariableServicesBBTestConformance.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices
> +++ /BlackBoxTest/AuthVariableServicesBBTestConformance.c
> @@ -287,7 +287,7 @@ AuthVariableDERConfTest (
>                     &MaximumVariableSize                    ); -    if (Status ==
> EFI_UNSUPPORTED) {+    if (Status == EFI_SUCCESS || Status ==
> EFI_UNSUPPORTED) {       Result = EFI_TEST_ASSERTION_PASSED;     } else {
> Result = EFI_TEST_ASSERTION_FAILED;--
> 2.27.0
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#63354): https://edk2.groups.io/g/devel/message/63354
> Mute This Topic: https://groups.io/mt/75828348/1945644
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [samer.el-haj-
> mahmoud@arm.com] -=-=-=-=-=-=

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

[Heinrich Schuchardt]

On 8/4/20 1:13 PM, Samer El-Haj-Mahmoud wrote:
> Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

Dear Edhaya,

could you, please, consider these patches

https://edk2.groups.io/g/devel/message/63354
https://edk2.groups.io/g/devel/message/52599

for review and merging.

Best regards

Heinrich

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

[G Edhaya Chandran]

Hello Heinrich,

    The patches are under review.
Will complete the review and merge by end of this week.

With Warm Regards,
Edhay

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Heinrich
> Schuchardt via groups.io
> Sent: 12 August 2020 19:25
> To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin
> <eric.jin@intel.com>
> Subject: Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable
> services conformance test
>
> On 8/4/20 1:13 PM, Samer El-Haj-Mahmoud wrote:
> > Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
> Dear Edhaya,
>
> could you, please, consider these patches
>
> https://edk2.groups.io/g/devel/message/63354
> https://edk2.groups.io/g/devel/message/52599
>
> for review and merging.
>
> Best regards
>
> Heinrich
>
> 

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

[G Edhaya Chandran]

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>

Upstreamed by the commit-d : 891aed7c4fee9c831812fb2d6fc2aeeac6661884

[-- Attachment #2: Type: text/html, Size: 583 bytes --]