From: "G Edhaya Chandran" <edhaya.chandran@arm.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in DevicePathToText test
Date: Wed, 25 Nov 2020 06:40:36 +0000 [thread overview]
Message-ID: <HE1PR0801MB16919FE04979EE15309362E3E8FA0@HE1PR0801MB1691.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <62f9ad71-a281-1f90-83e8-af934f295928@gmx.de>
[-- Attachment #1.1: Type: text/plain, Size: 4257 bytes --]
Hi Heinrich,
This part is giving a build error, can you please check.
https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf44f40a2741f963230c#diff-7f0df1676a2f898b39de5685efb7a296a7f08e5e5ccb4aaec0a5fdebea926727
[cid:image001.jpg@01D6C323.F7844200]
/home/zubmoh01/Work/sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c: In function ‘DevicePathToTextConvertDeviceNodeToTextCoverageTest’:
/home/zubmoh01/Work/sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestCoverage.c:1203:49: error: ‘MEDIA_OFFSET_DEVICE_PATH {aka struct <anonymous>}’ has no member named ‘Length’
((MEDIA_OFFSET_DEVICE_PATH *)pDeviceNode2)->Length ==
^~
"aarch64-linux-gnu-gcc" -MMD -MF /home/zubmoh01/Work/sct/Build/UefiSct/RELEASE_GCC5/AARCH64/SctPkg/TestCase/UEFI/EFI/BootServices/ImageServices/BlackBoxTest/Dependency/CombinationImage2/CombinationImage2/OUTPUT/ProtocolDefinition.obj.deps -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -ffunction-sections -fdata-sections -DSTRING_ARRAY_NAME=ImageServices_CombinationImage2Strings -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -fno-pic -fno-pie -ffixed-x18 -mcmodel=small -flto -Wno-unused-but-set-variable -Wno-unused-const-variable -D EFIAARCH64 -D EFIAARCH64 -ffreestanding -nostdinc -nostdlib -Wno-error=unused-function -Wno-error=unused-but-set-variable -Wno-error -DMDEPKG_NDEBUG -c -o
With Warm Regards,
Edhay
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: 24 November 2020 22:38
> To: G Edhaya Chandran <Edhaya.Chandran@arm.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in
> DevicePathToText test
>
> On 11/24/20 5:33 PM, G Edhaya Chandran wrote:
> > Hi Heinrich,
> >
> > Oh okay. Actually, I have already upstreamed this.
> > I suggest, I will remove the debug SctPrint myself as part of another upstream.
> >
> > Is it okay?
> >
> > With Warm Regards,
> > Edhay
>
> Thanks for taking care.
>
> Best regards
>
> Heinrich
>
> >
> >
> >> -----Original Message-----
> >> From: Heinrich Schuchardt <xypron.glpk@gmx.de<mailto:xypron.glpk@gmx.de>>
> >> Sent: 24 November 2020 21:57
> >> To: G Edhaya Chandran <Edhaya.Chandran@arm.com<mailto:Edhaya.Chandran@arm.com>>;
> devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> >> Subject: Re: [edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: NULL deref in
> >> DevicePathToText test
> >>
> >> On 11/24/20 5:07 PM, G Edhaya Chandran wrote:
> >>> Upstreamed by commit-id
> >>> :
> >>> https://github.com/tianocore/edk2-test/commit/75c92b85bf9bb82a7049bf
> >>> 44
> >>> f40a2741f963230c
> >>>
> >>
> >> Hello Edhaya,
> >>
> >> it seems a SctPrint() statement slipped into the patch which was only
> >> used for debugging.
> >>
> >> Should I open a new issue? Or just send a patch removing the SctPrint
> >> with reference to #3029?
> >>
> >> Best regards
> >>
> >> Heinrich
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
> >
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
[-- Attachment #1.2: Type: text/html, Size: 10874 bytes --]
[-- Attachment #2: image001.jpg --]
[-- Type: image/jpeg, Size: 29665 bytes --]
prev parent reply other threads:[~2020-11-25 6:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 20:01 [PATCH 1/1] uefi-sct/SctPkg: NULL deref in DevicePathToText test Heinrich Schuchardt
2020-11-04 15:52 ` [edk2-devel] " G Edhaya Chandran
2020-11-23 10:25 ` Grant Likely
2020-11-24 16:07 ` G Edhaya Chandran
2020-11-24 16:26 ` Heinrich Schuchardt
2020-11-24 16:33 ` G Edhaya Chandran
2020-11-24 17:08 ` Heinrich Schuchardt
2020-11-25 6:40 ` G Edhaya Chandran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0801MB16919FE04979EE15309362E3E8FA0@HE1PR0801MB1691.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox