From: "G Edhaya Chandran" <edhaya.chandran@arm.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
EDK II Development <devel@edk2.groups.io>
Cc: Eric Jin <eric.jin@intel.com>, Barton Gao <gaojie@byosoft.com.cn>,
Arvin Chen <arvinx.chen@intel.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: Re: [PATCH edk2-test 1/1] uefi-sct/SctPkg: typo Positoin
Date: Wed, 17 Mar 2021 15:41:36 +0000 [thread overview]
Message-ID: <HE1PR0801MB1691D8AB52E7F2F03021AFC6E86A9@HE1PR0801MB1691.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210304033229.21563-1-xypron.glpk@gmx.de>
Reviewed-by: G Edhaya Chandran<edhaya.chandran@arm.com>
> -----Original Message-----
> From: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Sent: 04 March 2021 09:02
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Eric Jin <eric.jin@intel.com>; G Edhaya Chandran
> <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Arvin
> Chen <arvinx.chen@intel.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-
> Mahmoud@arm.com>; Heinrich Schuchardt <xypron.glpk@gmx.de>
> Subject: [PATCH edk2-test 1/1] uefi-sct/SctPkg: typo Positoin
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3244
>
> %s/Positoin/Position/g
> %s/positoin/position/g
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> .../BlackBoxTest/SimpleTextOutBBTestConformance_efi.c | 4 ++--
> .../BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c | 4 ++--
> .../BlackBoxTest/SimpleTextOutBBTestFunction_efi.c | 4 ++--
> .../BlackBoxTest/SimpleTextOutBBTestFunction_uefi.c | 4 ++--
> .../BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c | 4 ++--
> .../BlackBoxTest/SimpleTextOutBBTestFunction_uefi.c | 4 ++--
> .../SctPkg/TestInfrastructure/SCT/Framework/UI/KeyFunction.c | 2 +-
> 7 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_efi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_efi.c
> index 3b394f242434..8b8c3f86f3ca 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_efi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_efi.c
> @@ -840,7 +840,7 @@ BBTestSetCursorPositionConformanceAutoTest (
> AssertionType,
> gSimpleTextOutputConformanceTestAssertionGuid009,
> L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPosition() with invalid position, mode position integrity",
> - L"%a:%d: Mode=%d, Positoin=(%d x %d) Current: Cursor
> Position(%d x %d), Mode=%d, MaxMode=%d, Attribute=%d, CursorVisible=%d.
> "\
> + L"%a:%d: Mode=%d, Position=(%d x %d) Current: Cursor
> Position(%d x %d), Mode=%d, MaxMode=%d, Attribute=%d, CursorVisible=%d.
> "\
> L" Expected:Cursor Position(%d x %d), Mode=%d, MaxMode=%d,
> Attribute=%d, CursorVisible=%d.",
> __FILE__,
> (UINTN)__LINE__,
> @@ -873,7 +873,7 @@ BBTestSetCursorPositionConformanceAutoTest (
> StandardLib,
> AssertionType,
> gSimpleTextOutputConformanceTestAssertionGuid010,
> - L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPositoin() with invalid Position",
> + L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPosition() with invalid Position",
> L"%a:%d: Status = %r, Mode = %d, Position = (%d x %d)",
> __FILE__,
> (UINTN)__LINE__,
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_uefi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_uefi.c
> index 9afb3c0882b7..99e14d7b3bae 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_uefi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestConformance_uefi.c
> @@ -838,7 +838,7 @@ BBTestSetCursorPositionConformanceAutoTest (
> AssertionType,
> gSimpleTextOutputConformanceTestAssertionGuid009,
> L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPosition() with invalid position, mode position integrity",
> - L"%a:%d: Mode=%d, Positoin=(%d x %d) Current: Cursor
> Position(%d x %d), Mode=%d, MaxMode=%d, Attribute=%d, CursorVisible=%d.
> "\
> + L"%a:%d: Mode=%d, Position=(%d x %d) Current: Cursor
> Position(%d x %d), Mode=%d, MaxMode=%d, Attribute=%d, CursorVisible=%d.
> "\
> L" Expected:Cursor Position(%d x %d), Mode=%d, MaxMode=%d,
> Attribute=%d, CursorVisible=%d.",
> __FILE__,
> (UINTN)__LINE__,
> @@ -871,7 +871,7 @@ BBTestSetCursorPositionConformanceAutoTest (
> StandardLib,
> AssertionType,
> gSimpleTextOutputConformanceTestAssertionGuid010,
> - L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPositoin() with invalid Position",
> + L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPosition() with invalid Position",
> L"%a:%d: Status = %r, Mode = %d, Position = (%d x %d)",
> __FILE__,
> (UINTN)__LINE__,
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_efi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_efi.c
> index e59e51fc12bb..6b3db8a054ab 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_efi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_efi.c
> @@ -4835,7 +4835,7 @@ BBTestSetCursorPositionFunctionManualTest (
> BackupMode (SimpleOut, &ModeExpected);
>
> //
> - // Set cursor positoin to (IndexRow * IndexColumn)
> + // Set cursor position to (IndexRow * IndexColumn)
> //
> Status = SimpleOut->SetCursorPosition (SimpleOut, IndexColumn,
> IndexRow);
>
> @@ -5155,7 +5155,7 @@ BBTestSetCursorPositionFunctionAutoTest (
> BackupMode (SimpleOut, &ModeExpected);
>
> //
> - // Set cursor positoin to (IndexRow * IndexColumn)
> + // Set cursor position to (IndexRow * IndexColumn)
> //
> Status = SimpleOut->SetCursorPosition (SimpleOut, IndexColumn,
> IndexRow);
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_uefi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_uefi.c
> index 9b0ae233ce5f..04724f554e09 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_uefi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextOut/BlackBoxTest/SimpleTex
> tOutBBTestFunction_uefi.c
> @@ -4123,7 +4123,7 @@ BBTestSetCursorPositionFunctionManualTest (
> BackupMode (SimpleOut, &ModeExpected);
>
> //
> - // Set cursor positoin to (IndexRow * IndexColumn)
> + // Set cursor position to (IndexRow * IndexColumn)
> //
> Status = SimpleOut->SetCursorPosition (SimpleOut, IndexColumn,
> IndexRow);
>
> @@ -4414,7 +4414,7 @@ BBTestSetCursorPositionFunctionAutoTest (
> BackupMode (SimpleOut, &ModeExpected);
>
> //
> - // Set cursor positoin to (IndexRow * IndexColumn)
> + // Set cursor position to (IndexRow * IndexColumn)
> //
> Status = SimpleOut->SetCursorPosition (SimpleOut, IndexColumn,
> IndexRow);
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestConformance_uefi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestConformance_uefi.c
> index 9afb3c0882b7..99e14d7b3bae 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestConformance_uefi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestConformance_uefi.c
> @@ -838,7 +838,7 @@ BBTestSetCursorPositionConformanceAutoTest (
> AssertionType,
> gSimpleTextOutputConformanceTestAssertionGuid009,
> L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPosition() with invalid position, mode position integrity",
> - L"%a:%d: Mode=%d, Positoin=(%d x %d) Current: Cursor
> Position(%d x %d), Mode=%d, MaxMode=%d, Attribute=%d, CursorVisible=%d.
> "\
> + L"%a:%d: Mode=%d, Position=(%d x %d) Current: Cursor
> Position(%d x %d), Mode=%d, MaxMode=%d, Attribute=%d, CursorVisible=%d.
> "\
> L" Expected:Cursor Position(%d x %d), Mode=%d, MaxMode=%d,
> Attribute=%d, CursorVisible=%d.",
> __FILE__,
> (UINTN)__LINE__,
> @@ -871,7 +871,7 @@ BBTestSetCursorPositionConformanceAutoTest (
> StandardLib,
> AssertionType,
> gSimpleTextOutputConformanceTestAssertionGuid010,
> - L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPositoin() with invalid Position",
> + L"EFI_SIMPLE_TEXT_OUT_PROTOCOL.SetCursorPosition -
> SetCursorPosition() with invalid Position",
> L"%a:%d: Status = %r, Mode = %d, Position = (%d x %d)",
> __FILE__,
> (UINTN)__LINE__,
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestFunction_uefi.c b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestFunction_uefi.c
> index 9b0ae233ce5f..04724f554e09 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestFunction_uefi.c
> +++ b/uefi-
> sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTe
> xtOutBBTestFunction_uefi.c
> @@ -4123,7 +4123,7 @@ BBTestSetCursorPositionFunctionManualTest (
> BackupMode (SimpleOut, &ModeExpected);
>
> //
> - // Set cursor positoin to (IndexRow * IndexColumn)
> + // Set cursor position to (IndexRow * IndexColumn)
> //
> Status = SimpleOut->SetCursorPosition (SimpleOut, IndexColumn,
> IndexRow);
>
> @@ -4414,7 +4414,7 @@ BBTestSetCursorPositionFunctionAutoTest (
> BackupMode (SimpleOut, &ModeExpected);
>
> //
> - // Set cursor positoin to (IndexRow * IndexColumn)
> + // Set cursor position to (IndexRow * IndexColumn)
> //
> Status = SimpleOut->SetCursorPosition (SimpleOut, IndexColumn,
> IndexRow);
>
> diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/UI/KeyFunction.c
> b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/UI/KeyFunction.c
> index 56756a93865b..c02fc58f935d 100644
> --- a/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/UI/KeyFunction.c
> +++ b/uefi-sct/SctPkg/TestInfrastructure/SCT/Framework/UI/KeyFunction.c
> @@ -1862,7 +1862,7 @@ Routine Description:
> X0 - the top left X position in screen
> Y0 - the top left Y position in screen
> X1 - the bottom right X position in screen
> - Y1 - the bottom right Y positoin in screen
> + Y1 - the bottom right Y position in screen
>
> Returns:
>
> --
> 2.30.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
prev parent reply other threads:[~2021-03-17 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 3:32 [PATCH edk2-test 1/1] uefi-sct/SctPkg: typo Positoin Heinrich Schuchardt
2021-03-17 15:41 ` G Edhaya Chandran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0801MB1691D8AB52E7F2F03021AFC6E86A9@HE1PR0801MB1691.eurprd08.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox