From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.47; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0047.outbound.protection.outlook.com [104.47.0.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 83006224BBC30 for ; Wed, 21 Mar 2018 05:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jKCCKrj3aImh6VH88Y4sZ8jYQYbehRNPOvOFr56kLXE=; b=Ek8VkbQkUd5dZ9svB/TXbYeWPVLwk6JY1dU55jA/OAkwu6OMlhzqmDc5jA2qJG9iB+6LBvQH6MWlNCRx9p5Bq+nfUiflnKL5ROg/fz3Vo/RgpiNoDt3p1MeHc72HaUN/1j74lX/hkeGTv4N8QE3PiqbhgHq8pQoKNZfOI34qmuI= Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com (10.168.150.14) by HE1PR0801MB2074.eurprd08.prod.outlook.com (10.168.95.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 12:26:41 +0000 Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3]) by HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3%17]) with mapi id 15.20.0588.017; Wed, 21 Mar 2018 12:26:41 +0000 From: Evan Lloyd To: Girish Pathak , "edk2-devel@lists.01.org" CC: nd , Stephanie Hughes-Fitt , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH v3 07/16] ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl Thread-Index: AQHTwGZBQkIqdvaZR0undCAUWYBE7qPanuWQ Date: Wed, 21 Mar 2018 12:26:41 +0000 Message-ID: References: <20180320161212.79120-1-girish.pathak@arm.com> <20180320161212.79120-8-girish.pathak@arm.com> In-Reply-To: <20180320161212.79120-8-girish.pathak@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0801MB2074; 6:WuCJ5jG0tQWMZ2YH/XrQg14hPyJWwYkuwZhGk7tY3gyZIeI704MrOvRzHHCg1DtKG3wGbwji7EaiFnJ/1J+IjhhMjyW4zoI6JzeckA/Y5pcjEb0CqL/ZVbj1OYselGNzFWT0KhsE43UYi8rxQG59n+azLkIpX4LxC6zrWK+ijmTPP+Qd3X/XuOnQoIup8bCIs1J00pDrsqa91UbE2Z1wskq0QRld7Y1zY46Kz9g+QJIFbjS1T/llJkt3jpaYfY+UfCI8RN1JFTLqkWBDIoYI7uzubPdB1t0GpxetvuquO2FlIX8vp9/z/i+HkAkh5GlbMvS0Yewiji7oXb3SUTTRzUOaBUIeeF6OMnJXWBE9XyXDtOfkpYcJyLBB2EZqJPw1; 5:oAUXgSFbodb8uL16cjBNVWVelYQVB8oMs+VdGM/mYyTLwpQ0JVW4kYyhTzC+6aGaHtEqghFLZrfcAMdMxK5BtdVPcEFHQ5/bFD5jUKx3nrK/xA+D00h2OMMHo9sYMa94TJHuyZNjOEyE+AZMyMAy2rxIlTYOYZu+HILVStq7k9Q=; 24:sho9srBEXRhIu7rW6RwEtItlrAk8NIEEiIPo+RMBjRHWsivJiO1qs9jwvAUQWQSdvx1ejk7oxXb8b4/VvT7k/4Dmuq5fMz6M5JGS2wMK1CU=; 7:zcQIoP3pZGVnbdsJgch+V0oRHVeUK80mjxaE1hZgWCQlsomfmVIcngKy6YHXpvvLaD3/hEVAe78kw3CZRiQkXJuShDrxIcr1feDgx1E8yBWW+1ux1YFhPKWmDiwvI8gcDY1feMZnFHO1L8T1P0msvRr3YTYg00xrtki1g6kMYG4KD1oumq4gDq1AYHgvibLABc3VH3zkGg5KUz/dJeP22WNsesPuttVk4VM2LAFwXgSa+p5mUWA+U/C1CkliXYEX x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 152c34cf-6482-4b22-0fcd-08d58f27006b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB2074; x-ms-traffictypediagnostic: HE1PR0801MB2074: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231221)(944501322)(52105095)(93006095)(93001095)(3002001)(6055026)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0801MB2074; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB2074; x-forefront-prvs: 0618E4E7E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(39380400002)(396003)(366004)(346002)(13464003)(189003)(199004)(106356001)(14454004)(9686003)(6306002)(575784001)(74316002)(229853002)(86362001)(105586002)(7696005)(66066001)(2906002)(55016002)(8676002)(72206003)(2950100002)(81156014)(81166006)(99286004)(966005)(76176011)(478600001)(3280700002)(305945005)(53936002)(6246003)(8936002)(3846002)(26005)(3660700001)(6116002)(2900100001)(25786009)(5660300001)(7736002)(6436002)(68736007)(102836004)(110136005)(6506007)(53546011)(54906003)(316002)(5250100002)(2501003)(33656002)(4326008)(97736004)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB2074; H:HE1PR0801MB1771.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: kp9kWIng0HSQg3JbRkTz0Ft7IWrjQCHN0myxiaUIqO8ML34UVOtj28mem1O2Fzl0s+qM3OyUANUJTmsesaRJhgOAHAbOAJC/GRqaKrQn8VuFBV5PPtvG/oDNTNvDfkzDD3JT3k5RDdM2kYYPT6EsHwkCk/FwiYs0+uQRl7EKrLFoxtZiVwtxKGerB7Wg+PO9DZ78cfWA/ZzS2lvvnsm+49Q2uAYIqEmr/Qs+24tZWDiBITWvi0N1JDBuf/wGXKfKFK/7BewFcyDiBhrVGx/Z/ONywU0eMmpZVFawjuGv4f7PkbPHWV1X/mWjEqGfrD6lZdnyN7UFWUEVXAzHCpDghQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 152c34cf-6482-4b22-0fcd-08d58f27006b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2018 12:26:41.4274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2074 Subject: Re: [PATCH v3 07/16] ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 12:20:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Evan Lloyd > -----Original Message----- > From: edk2-devel On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt Fitt@arm.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org > Subject: [edk2] [PATCH v3 07/16] ArmPlatformPkg: PL111Lcd: Combine > two writes to LCDControl >=20 > Currenty bit LcdPwr of the LCDControl register is enabled immediately aft= er > setting other bits of the LCDControl register. This two write sequence is > unnecessary. This change removes this extra write by setting LcdPwr bit > along with other bits of the LcdControl register. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > index > 287e3ca272c0c19f8045a3bf4e69a092d8da6fd8..465cb6845437f57d15f05 > a271d1b01f634e11b56 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > @@ -137,11 +137,7 @@ LcdSetMode ( >=20 > // PL111_REG_LCD_CONTROL > LcdControl =3D PL111_CTRL_LCD_EN | PL111_CTRL_LCD_BPP (LcdBpp) | > - PL111_CTRL_LCD_TFT | PL111_CTRL_BGR; > - MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl); > - > - // Turn on power to the LCD Panel > - LcdControl |=3D PL111_CTRL_LCD_PWR; > + PL111_CTRL_LCD_TFT | PL111_CTRL_LCD_PWR | > + PL111_CTRL_BGR; > MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl); >=20 > return EFI_SUCCESS; > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel