From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.0.52; helo=eur02-am5-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00052.outbound.protection.outlook.com [40.107.0.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EEDF8225B0287 for ; Wed, 21 Mar 2018 05:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hefnRQAeF3su2zAPFQNi269tHSNo6BKcxMhGQOi9ijU=; b=KiJge3Ic6tlo4KUHUlDSNVYPUlkROrfLA2V6sBm3xzkeapv9wHIsF/DJF7nFsmX4XwJ0Trbi/l8tduk8YYRof4LnXll2SXwROO9ZHKa2m9KCBhyzgrikBECyGCiC0j6SAnr4Ez/YazYdpOdqGFbLJcP8NBEZWJWWa/uv7/rU8LQ= Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com (10.168.150.14) by HE1PR0801MB1916.eurprd08.prod.outlook.com (10.168.94.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 12:26:53 +0000 Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3]) by HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3%17]) with mapi id 15.20.0588.017; Wed, 21 Mar 2018 12:26:53 +0000 From: Evan Lloyd To: Girish Pathak , "edk2-devel@lists.01.org" CC: nd , Stephanie Hughes-Fitt , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace magic number with macro Thread-Index: AQHTwGZEn7R9j7Dh5k26IE2b/O0ZNKPanvdg Date: Wed, 21 Mar 2018 12:26:52 +0000 Message-ID: References: <20180320161212.79120-1-girish.pathak@arm.com> <20180320161212.79120-7-girish.pathak@arm.com> In-Reply-To: <20180320161212.79120-7-girish.pathak@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0801MB1916; 7:8jYhWwS/tLQ7gLPqFGBQL9fnb1v8K3Gr9uVMbCSnYTKBU84PH0aaVXD0fmRgZdtdLup+x8JZRPtaDdu/tRNFgyyJru+Croi8c7RRY0X7aZYmvJJM0zjvlaok9i/hgdJOJv6TvHyNzKD7+MIX/+lI8FqeYKaXWRC923/4kkYk850hwPiQJfW8T7Bkyk8J77Qa/+9OeZRfHld/N5PpR1+w1YuDfu8MYACGX/f/WdF8WBOl20gYrTs1e/Cf9hqKwNbE x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 33cf0a05-f669-4124-9276-08d58f27074a x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB1916; x-ms-traffictypediagnostic: HE1PR0801MB1916: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(788757137089)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231221)(944501322)(52105095)(10201501046)(6055026)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0801MB1916; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB1916; x-forefront-prvs: 0618E4E7E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(39380400002)(346002)(396003)(189003)(199004)(13464003)(575784001)(86362001)(106356001)(102836004)(97736004)(5660300001)(6246003)(26005)(4326008)(229853002)(66066001)(2906002)(3846002)(6116002)(316002)(5250100002)(25786009)(7736002)(76176011)(6306002)(2900100001)(68736007)(53936002)(2501003)(14454004)(966005)(54906003)(99286004)(72206003)(110136005)(6436002)(74316002)(53546011)(305945005)(2950100002)(7696005)(3280700002)(81156014)(33656002)(6506007)(55016002)(478600001)(81166006)(8676002)(3660700001)(8936002)(9686003)(105586002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1916; H:HE1PR0801MB1771.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: HjVb/4U7ZjKL6H3yQAzT4AQ97DRd+kS64MhVVgUGC01+00FJtpq9P0BcxiurFYofUMIa7Lka5nRorp55amKM2i++SaJh4f10Oe0CdaOhoAOzezthDAwwkfLgIZ3XCZkdp2+ahxZadFgNDoozTldeHjzPGUfwl9VtB9zz/NITgQ1r4ftf4Jh5Dk/QiBlDWxpxMe1phBsyFNsSYJ+SnKcjM+cGZ3t40Ob++QqiC9v6zH7Rfh1FXk02P/AssErPwAvCT+GjXvjb4UpC9avYY9tzDtRJZF8DWL3AD3NZ1x8q3JQJrN8pA2nfKdgBlm8a+H24VTovKpZVw3wyOwtJBUUQSA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33cf0a05-f669-4124-9276-08d58f27074a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2018 12:26:52.9898 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1916 Subject: Re: [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace magic number with macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 12:20:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Evan Lloyd > -----Original Message----- > From: edk2-devel On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt Fitt@arm.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org > Subject: [edk2] [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace > magic number with macro >=20 > From: Girish Pathak >=20 > Minor code change, replaces magic number with macro in LCD disable. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > Reviewed-by: Ard Biesheuvel > --- > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > index > cb64c57dd79f3bb1345e4d3dbda7f5b3ce859f40..287e3ca272c0c19f8045a > 3bf4e69a092d8da6fd8 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > @@ -119,8 +119,7 @@ LcdSetMode ( > } >=20 > // Disable the CLCD_LcdEn bit > - LcdControl =3D MmioRead32 (PL111_REG_LCD_CONTROL); > - MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl & ~1); > + MmioAnd32 (PL111_REG_LCD_CONTROL, ~PL111_CTRL_LCD_EN); >=20 > // Set Timings > MmioWrite32 ( > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel