public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Evan Lloyd <Evan.Lloyd@arm.com>
To: Girish Pathak <Girish.Pathak@arm.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: nd <nd@arm.com>,
	Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>,
	"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v3 12/16] ArmPlatformPkg: Additional display modes
Date: Wed, 21 Mar 2018 12:54:04 +0000	[thread overview]
Message-ID: <HE1PR0801MB17715EFD3D16836F36162AC18BAA0@HE1PR0801MB1771.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20180320161212.79120-13-girish.pathak@arm.com>

Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>

> -----Original Message-----
> From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Girish
> Pathak
> Sent: 20 March 2018 16:12
> To: edk2-devel@lists.01.org
> Cc: nd <nd@arm.com>; Stephanie Hughes-Fitt <Stephanie.Hughes-
> Fitt@arm.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org
> Subject: [edk2] [PATCH v3 12/16] ArmPlatformPkg: Additional display
> modes
> 
> From: Girish Pathak <girish.pathak at arm.com>
> 
> Add definitions for new display modes such as HD 720.
> This has no effect on existing display drivers.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Girish Pathak <girish.pathak@arm.com>
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 60
> ++++++++++++++++++++
>  1 file changed, 60 insertions(+)
> 
> diff --git a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h
> b/ArmPlatformPkg/Include/Library/LcdPlatformLib.h
> index
> 8338b327fd2dd0d6b31653e278e25da5ac850939..cc535f0cd42db5673d41
> 8cbec940023927408687 100644
> --- a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h
> +++ b/ArmPlatformPkg/Include/Library/LcdPlatformLib.h
> @@ -26,6 +26,11 @@
>  #define WSXGA                             4
>  #define UXGA                              5
>  #define HD                                6
> +#define WVGA                              7
> +#define QHD                               8
> +#define WSVGA                             9
> +#define HD720                             10
> +#define WXGA                              11
> 
>  // VGA Mode: 640 x 480
>  #define VGA_H_RES_PIXELS                  640
> @@ -118,6 +123,61 @@
>  #define HD_V_FRONT_PORCH                  (  3 - 1)
>  #define HD_V_BACK_PORCH                   ( 32 - 1)
> 
> +// WVGA Mode: 800 x 480
> +#define WVGA_H_RES_PIXELS                 800
> +#define WVGA_V_RES_PIXELS                 480
> +#define WVGA_OSC_FREQUENCY                29500000   /* 0x01C22260 */
> +#define WVGA_H_SYNC                       ( 72 - 1)
> +#define WVGA_H_FRONT_PORCH                ( 24 - 1)
> +#define WVGA_H_BACK_PORCH                 ( 96 - 1)
> +#define WVGA_V_SYNC                       (  7 - 1)
> +#define WVGA_V_FRONT_PORCH                (  3 - 1)
> +#define WVGA_V_BACK_PORCH                 ( 10 - 1)
> +
> +// QHD Mode: 960 x 540
> +#define QHD_H_RES_PIXELS                  960
> +#define QHD_V_RES_PIXELS                  540
> +#define QHD_OSC_FREQUENCY                 40750000   /* 0x026DCBB0 */
> +#define QHD_H_SYNC                        ( 96 - 1)
> +#define QHD_H_FRONT_PORCH                 ( 32 - 1)
> +#define QHD_H_BACK_PORCH                  (128 - 1)
> +#define QHD_V_SYNC                        (  5 - 1)
> +#define QHD_V_FRONT_PORCH                 (  3 - 1)
> +#define QHD_V_BACK_PORCH                  ( 14 - 1)
> +
> +// WSVGA Mode: 1024 x 600
> +#define WSVGA_H_RES_PIXELS                1024
> +#define WSVGA_V_RES_PIXELS                600
> +#define WSVGA_OSC_FREQUENCY               49000000   /* 0x02EBAE40 */
> +#define WSVGA_H_SYNC                      (104 - 1)
> +#define WSVGA_H_FRONT_PORCH               ( 40 - 1)
> +#define WSVGA_H_BACK_PORCH                (144 - 1)
> +#define WSVGA_V_SYNC                      ( 10 - 1)
> +#define WSVGA_V_FRONT_PORCH               (  3 - 1)
> +#define WSVGA_V_BACK_PORCH                ( 11 - 1)
> +
> +// HD720 Mode: 1280 x 720
> +#define HD720_H_RES_PIXELS                 1280
> +#define HD720_V_RES_PIXELS                 720
> +#define HD720_OSC_FREQUENCY                74500000   /* 0x0470C7A0 */
> +#define HD720_H_SYNC                       (128 - 1)
> +#define HD720_H_FRONT_PORCH                ( 64 - 1)
> +#define HD720_H_BACK_PORCH                 (192 - 1)
> +#define HD720_V_SYNC                       (  5 - 1)
> +#define HD720_V_FRONT_PORCH                (  3 - 1)
> +#define HD720_V_BACK_PORCH                 ( 20 - 1)
> +
> +// WXGA Mode: 1280 x 800
> +#define WXGA_H_RES_PIXELS                  1280
> +#define WXGA_V_RES_PIXELS                  800
> +#define WXGA_OSC_FREQUENCY                 83500000  /* 0x04FA1BE0 */
> +#define WXGA_H_SYNC                        (128 - 1)
> +#define WXGA_H_FRONT_PORCH                 ( 72 - 1)
> +#define WXGA_H_BACK_PORCH                  (200 - 1)
> +#define WXGA_V_SYNC                        (  6 - 1)
> +#define WXGA_V_FRONT_PORCH                 (  3 - 1)
> +#define WXGA_V_BACK_PORCH                  ( 22 - 1)
> +
>  // Colour Masks
>  #define LCD_24BPP_RED_MASK              0x00FF0000
>  #define LCD_24BPP_GREEN_MASK            0x0000FF00
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2018-03-21 12:47 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 16:11 [PATCH v3 00/16] Update GOP Girish Pathak
2018-03-20 16:11 ` [PATCH v3 01/16] ArmPlatformPkg: Rectify line endings of LcdHwNullLib Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:11 ` [PATCH v3 02/16] ArmPlatformPkg: Rectify line endings of LcdPlatformNullLib Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:11 ` [PATCH v3 03/16] ArmPlatformPkg: Tidy Lcd code: Coding standard Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 04/16] ArmPlatformPkg: Tidy Lcd code: Updated comments Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 05/16] ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 06/16] ArmPlatformPkg: PL111Lcd: Replace magic number with macro Girish Pathak
2018-03-21 12:26   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 07/16] ArmPlatformPkg: PL111Lcd: Combine two writes to LCDControl Girish Pathak
2018-03-21 12:26   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 08/16] ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP Girish Pathak
2018-03-21 12:26   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 09/16] ArmPlatformPkg: Redefine LcdPlatformGetTimings function Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 10/16] ArmPlatformPkg: Add PCD to select pixel format Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 11/16] ArmPlatformPkg: PCD to swap red/blue format for HDLCD Girish Pathak
2018-03-21 12:53   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 12/16] ArmPlatformPkg: Additional display modes Girish Pathak
2018-03-21 12:54   ` Evan Lloyd [this message]
2018-03-20 16:12 ` [PATCH v3 13/16] ArmPlatformPkg: Reserving framebuffer at build Girish Pathak
2018-03-21 12:54   ` Evan Lloyd
2018-03-20 16:12 ` [PATCH v3 14/16] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver Girish Pathak
2018-03-21 12:54   ` Evan Lloyd
2018-04-23 11:07   ` Leif Lindholm
2018-03-20 16:12 ` [PATCH v3 15/16] ArmPkg: MTL Library interface and Null library implementation Girish Pathak
2018-03-21 12:54   ` Evan Lloyd
2018-04-23 11:11   ` Leif Lindholm
2018-03-20 16:12 ` [PATCH v3 16/16] ArmPkg: Introduce SCMI protocol Girish Pathak
2018-03-21 12:54   ` Evan Lloyd
2018-04-23 11:31   ` Leif Lindholm
2018-04-23 16:06     ` Girish Pathak
2018-04-23 16:22       ` Leif Lindholm
2018-04-23 16:49         ` Girish Pathak
2018-04-23 17:11 ` [PATCH v3 00/16] Update GOP Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR0801MB17715EFD3D16836F36162AC18BAA0@HE1PR0801MB1771.eurprd08.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox