From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a01:111:f400:fe1e::62f; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B78782214673D for ; Wed, 21 Mar 2018 06:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=obNjmuz80YnDeCar282XJPgnvsOZR+KBI5m8ViVDQ7Y=; b=SGR0xr3jrb8Hh4IZUdZjUcr+YDRm/mKZOo8Pnq1pEbeblpmzdhHzGrO9T+SjSodk/48v5B0eozPZqysSVWl55M9/1uh6rVmlRHO5+KBDuo0Qo9k3aXAk8veOyj9k30PPdzDT7YgrS20RJpdRa0oKXEa0bsHpMC17hnxn5YWsOnQ= Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com (10.168.150.14) by HE1PR0801MB1450.eurprd08.prod.outlook.com (10.167.190.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 13:23:27 +0000 Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3]) by HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3%17]) with mapi id 15.20.0588.017; Wed, 21 Mar 2018 13:23:27 +0000 From: Evan Lloyd To: "Desimone, Nathaniel L" , Sami Mujawar , "edk2-devel@lists.01.org" CC: nd , Stephanie Hughes-Fitt , "leif.lindholm@linaro.org" Thread-Topic: [edk2] [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core Thread-Index: AQHTv5Wa1KavkdtRnUm6Rl33GtV9xaPZsIQAgAD4zxA= Date: Wed, 21 Mar 2018 13:23:26 +0000 Message-ID: References: <20180319151847.85204-1-sami.mujawar@arm.com> <02A34F284D1DA44BB705E61F7180EF0A980EFDBB@ORSMSX114.amr.corp.intel.com> In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0A980EFDBB@ORSMSX114.amr.corp.intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0801MB1450; 7:jfspyGe9zuf1LK6QeuNsBHlI5B3pfh6iiU08WjS7hw0NCukkRWAo5O1P71891KhWGAYCrzN3I8UWw4ECL4LWmkllcoJ7/lL2WPGX5xnhxAiwOe085Bxuzqx1wffZkIVUXFjve6V8alr5PTHDu1sLzPWiYcHydxnkrO9WHhPaMA0DNJAVQx332MoWExZNI4jTJfSTlNgXJaRo2L8Vdqfi73BShhCXZNmvGzU0vzb/nFdjWCiNxkuq1lZVvFzNSDyv x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1cd8f025-c488-4e3a-766a-08d58f2eee3f x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB1450; x-ms-traffictypediagnostic: HE1PR0801MB1450: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(166708455590820)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501323)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0801MB1450; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB1450; x-forefront-prvs: 0618E4E7E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(396003)(346002)(366004)(39860400002)(376002)(13464003)(189003)(199004)(3280700002)(53936002)(33656002)(2501003)(2906002)(6506007)(8936002)(86362001)(106356001)(81156014)(305945005)(72206003)(53546011)(5250100002)(966005)(81166006)(55016002)(14454004)(68736007)(4326008)(25786009)(54906003)(6116002)(105586002)(3846002)(6306002)(8676002)(478600001)(9686003)(5660300001)(110136005)(7696005)(6246003)(7736002)(114624004)(186003)(2950100002)(99286004)(74316002)(3660700001)(2900100001)(26005)(316002)(59450400001)(97736004)(102836004)(76176011)(6436002)(66066001)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1450; H:HE1PR0801MB1771.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: vbHvnakgHADtrprumH0/5hbA4PkYbn6l67XhB2qCIvfKHuE0DAIbMI6GnzL8bwYbP8Sb8ZblRdK2Qs6qzVHOy7y8TVAn9sWklUS8gi9pWrAyxqDNH9YJL4taBKyuso1CpPDv5O8etbrFYYZ5WEXd+3fMHpPq7Omnz3pVhhoKv2IoXHtTsEm6NrglOeztNafrzlNLllrnpFghYi4Df4CJm6uannejrX0BvFg5gVU9uUYkb++th6V3Zq9ZCl570KDNDqff2ylalmVrOfAFejN7sUs2VDb2FBMiJr57VI1z4I0nEzLZyQwpfQsvb8oP+t+Uotk3QcCRLdnp+XsmQjLCbg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd8f025-c488-4e3a-766a-08d58f2eee3f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2018 13:23:26.9166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1450 Subject: Re: [staging/dynamictables PATCH 0/2] Dynamic Tables Framework core X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 13:17:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Nathaniel. > -----Original Message----- > From: edk2-devel On Behalf Of > Desimone, Nathaniel L > Sent: 20 March 2018 22:08 > To: Sami Mujawar ; edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt Fitt@arm.com>; leif.lindholm@linaro.org > Subject: Re: [edk2] [staging/dynamictables PATCH 0/2] Dynamic Tables > Framework core >=20 > Please don't use the name DynamicTableManagerDxe. What does it manage? > DynamicTables? How does adding the word "Manager" provide any useful > information for the reader? I recommend the name "DynamicAcpiTableDxe". [[Evan Lloyd]]=20 The problem with " DynamicAcpiTableDxe" is that the table manager can be us= ed for SMBIOS tables and even, should you be so inclined (perverse?) Device= Tree. The "DynamicTableManager" name relates to the fact that the compone= nt generates and submits tables (of whatever sort) as opposed to the Config= urationManager component which obtains, collates and provides the Configura= tion information. > It makes it clear this this code is specifically for generating ACPI tabl= es at > runtime (as opposed to some sort of unnamed table), and it removes the > unnecessary prose. [[Evan Lloyd]] As noted (and implied by the name), the code is not "specifi= cally for generating ACPI tables" That being said, we'd be happy to change the names if you can suggest somet= hing clearer. DynamicTablesDxe might do - the "Manager" part is, as you indicate, pretty = redundant. That implies changing ConfigurationManager to something like "DynamicConfig= ". Would that strike you as clearer? Regards, Evan >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Sami Mujawar > Sent: Monday, March 19, 2018 8:19 AM > To: edk2-devel@lists.01.org > Cc: nd@arm.com; leif.lindholm@linaro.org; Stephanie.Hughes- > Fitt@arm.com > Subject: [edk2] [staging/dynamictables PATCH 0/2] Dynamic Tables > Framework core >=20 > The Dynamic Tables Framework is a prototyped as a solution for > automatically generating the firmware tables based on hardware > description. >=20 > This patchset is the Dynamic Tables Framework core and implement the > generic/standard modules for dynamically generating ACPI 6.2 tables for > ARM platform. The platform specific modules are in the devel- > dynamictables branch in the edk2-platforms repository at: > https://github.com/tianocore/edk2-platforms/tree/devel-dynamictables >=20 > The first patch in this patchset 'MdePkg: SMMUv3 updates for IORT' > is a precursor for the Dynamic Tables Framework and has been submitted > independently to the edk2-devel mailing list where it is currently awaiti= ng > acceptance. >=20 > The sources for this patchset can be seen at: > https://github.com/samimujawar/edk2- > staging/tree/187_dynamictables_v1 >=20 > Sami Mujawar (2): > MdePkg: SMMUv3 updates for IORT table definitions > DynamicTablesPkg: Dynamic Tables Framework >=20 >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/Acpi > TableFactory.c | 226 +++ >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactor > y/DeviceTreeTableFactory.c | 225 +++ >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory. > h | 125 ++ >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory > Dxe.c | 84 + >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory > Dxe.inf | 59 + >=20 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/S > mbiosTableFactory.c | 226 +++ >=20 > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag > erDxe.c | 533 +++++ >=20 > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag > erDxe.inf | 48 + > DynamicTablesPkg/DynamicTables.dsc.inc > | 46 + > DynamicTablesPkg/DynamicTables.fdf.inc > | 35 + > DynamicTablesPkg/DynamicTablesPkg.dec > | 42 + > DynamicTablesPkg/Include/AcpiTableGenerator.h > | 282 +++ > DynamicTablesPkg/Include/ArmNameSpaceObjects.h > | 587 ++++++ > DynamicTablesPkg/Include/ConfigurationManagerHelper.h > | 119 ++ > DynamicTablesPkg/Include/ConfigurationManagerObject.h > | 176 ++ > DynamicTablesPkg/Include/DeviceTreeTableGenerator.h > | 182 ++ > DynamicTablesPkg/Include/Library/TableHelperLib.h > | 70 + > DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h > | 128 ++ > DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h > | 140 ++ > DynamicTablesPkg/Include/SmbiosTableGenerator.h > | 240 +++ > DynamicTablesPkg/Include/StandardNameSpaceObjects.h > | 116 ++ > DynamicTablesPkg/Include/TableGenerator.h > | 252 +++ >=20 > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf > | 47 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > | 440 +++++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf > | 41 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c > | 666 +++++++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf > | 41 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c > | 670 +++++++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf > | 41 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c > | 2046 ++++++++++++++++++++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.h > | 50 + >=20 > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.in > f | 41 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c > | 717 +++++++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf > | 41 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c > | 342 ++++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf > | 41 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c > | 142 ++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf > | 41 + > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c > | 324 ++++ > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > | 164 ++ > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf > | 35 + > MdePkg/Include/IndustryStandard/IoRemappingTable.h > | 11 +- > 42 files changed, 9881 insertions(+), 1 deletion(-) create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/AcpiTableFactory/Acpi > TableFactory.c > create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DeviceTreeTableFactor > y/DeviceTreeTableFactory.c > create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory. > h > create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory > Dxe.c > create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactory > Dxe.inf > create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/SmbiosTableFactory/S > mbiosTableFactory.c > create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag > erDxe.c > create mode 100644 > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManag > erDxe.inf > create mode 100644 DynamicTablesPkg/DynamicTables.dsc.inc > create mode 100644 DynamicTablesPkg/DynamicTables.fdf.inc > create mode 100644 DynamicTablesPkg/DynamicTablesPkg.dec > create mode 100644 DynamicTablesPkg/Include/AcpiTableGenerator.h > create mode 100644 DynamicTablesPkg/Include/ArmNameSpaceObjects.h > create mode 100644 > DynamicTablesPkg/Include/ConfigurationManagerHelper.h > create mode 100644 > DynamicTablesPkg/Include/ConfigurationManagerObject.h > create mode 100644 > DynamicTablesPkg/Include/DeviceTreeTableGenerator.h > create mode 100644 DynamicTablesPkg/Include/Library/TableHelperLib.h > create mode 100644 > DynamicTablesPkg/Include/Protocol/ConfigurationManagerProtocol.h > create mode 100644 > DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h > create mode 100644 DynamicTablesPkg/Include/SmbiosTableGenerator.h > create mode 100644 > DynamicTablesPkg/Include/StandardNameSpaceObjects.h > create mode 100644 DynamicTablesPkg/Include/TableGenerator.h > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/AcpiDbg2LibArm.inf > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/AcpiFadtLibArm.inf > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/AcpiGtdtLibArm.inf > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.h > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.in > f > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/AcpiRawLibArm.inf > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf > create mode 100644 > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c > create mode 100644 > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c > create mode 100644 > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelperLib.inf >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel