From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.0.78; helo=eur01-he1-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0078.outbound.protection.outlook.com [104.47.0.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7653C2095608D for ; Wed, 21 Mar 2018 05:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZiARwbhlXEClziLTXNeKhrzGTrZN19JlG4QT/0Z6ERE=; b=WIuUfa9xSwHOJerWVAkzca96Pta+/eLkG/rSwmVEIoyz7brYJhKTSSmuaScuqPotaqjyvhbvABFcXvgh3vVxlCesT5uSUm+VaysmwQ4NqV1WZophCePOUQydA3rT1GYBAOxwQ6K4+aCtAEuV41k2t+NU891IlWEWX7yECxSNQ/4= Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com (10.168.150.14) by HE1PR0801MB2074.eurprd08.prod.outlook.com (10.168.95.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 12:26:32 +0000 Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3]) by HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3%17]) with mapi id 15.20.0588.017; Wed, 21 Mar 2018 12:26:32 +0000 From: Evan Lloyd To: Girish Pathak , "edk2-devel@lists.01.org" CC: nd , Stephanie Hughes-Fitt , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH v3 08/16] ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP Thread-Index: AQHTwGZAEJM/4gqs2ESudA2lrQnJoaPantcA Date: Wed, 21 Mar 2018 12:26:31 +0000 Message-ID: References: <20180320161212.79120-1-girish.pathak@arm.com> <20180320161212.79120-9-girish.pathak@arm.com> In-Reply-To: <20180320161212.79120-9-girish.pathak@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0801MB2074; 7:5gHdF7wWwysuvPvo1KJqh+iHjjyZtlPHKraJKJIbT1bsSsPZam6KSFktPrpacluaRRGEqS4IEwGaptfnlsb4QL25giHhwmeAiRFxsISBwQ+UY9r3qL5OJiv4yMGdh9BXJ+nVaDCbu/d7dYxY83Ql2xvXG0hbDjHib5whmAN/o5R6BfvtNiiE4JQprFwI2i1/BhiuTTwyUi7LwaQxKO70dUYaNRSUQ6eNaw+AGQILv8pTYzeIF/WHgHrwx8fwOdND x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f7b7e140-760b-4448-a511-08d58f26fac8 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB2074; x-ms-traffictypediagnostic: HE1PR0801MB2074: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231221)(944501322)(52105095)(93006095)(93001095)(3002001)(6055026)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0801MB2074; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB2074; x-forefront-prvs: 0618E4E7E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(39860400002)(376002)(39380400002)(396003)(366004)(346002)(13464003)(189003)(199004)(106356001)(14454004)(9686003)(6306002)(575784001)(74316002)(229853002)(86362001)(105586002)(7696005)(66066001)(2906002)(55016002)(8676002)(72206003)(2950100002)(81156014)(81166006)(99286004)(966005)(76176011)(478600001)(3280700002)(305945005)(53936002)(6246003)(8936002)(3846002)(26005)(3660700001)(6116002)(2900100001)(25786009)(5660300001)(59450400001)(7736002)(6436002)(68736007)(102836004)(110136005)(6506007)(53546011)(54906003)(316002)(5250100002)(2501003)(33656002)(4326008)(97736004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB2074; H:HE1PR0801MB1771.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: kJ42+SE1XXBMze1leJ60G8xpjlMpSyyA14iqwPRun+8tjAxJLbBEJX5wqeFuEJjwpkoWWpKvNZp2y9zgDkrdEERErOCXrZ9UvKN0foLrl+IthCD8xhOepixT+A0AgBQV1HE17tKYbD+jP2p32kq7D8mLH8xggul14/ODlpmWnOla5CxJYU0cSkeaS98anhfQ+sx9Zso2qwtiTkE7otmVWWrReXin7bwaPBYWzSxb4PxGM3WbN3ISh7qMlY6/1nbDuY8K6vnGUbWpKhC9TsEEcgAoz9BiRNowrDakGzCiLXkvGveTbuXnInWZIPqMKDKGIthGM8OSAYl62n4DiYdt1A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7b7e140-760b-4448-a511-08d58f26fac8 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2018 12:26:32.0213 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2074 Subject: Re: [PATCH v3 08/16] ArmPlatformPkg: Implement LcdIdentify function for HDLCD GOP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 12:20:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Evan Lloyd > -----Original Message----- > From: edk2-devel On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt Fitt@arm.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org > Subject: [edk2] [PATCH v3 08/16] ArmPlatformPkg: Implement LcdIdentify > function for HDLCD GOP >=20 > From: Girish Pathak >=20 > LcdIdentify function does not currently check presence of HDLCD controlle= r. >=20 > Implement this functionality by reading HDLCD_REG_VERSION and checking > against the PRODUCT_ID field to detect presence of HDLCD controller. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > Reviewed-by: Ard Biesheuvel > --- > ArmPlatformPkg/Library/HdLcd/HdLcd.c | 8 +++++++- > ArmPlatformPkg/Library/HdLcd/HdLcd.h | 2 ++ > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.c > b/ArmPlatformPkg/Library/HdLcd/HdLcd.c > index > 28306c530e08b5e0fcef4308435045da3c9e093c..039048398c531ec944bc4 > b43a5551a554a368481 100644 > --- a/ArmPlatformPkg/Library/HdLcd/HdLcd.c > +++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.c > @@ -175,11 +175,17 @@ LcdShutdown ( >=20 > @retval EFI_SUCCESS Returns success if platform implements = a > HDLCD > controller. > + @retval EFI_NOT_FOUND HDLCD display controller not found on t= he > + platform. > **/ > EFI_STATUS > LcdIdentify ( > VOID > ) > { > - return EFI_SUCCESS; > + if ((MmioRead32 (HDLCD_REG_VERSION) >> 16) =3D=3D HDLCD_PRODUCT_ID) > { > + return EFI_SUCCESS; > + } > + > + return EFI_NOT_FOUND; > } > diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.h > b/ArmPlatformPkg/Library/HdLcd/HdLcd.h > index > cd2c0366c7b563d7fb313f82abeef7eb1aa3ef72..1efa78eedc3013b3ab4615 > 181a59c7d15b851ab5 100644 > --- a/ArmPlatformPkg/Library/HdLcd/HdLcd.h > +++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.h > @@ -85,4 +85,6 @@ > // Number of bytes per pixel > #define HDLCD_4BYTES_PER_PIXEL ((4 - 1) << 3) >=20 > +#define HDLCD_PRODUCT_ID 0x1CDC > + > #endif /* HDLCD_H_ */ > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel