From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.3.57; helo=eur03-am5-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30057.outbound.protection.outlook.com [40.107.3.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 30EB2225E966B for ; Wed, 21 Mar 2018 05:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wmrZBtWNTD9AY5WMvp9sVVXZ5MtUVUNnbs03tPjbBQ4=; b=NgXdY2kkub3HffBj0EFLh6FibNaaYIioC6YNxkBHbpXs/t+bTFdnSCEi3/xixgSRq/4MthC4K0VpgO6htgUUiTkRlZYsEMcW0JLvLA8IMv9SZw+cB4v5KiDfO+1VIF+1eRVI/HG8RpFgkuZLuOl8RBBedM9M5OCvy2FJuxYFvnU= Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com (10.168.150.14) by HE1PR0801MB2745.eurprd08.prod.outlook.com (10.169.123.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 12:54:09 +0000 Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3]) by HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3%17]) with mapi id 15.20.0588.017; Wed, 21 Mar 2018 12:54:09 +0000 From: Evan Lloyd To: Girish Pathak , "edk2-devel@lists.01.org" CC: nd , Stephanie Hughes-Fitt , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH v3 13/16] ArmPlatformPkg: Reserving framebuffer at build Thread-Index: AQHTwGZY1jZE6Jin7kqXkTRVfoApcKPappfw Date: Wed, 21 Mar 2018 12:54:09 +0000 Message-ID: References: <20180320161212.79120-1-girish.pathak@arm.com> <20180320161212.79120-14-girish.pathak@arm.com> In-Reply-To: <20180320161212.79120-14-girish.pathak@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0801MB2745; 7:WknnZxiRCgjM889SAkeqeTDncCLvZTT9L/ftOHtEXlXusZm/L50sr/FwI+wGA2bu3CYRFyDDE12oc6Moi4ATxMwm5kueyrGCkOwJ6ANMk6FgEbw4Wp3wlEpSaELDSx5ggumUDhE+FZ/Vxs2YWtDJoX8iQTFUbcCnR+zfMPyE114pcnM57afF/JTIpUoZBEGhytsYy8MuHbsnFcvuCWW6MhkBvHQKvJE3Zmgl/jtW+zUKLoGogQYrXr4bqexUytDw x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 40dda6ac-b7a3-4a77-27a9-08d58f2ad6ea x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB2745; x-ms-traffictypediagnostic: HE1PR0801MB2745: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231221)(944501323)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:HE1PR0801MB2745; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB2745; x-forefront-prvs: 0618E4E7E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39380400002)(396003)(39860400002)(366004)(189003)(13464003)(199004)(53936002)(105586002)(2900100001)(2501003)(5250100002)(86362001)(5660300001)(6246003)(54906003)(14454004)(110136005)(66066001)(478600001)(6436002)(966005)(68736007)(9686003)(72206003)(6306002)(33656002)(97736004)(74316002)(99286004)(76176011)(106356001)(6506007)(6116002)(3846002)(53546011)(229853002)(3280700002)(3660700001)(25786009)(7736002)(55016002)(4326008)(305945005)(7696005)(8936002)(575784001)(316002)(81166006)(81156014)(8676002)(26005)(2906002)(2950100002)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB2745; H:HE1PR0801MB1771.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ETCQRByM57wDk0M4ALCmghMiyNjE5gACkdv/6XerbUpmaWF9EL14pB+zTR7/7FP+FP5uqcDfTv8KkUNgvkUwTb8C0zi67IzXbg/clyrHxVYMUOu7WzndO8ihLEODfNMeI/Szv/XnuFBnk3fuCMLT+XDQQVhf0rE6j6KqBLn86uo0nupbnW0awg9tUANhIDGOfcoRUKjsc+iLqIcN80am56/6WiZaGrTDfsc5vniJ/ongDTHnqdOKyE/OeEBJ2uVUvVc9+QHhwiCrb8Indsdzdb7fs/0hySj09+ZCYMOgIV+Wo5mJDUqXVcdVxElNxluWdKwrEIKx3SP9qilQyvIGdA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40dda6ac-b7a3-4a77-27a9-08d58f2ad6ea X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2018 12:54:09.7986 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2745 Subject: Re: [PATCH v3 13/16] ArmPlatformPkg: Reserving framebuffer at build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 12:47:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Evan Lloyd > -----Original Message----- > From: edk2-devel On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt Fitt@arm.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org > Subject: [edk2] [PATCH v3 13/16] ArmPlatformPkg: Reserving framebuffer > at build >=20 > From: Girish Pathak >=20 > Currently framebuffer memory is either reserved in special VRAM or > dynamically allocated using boot services memory allocation functions. > When allocated using boot services calls the memory has to be allocated a= s > EfiBootServicesData. Unfortunately failures have been seen with this case= . > There is also an unfortunate lack of control on the placement of the > framebuffer. >=20 > This change introduces two PCDs, PcdArmLcdFrameBufferBase and > PcdArmLcdFrameBufferSize which enable build time reservation of the > framebuffer, avoiding the need to allocate dynamically. This allows the > framebuffer to appear as "I/O memory" outside of the normal RAM map, > which is similar to the "VRAM" case. >=20 > This change has no impact on current code, only enables the option of bui= ld > time reservation of framebuffers. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- > ArmPlatformPkg/ArmPlatformPkg.dec | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec > b/ArmPlatformPkg/ArmPlatformPkg.dec > index > 5231ea822f05c2f281a6190d6eae0fc7d0bc0cb3..5c702718a78a78e6c67ab > 407e198382e0a0df4be 100644 > --- a/ArmPlatformPkg/ArmPlatformPkg.dec > +++ b/ArmPlatformPkg/ArmPlatformPkg.dec > @@ -93,6 +93,11 @@ [PcdsFixedAtBuild.common] >=20 > gArmPlatformTokenSpaceGuid.PcdPL111LcdBase|0x0|UINT32|0x0000002 > 6 >=20 > gArmPlatformTokenSpaceGuid.PcdArmHdLcdBase|0x0|UINT32|0x0000002 > 7 >=20 > + ## Default size for display modes upto 1920x1080 (1920 * 1080 * 4 > + Bytes Per Pixel) > + > + > gArmPlatformTokenSpaceGuid.PcdArmLcdDdrFrameBufferSize|0x7E9000| > UINT32 > + |0x00000043 ## If set, framebuffer memory will be reserved and > mapped > + in the system RAM > + > + > gArmPlatformTokenSpaceGuid.PcdArmLcdDdrFrameBufferBase|0x0|UINT6 > 4|0x00 > + 000044 > + > ## PL180 MCI >=20 > gArmPlatformTokenSpaceGuid.PcdPL180SysMciRegAddress|0x00000000| > UINT32|0x00000028 >=20 > gArmPlatformTokenSpaceGuid.PcdPL180MciBaseAddress|0x00000000|UI > NT32|0x00000029 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel