From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.3.68; helo=eur03-am5-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30068.outbound.protection.outlook.com [40.107.3.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF37222571B52 for ; Wed, 21 Mar 2018 05:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=60U7UAHAakQuQNbhgeOnKzLLN4fDwjAXdS2B20OOXko=; b=kWFz2FLBBpXdPR0Ie6+OHQNoKjpy7xa9JX+7n8xWpJlHwkB9rHJYgwLqOHaXr9Zt6AlBqPp3zSmv4QFwj/RxO5WK1kXuolR2im3kND63SjDyQLzFzm9rOdDc/mKqUka0ZPZxsTZfuXknJGLexQ9xqUJGnAUxV04X+o9DJEBXUO8= Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com (10.168.150.14) by HE1PR0801MB1932.eurprd08.prod.outlook.com (10.168.94.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 12:53:52 +0000 Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3]) by HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3%17]) with mapi id 15.20.0588.017; Wed, 21 Mar 2018 12:53:52 +0000 From: Evan Lloyd To: Girish Pathak , "edk2-devel@lists.01.org" CC: nd , Stephanie Hughes-Fitt , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH v3 04/16] ArmPlatformPkg: Tidy Lcd code: Updated comments Thread-Index: AQHTwGZR0UyKEQ+qY0So10SK6lFBh6PapoKw Date: Wed, 21 Mar 2018 12:53:52 +0000 Message-ID: References: <20180320161212.79120-1-girish.pathak@arm.com> <20180320161212.79120-5-girish.pathak@arm.com> In-Reply-To: <20180320161212.79120-5-girish.pathak@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0801MB1932; 7:Fce+e4uf8RJL0NrIdW7xn7Uo3UGYBG1d3FzPENKtybEDLqMq/5N4wE08Ak2D1fyVAJmAGCX5CIRNTzG1cqcGmnFGmTuKzzwRu/yVDOMU3psC9wilWID2miorAqLq67xWoBLrbBjoO6rGDsJRHO/GsNcWsk0GYTQ36AVGd1vPmGocqRdIhyF4yZh9PNwBSfR46MtBGa7d/uOJVx1gyhzKzW8OiNGBzMsav+UIXwQW32a7oSB9NqdsgzHOVCQuN7zk x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fa84d3b1-04dd-48d1-c3be-08d58f2accb2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB1932; x-ms-traffictypediagnostic: HE1PR0801MB1932: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231221)(944501323)(52105095)(93006095)(93001095)(3002001)(6055026)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0801MB1932; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB1932; x-forefront-prvs: 0618E4E7E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(396003)(366004)(39380400002)(39860400002)(346002)(189003)(199004)(13464003)(305945005)(7736002)(86362001)(25786009)(2900100001)(74316002)(76176011)(7696005)(2420400007)(575784001)(15650500001)(9686003)(14454004)(68736007)(966005)(99286004)(6116002)(72206003)(54906003)(3846002)(2501003)(5250100002)(81156014)(8676002)(229853002)(81166006)(110136005)(4326008)(7110500001)(53376002)(53936002)(6246003)(2950100002)(66066001)(6436002)(2906002)(6306002)(316002)(53946003)(55016002)(478600001)(15188155005)(5660300001)(10710500007)(33656002)(105586002)(106356001)(97736004)(8936002)(3660700001)(102836004)(6506007)(16799955002)(3280700002)(53546011)(26005)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1932; H:HE1PR0801MB1771.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NJ/I5WLZq3v/3tv14cIwkRg5K8lC4rRZmwHZIrQkjIP82WnfHDEK6d3rE+TJ7xMWiKlHg01xZbliOWbSvK4XqtECly+nwIO8BGZsUF3sr0b6UuinxRDQQn+8oZas5ZxQrdN+5q6o+nps67msfLCxbzn4aPTU0Jq9vhOChOS9dCMs6l6q/Qm8ANZ3cB7Zkn/SvVKmmgUZI/bp5UH4f+t9HBBJz7KVBnc0O/njmud2nuE8/DHhodP8eziqfWWPNN8Vkdkd+CdJ7lKf/7Wi/vA13Tw30fwmCWVZck4BzYf5TPmHOaGeWbm5gUtOiNfcxoUDX3Wh/PA9om3NzjiuEZaF2Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa84d3b1-04dd-48d1-c3be-08d58f2accb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2018 12:53:52.6740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1932 Subject: Re: [PATCH v3 04/16] ArmPlatformPkg: Tidy Lcd code: Updated comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 12:47:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Evan Lloyd > -----Original Message----- > From: edk2-devel On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt Fitt@arm.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org > Subject: [edk2] [PATCH v3 04/16] ArmPlatformPkg: Tidy Lcd code: Updated > comments >=20 > From: Girish Pathak >=20 > There is no functional modification in this change some comments are > modified and a few new comments are added. > This is to prevent mixing formatting changes with functional changes. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- >=20 > Notes: > v3: > - Propagated comments to LcdPlatformNullLib >=20 > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.c > | 20 ++--- > ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 92 > +++++++++++++++----- > ArmPlatformPkg/Library/HdLcd/HdLcd.c | 26 = +++++- > ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c | 65 > ++++++++++++++ > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 24 = ++++- > 5 files changed, 189 insertions(+), 38 deletions(-) >=20 > diff --git > a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe. > c > b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe. > c > index > 905eb26ee01b5037dfbaf3c054a62593837c8b5f..872361cd23fbdf52c5f128 > d0e172701e76d832b2 100644 > --- > a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe. > c > +++ > b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe. > c > @@ -1,13 +1,14 @@ > /** @file > + This file implements the Graphics Output protocol for Arm platforms >=20 > - Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
> - This program and the accompanying materials > - are licensed and made available under the terms and conditions of the B= SD > License > - which accompanies this distribution. The full text of the license may = be > found at > - http://opensource.org/licenses/bsd-license.php > + Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
This > + program and the accompanying materials are licensed and made > + available under the terms and conditions of the BSD License which > + accompanies this distribution. The full text of the license may be > + found at http://opensource.org/licenses/bsd-license.php >=20 > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. >=20 > **/ >=20 > @@ -22,11 +23,6 @@ >=20 > #include "LcdGraphicsOutputDxe.h" >=20 > -/** This file implements the Graphics Output protocol on > ArmVersatileExpress > - using the Lcd controller > - > -**/ > - > // > // Global variables > // > diff --git a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h > b/ArmPlatformPkg/Include/Library/LcdPlatformLib.h > index > 3d13e417972c67cc51ae4410efd548053511e5d1..e51e78640ae7b1acd51a > c333ba3faa8c78aea5a5 100644 > --- a/ArmPlatformPkg/Include/Library/LcdPlatformLib.h > +++ b/ArmPlatformPkg/Include/Library/LcdPlatformLib.h > @@ -18,9 +18,7 @@ >=20 > #define LCD_VRAM_SIZE SIZE_8MB >=20 > -// > // Modes definitions > -// > #define VGA 0 > #define SVGA 1 > #define XGA 2 > @@ -29,9 +27,7 @@ > #define UXGA 5 > #define HD 6 >=20 > -// > // VGA Mode: 640 x 480 > -// > #define VGA_H_RES_PIXELS 640 > #define VGA_V_RES_PIXELS 480 > #define VGA_OSC_FREQUENCY 23750000 /* 0x016A6570 */ > @@ -44,9 +40,7 @@ > #define VGA_V_FRONT_PORCH ( 3 - 1) > #define VGA_V_BACK_PORCH ( 13 - 1) >=20 > -// > // SVGA Mode: 800 x 600 > -// > #define SVGA_H_RES_PIXELS 800 > #define SVGA_V_RES_PIXELS 600 > #define SVGA_OSC_FREQUENCY 38250000 /* 0x0247A610 */ > @@ -59,9 +53,7 @@ > #define SVGA_V_FRONT_PORCH ( 3 - 1) > #define SVGA_V_BACK_PORCH ( 17 - 1) >=20 > -// > // XGA Mode: 1024 x 768 > -// > #define XGA_H_RES_PIXELS 1024 > #define XGA_V_RES_PIXELS 768 > #define XGA_OSC_FREQUENCY 63500000 /* 0x03C8EEE0 */ > @@ -74,9 +66,7 @@ > #define XGA_V_FRONT_PORCH ( 3 - 1) > #define XGA_V_BACK_PORCH ( 23 - 1) >=20 > -// > // SXGA Mode: 1280 x 1024 > -// > #define SXGA_H_RES_PIXELS 1280 > #define SXGA_V_RES_PIXELS 1024 > #define SXGA_OSC_FREQUENCY 109000000 /* 0x067F3540 */ > @@ -89,9 +79,7 @@ > #define SXGA_V_FRONT_PORCH ( 3 - 1) > #define SXGA_V_BACK_PORCH ( 29 - 1) >=20 > -// > // WSXGA+ Mode: 1680 x 1050 > -// > #define WSXGA_H_RES_PIXELS 1680 > #define WSXGA_V_RES_PIXELS 1050 > #define WSXGA_OSC_FREQUENCY 147000000 /* 0x08C30AC0 */ > @@ -104,9 +92,7 @@ > #define WSXGA_V_FRONT_PORCH ( 4 - 1) > #define WSXGA_V_BACK_PORCH ( 41 - 1) >=20 > -// > // UXGA Mode: 1600 x 1200 > -// > #define UXGA_H_RES_PIXELS 1600 > #define UXGA_V_RES_PIXELS 1200 > #define UXGA_OSC_FREQUENCY 161000000 /* 0x0998AA40 */ > @@ -119,9 +105,7 @@ > #define UXGA_V_FRONT_PORCH ( 3 - 1) > #define UXGA_V_BACK_PORCH ( 38 - 1) >=20 > -// > // HD Mode: 1920 x 1080 > -// > #define HD_H_RES_PIXELS 1920 > #define HD_V_RES_PIXELS 1080 > #define HD_OSC_FREQUENCY 165000000 /* 0x09D5B340 */ > @@ -134,10 +118,7 @@ > #define HD_V_FRONT_PORCH ( 3 - 1) > #define HD_V_BACK_PORCH ( 32 - 1) >=20 > -// > // Colour Masks > -// > - > #define LCD_24BPP_RED_MASK 0x00FF0000 > #define LCD_24BPP_GREEN_MASK 0x0000FF00 > #define LCD_24BPP_BLUE_MASK 0x000000FF > @@ -158,7 +139,7 @@ > #define LCD_12BPP_444_BLUE_MASK 0x0000000F > #define LCD_12BPP_444_RESERVED_MASK 0x0000F000 >=20 > -/** The enumeration indexes maps the PL111 LcdBpp values used in the > LCD Control > +/** The enumeration maps the PL111 LcdBpp values used in the LCD > +Control > Register > **/ > typedef enum { > @@ -172,33 +153,94 @@ typedef enum { > LCD_BITS_PER_PIXEL_12_444 > } LCD_BPP; >=20 > +/** Platform related initialization function. > + > + @param[in] Handle Handle to the LCD device instance. > + > + @retval EFI_SUCCESS Plaform library initialized successfull= y. > + @retval !(EFI_SUCCESS) Other errors. > +**/ > EFI_STATUS > LcdPlatformInitializeDisplay ( > IN EFI_HANDLE Handle > ); >=20 > +/** Allocate VRAM memory in DRAM for the framebuffer > + (unless it is reserved already). > + > + The allocated address can be used to set the framebuffer. > + > + @param[out] VramBaseAddress A pointer to the framebuffer address. > + @param[out] VramSize A pointer to the size of the frame > + buffer in bytes > + > + @retval EFI_SUCCESS Frame buffer memory allocated success= fully. > + @retval !(EFI_SUCCESS) Other errors. > +**/ > EFI_STATUS > LcdPlatformGetVram ( > OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, > OUT UINTN* VramSize > ); >=20 > +/** Return total number of modes supported. > + > + Note: Valid mode numbers are 0 to MaxMode - 1 See Section 12.9 of > + the UEFI Specification 2.7 > + > + @retval UINT32 Mode Number. > +**/ > UINT32 > LcdPlatformGetMaxMode ( > VOID > ); >=20 > +/** Set the requested display mode. > + > + @param[in] ModeNumber Mode Number. > + > + @retval EFI_SUCCESS Mode set successfully. > + @retval EFI_INVALID_PARAMETER Requested mode not found. > + @retval !(EFI_SUCCESS) Other errors. > +**/ > EFI_STATUS > LcdPlatformSetMode ( > IN UINT32 ModeNumber > ); >=20 > +/** Return information for the requested mode number. > + > + @param[in] ModeNumber Mode Number. > + @param[out] Info Pointer for returned mode information > + (on success). > + > + @retval EFI_SUCCESS Mode information for the requested mod= e > + returned successfully. > + @retval EFI_INVALID_PARAMETER Requested mode not found. > +**/ > EFI_STATUS > LcdPlatformQueryMode ( > IN UINT32 ModeNumber, > OUT EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *Info > ); >=20 > +/** Return display timing information for the requested mode number. > + > + @param[in] ModeNumber Mode Number. > + > + @param[out] HRes Pointer to horizontal resolution. > + @param[out] HSync Pointer to horizontal sync width. > + @param[out] HBackPorch Pointer to horizontal back porch. > + @param[out] HFrontPorch Pointer to horizontal front porch. > + @param[out] VRes Pointer to vertical resolution. > + @param[out] VSync Pointer to vertical sync width. > + @param[out] VBackPorch Pointer to vertical back porch. > + @param[out] VFrontPorch Pointer to vertical front porch. > + > + @retval EFI_SUCCESS Display timing information for the req= uested > + mode returned successfully. > + @retval EFI_INVALID_PARAMETER Requested mode not found. > +**/ > EFI_STATUS > LcdPlatformGetTimings ( > IN UINT32 ModeNumber, > @@ -212,6 +254,16 @@ LcdPlatformGetTimings ( > OUT UINT32* VFrontPorch > ); >=20 > +/** Return bits per pixel information for a mode number. > + > + @param[in] ModeNumber Mode Number. > + > + @param[out] Bpp Pointer to value bits per pixel inform= ation. > + > + @retval EFI_SUCCESS Bit per pixel information for the requ= ested > + mode returned successfully. > + @retval EFI_INVALID_PARAMETER Requested mode not found. > +**/ > EFI_STATUS > LcdPlatformGetBpp ( > IN UINT32 ModeNumber, > diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.c > b/ArmPlatformPkg/Library/HdLcd/HdLcd.c > index > 2cd1be9d255dd5734176d752d60f06f11a047fcb..be4ccfdc1f421060faec79 > 2c8e8acfcfb3232014 100644 > --- a/ArmPlatformPkg/Library/HdLcd/HdLcd.c > +++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.c > @@ -1,4 +1,5 @@ > /** @file > + This file contains the platform independent parts of HdLcd >=20 > Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
>=20 > @@ -21,10 +22,6 @@ >=20 > #include "HdLcd.h" >=20 > -/** This file contains all the bits of the Lcd that are > - platform independent. > -**/ > - > STATIC > UINTN > GetBytesPerPixel ( > @@ -51,6 +48,12 @@ GetBytesPerPixel ( > } > } >=20 > +/** Initialize display. > + > + @param[in] VramBaseAddress Address of the framebuffer. > + > + @retval EFI_SUCCESS Display initialization successful. > +**/ > EFI_STATUS > LcdInitialize ( > IN EFI_PHYSICAL_ADDRESS VramBaseAddress > @@ -82,6 +85,14 @@ LcdInitialize ( > return EFI_SUCCESS; > } >=20 > +/** Set requested mode of the display. > + > + @param[in] ModeNumber Display mode number. > + > + @retval EFI_SUCCESS Display mode set successfully. > + @retval EFI_DEVICE_ERROR Reurns an error if display timing > + information is not available. > +**/ > EFI_STATUS > LcdSetMode ( > IN UINT32 ModeNumber > @@ -150,6 +161,8 @@ LcdSetMode ( > return EFI_SUCCESS; > } >=20 > +/** De-initializes the display. > +**/ > VOID > LcdShutdown ( > VOID > @@ -159,6 +172,11 @@ LcdShutdown ( > MmioWrite32 (HDLCD_REG_COMMAND, HDLCD_DISABLE); } >=20 > +/** Check for presence of HDLCD. > + > + @retval EFI_SUCCESS Returns success if platform implements = a > HDLCD > + controller. > +**/ > EFI_STATUS > LcdIdentify ( > VOID > diff --git > a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c > b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c > index > b78d9a3bbd3e1fac4238f2be961a343020360a32..b76894c534fb413d87c7 > 7c528f0bb7d49862c78f 100644 > --- a/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c > +++ b/ArmPlatformPkg/Library/LcdPlatformNullLib/LcdPlatformNullLib.c > @@ -1,6 +1,7 @@ > /** @file >=20 > Copyright (c) 2017, Linaro, Ltd. All rights reserved. > + Copyright (c) 2018, Arm Limited. All rights reserved. >=20 > This program and the accompanying materials > are licensed and made available under the terms and conditions of the > BSD License @@ -17,6 +18,12 @@ #include > #include >=20 > +/** Platform related initialization function. > + > + @param[in] Handle Handle to the LCD device instance. > + > + @retval EFI_UNSUPPORTED Interface is not supported. > +**/ > EFI_STATUS > LcdPlatformInitializeDisplay ( > IN EFI_HANDLE Handle > @@ -26,6 +33,17 @@ LcdPlatformInitializeDisplay ( > return EFI_UNSUPPORTED; > } >=20 > +/** Allocate VRAM memory in DRAM for the framebuffer > + (unless it is reserved already). > + > + The allocated address can be used to set the framebuffer. > + > + @param[out] VramBaseAddress A pointer to the framebuffer address. > + @param[out] VramSize A pointer to the size of the frame > + buffer in bytes > + > + @retval EFI_UNSUPPORTED Interface is not supported. > +**/ > EFI_STATUS > LcdPlatformGetVram ( > OUT EFI_PHYSICAL_ADDRESS* VramBaseAddress, > @@ -36,6 +54,14 @@ LcdPlatformGetVram ( > return EFI_UNSUPPORTED; > } >=20 > +/** Return total number of modes supported. > + > + Note: Valid mode numbers are 0 to MaxMode - 1 See Section 12.9 of > + the UEFI Specification 2.7 > + > + @retval UINT32 Zero number of modes supported > + in a NULL library implementation. > +**/ > UINT32 > LcdPlatformGetMaxMode ( > VOID > @@ -45,6 +71,12 @@ LcdPlatformGetMaxMode ( > return 0; > } >=20 > +/** Set the requested display mode. > + > + @param[in] ModeNumber Mode Number. > + > + @retval EFI_UNSUPPORTED Interface is not supported. > +**/ > EFI_STATUS > LcdPlatformSetMode ( > IN UINT32 ModeNumber > @@ -54,6 +86,15 @@ LcdPlatformSetMode ( > return EFI_UNSUPPORTED; > } >=20 > +/** Return information for the requested mode number. > + > + @param[in] ModeNumber Mode Number. > + @param[out] Info Pointer for returned mode information > + (on success). > + > + @retval EFI_UNSUPPORTED Interface is not supported. > + > +**/ > EFI_STATUS > LcdPlatformQueryMode ( > IN UINT32 ModeNumber, > @@ -64,6 +105,21 @@ LcdPlatformQueryMode ( > return EFI_UNSUPPORTED; > } >=20 > +/** Return display timing information for the requested mode number. > + > + @param[in] ModeNumber Mode Number. > + > + @param[out] HRes Pointer to horizontal resolution. > + @param[out] HSync Pointer to horizontal sync width. > + @param[out] HBackPorch Pointer to horizontal back porch. > + @param[out] HFrontPorch Pointer to horizontal front porch. > + @param[out] VRes Pointer to vertical resolution. > + @param[out] VSync Pointer to vertical sync width. > + @param[out] VBackPorch Pointer to vertical back porch. > + @param[out] VFrontPorch Pointer to vertical front porch. > + > + @retval EFI_UNSUPPORTED Interface is not supported. > +**/ > EFI_STATUS > LcdPlatformGetTimings ( > IN UINT32 ModeNumber, > @@ -81,6 +137,15 @@ LcdPlatformGetTimings ( > return EFI_UNSUPPORTED; > } >=20 > +/** Return bits per pixel information for a mode number. > + > + @param[in] ModeNumber Mode Number. > + > + @param[out] Bpp Pointer to value bits per pixel inform= ation. > + > + @retval EFI_UNSUPPORTED Interface is not supported. > + > +**/ > EFI_STATUS > LcdPlatformGetBpp ( > IN UINT32 ModeNumber, > diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > index > 3f3f7019f1d252995eab6d8c3d49db8be8e09e40..ccd7a4d1d43ad5c2f4956 > 83ac68236e17f3b55a5 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > @@ -1,4 +1,5 @@ > /** @file > + This file contains the platform independent parts of PL111Lcd >=20 > Copyright (c) 2011-2018, ARM Ltd. All rights reserved.
>=20 > @@ -19,9 +20,12 @@ >=20 > #include "PL111Lcd.h" >=20 > -/** This file contains all the bits of the PL111 that are > - platform independent. > +/** Check for presence of PL111. >=20 > + @retval EFI_SUCCESS Returns success if platform implements a > + PL111 controller. > + > + @retval EFI_NOT_FOUND PL111 display controller not found the > plaform. > **/ > EFI_STATUS > LcdIdentify ( > @@ -45,6 +49,12 @@ LcdIdentify ( > return EFI_NOT_FOUND; > } >=20 > +/** Initialize display. > + > + @param[in] VramBaseAddress Address of the framebuffer. > + > + @retval EFI_SUCCESS Initialization of display successful. > +**/ > EFI_STATUS > LcdInitialize ( > IN EFI_PHYSICAL_ADDRESS VramBaseAddress > @@ -60,6 +70,14 @@ LcdInitialize ( > return EFI_SUCCESS; > } >=20 > +/** Set requested mode of the display. > + > + @param[in] ModeNumbe Display mode number. > + > + @retval EFI_SUCCESS Display mode set successfuly. > + @retval EFI_DEVICE_ERROR It returns an error if display timing > + information is not available. > +**/ > EFI_STATUS > LcdSetMode ( > IN UINT32 ModeNumber > @@ -130,6 +148,8 @@ LcdSetMode ( > return EFI_SUCCESS; > } >=20 > +/** De-initializes the display. > +*/ > VOID > LcdShutdown ( > VOID > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel