From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.3.86; helo=eur03-am5-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30086.outbound.protection.outlook.com [40.107.3.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 63180225E966B for ; Wed, 21 Mar 2018 05:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LfYrT9bUHyv6tWOZHPAhKivVfDnPSD0akhgyB6srW6I=; b=JO2tVTQGxXTT4RRfbZMpDB5hlR+xWc2O5coC5ZU13RU42D1wYaTrI2cpY7s7mFUT9S91IRXYAOkAGZO6yH4BSuKq/VA2PdMOsN70/qL5e/2ft8P8A0HrRlf9RUXukvBFO0FS6YtkWQRlon3dKy13INndWGzMzlgZyK9F5eamEvo= Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com (10.168.150.14) by HE1PR0801MB1786.eurprd08.prod.outlook.com (10.168.150.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 12:53:11 +0000 Received: from HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3]) by HE1PR0801MB1771.eurprd08.prod.outlook.com ([fe80::69cc:3ecf:9c8c:f5a3%17]) with mapi id 15.20.0588.017; Wed, 21 Mar 2018 12:53:11 +0000 From: Evan Lloyd To: Girish Pathak , "edk2-devel@lists.01.org" CC: nd , Stephanie Hughes-Fitt , "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH v3 05/16] ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS Thread-Index: AQHTwGZJQiQkj+DEUEan/OGXSI6RWaPaplHA Date: Wed, 21 Mar 2018 12:53:11 +0000 Message-ID: References: <20180320161212.79120-1-girish.pathak@arm.com> <20180320161212.79120-6-girish.pathak@arm.com> In-Reply-To: <20180320161212.79120-6-girish.pathak@arm.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0801MB1786; 7:cyTfwGCP24AEdD/RBHdIG/UoRX0tOCOyQ0D9qzLtudrokigluBLuLFG5B+RRH8vnlSeqo84w3CkYEPdsHFcCvmqyKMF3TwQz20GfTWmrn/7qRh8MhP+xCCHbLLD4BuYtar/FyyjWK75BdeBZ/OITnIhDAfKT9LoACBhiKaACktGZIY52EUspih3Tq9C4euVcnANcZqI/tu8oZqEizISEp54s7Z2cJCNuinHEeKYPpDQOQVI2YFBmFSBnJh0wKLzN x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4e923931-2af8-43ec-e32f-08d58f2ab436 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7153060)(7193020); SRVR:HE1PR0801MB1786; x-ms-traffictypediagnostic: HE1PR0801MB1786: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501323)(52105095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0801MB1786; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0801MB1786; x-forefront-prvs: 0618E4E7E1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(346002)(376002)(396003)(39860400002)(13464003)(189003)(199004)(2950100002)(97736004)(105586002)(3280700002)(2906002)(25786009)(81156014)(99286004)(316002)(59450400001)(7696005)(966005)(26005)(110136005)(14454004)(478600001)(76176011)(6506007)(102836004)(72206003)(2900100001)(8676002)(54906003)(81166006)(5660300001)(86362001)(5250100002)(4326008)(33656002)(6246003)(6436002)(9686003)(229853002)(53546011)(2501003)(575784001)(3846002)(106356001)(15650500001)(3660700001)(6116002)(66066001)(53936002)(7736002)(68736007)(305945005)(55016002)(6306002)(8936002)(74316002)(19627235001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0801MB1786; H:HE1PR0801MB1771.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: qpRi1PDcEEKn2Mtw+tjoWAXasCCtUB9Sr8U4mpbBwo3xsq+zbvMf4aS/MLGdtI5YQ0n3bMiJqsmh0hDtkpTZu0GgdYs4kyewRFK4Zw7Otoknm2vdpw2zisWuBnDRsgp3KWjaEVDyqMJV5duuHtKEmvP8TSWnQOinZNryH2IRcYCkGSqr7neX5l7Fddk4YRdClNQfj+yv+EcR4fL+ED8otmYk4UEaKINb3nucoQB0M2ceTXaTDDBtfar5N9Y14eAE0yNGq4OwHUqz0pG2M8z/IAcOpPbpJDqzSH6dMLftcBdxwUtWNOmoa0EEHxHIwpA/C8tzAqiqsiYTnpMPyz1DJA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e923931-2af8-43ec-e32f-08d58f2ab436 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2018 12:53:11.5968 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1786 Subject: Re: [PATCH v3 05/16] ArmPlatformPkg: HDLCD and PL111: Update debug ASSERTS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 12:46:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Evan Lloyd > -----Original Message----- > From: edk2-devel On Behalf Of Girish > Pathak > Sent: 20 March 2018 16:12 > To: edk2-devel@lists.01.org > Cc: nd ; Stephanie Hughes-Fitt Fitt@arm.com>; leif.lindholm@linaro.org; ard.biesheuvel@linaro.org > Subject: [edk2] [PATCH v3 05/16] ArmPlatformPkg: HDLCD and PL111: > Update debug ASSERTS >=20 > From: Girish Pathak >=20 > This change moves some ASSERTs in error handling code to improve > efficiency in DEBUG build. This change also removes redundant error code > returns. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd > --- >=20 > Notes: > v3: > - Reverted to ASSERT_EFI_ERROR (Status) from ASSERT (FALSE) >=20 > ArmPlatformPkg/Library/HdLcd/HdLcd.c | 11 +++++------ > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 12 ++++++------ > 2 files changed, 11 insertions(+), 12 deletions(-) >=20 > diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.c > b/ArmPlatformPkg/Library/HdLcd/HdLcd.c > index > be4ccfdc1f421060faec792c8e8acfcfb3232014..28306c530e08b5e0fcef430 > 8435045da3c9e093c 100644 > --- a/ArmPlatformPkg/Library/HdLcd/HdLcd.c > +++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.c > @@ -90,8 +90,7 @@ LcdInitialize ( > @param[in] ModeNumber Display mode number. >=20 > @retval EFI_SUCCESS Display mode set successfully. > - @retval EFI_DEVICE_ERROR Reurns an error if display timing > - information is not available. > + @retval !(EFI_SUCCESS) Other errors. > **/ > EFI_STATUS > LcdSetMode ( > @@ -122,15 +121,15 @@ LcdSetMode ( > &VBackPorch, > &VFrontPorch > ); > - ASSERT_EFI_ERROR (Status); > if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > + ASSERT_EFI_ERROR (Status); > + return Status; > } >=20 > Status =3D LcdPlatformGetBpp (ModeNumber, &LcdBpp); > - ASSERT_EFI_ERROR (Status); > if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > + ASSERT_EFI_ERROR (Status); > + return Status; > } >=20 > BytesPerPixel =3D GetBytesPerPixel (LcdBpp); diff --git > a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > index > ccd7a4d1d43ad5c2f495683ac68236e17f3b55a5..cb64c57dd79f3bb1345e4 > d3dbda7f5b3ce859f40 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > @@ -75,8 +75,8 @@ LcdInitialize ( > @param[in] ModeNumbe Display mode number. >=20 > @retval EFI_SUCCESS Display mode set successfuly. > - @retval EFI_DEVICE_ERROR It returns an error if display timing > - information is not available. > + @retval !(EFI_SUCCESS) Other errors. > + > **/ > EFI_STATUS > LcdSetMode ( > @@ -107,15 +107,15 @@ LcdSetMode ( > &VBackPorch, > &VFrontPorch > ); > - ASSERT_EFI_ERROR (Status); > if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > + ASSERT_EFI_ERROR (Status); > + return Status; > } >=20 > Status =3D LcdPlatformGetBpp (ModeNumber, &LcdBpp); > - ASSERT_EFI_ERROR (Status); > if (EFI_ERROR (Status)) { > - return EFI_DEVICE_ERROR; > + ASSERT_EFI_ERROR (Status); > + return Status; > } >=20 > // Disable the CLCD_LcdEn bit > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel