From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.77]) by mx.groups.io with SMTP id smtpd.web09.8527.1579513579947263127 for ; Mon, 20 Jan 2020 01:46:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=ChTEVn4T; spf=pass (domain: arm.com, ip: 40.107.0.77, mailfrom: krzysztof.koch@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eaxEJh9AFBk0IzKJXZDzVoTqpfOElMkfXWlo1/iVCh0=; b=ChTEVn4TnU3hfbGiyrPiJvvc4qjHJYq0XCu7+w7bRo94XByssZ8NnQYk45PtC7VEadyaWlq1fuEDX2aZty7UpwVZdzAMpe60RFgT31JzuGCBwgiO+QLWntFQL2RgSJRwY1N3SrYiVi51qKSQKEro/lhNDg06sZgzvgbZfxgz+Q4= Received: from VE1PR08CA0005.eurprd08.prod.outlook.com (2603:10a6:803:104::18) by DB8PR08MB3948.eurprd08.prod.outlook.com (2603:10a6:10:a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.19; Mon, 20 Jan 2020 09:46:17 +0000 Received: from AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by VE1PR08CA0005.outlook.office365.com (2603:10a6:803:104::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18 via Frontend Transport; Mon, 20 Jan 2020 09:46:16 +0000 Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT031.mail.protection.outlook.com (10.152.16.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.23 via Frontend Transport; Mon, 20 Jan 2020 09:46:16 +0000 Received: ("Tessian outbound 121a58c8f9bf:v40"); Mon, 20 Jan 2020 09:46:16 +0000 X-CR-MTA-TID: 64aa7808 Received: from 39bb1260a9cb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A6DEBF51-93B1-416B-845D-1DB9E9D49B44.1; Mon, 20 Jan 2020 09:46:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 39bb1260a9cb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 20 Jan 2020 09:46:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Agjnv0IuGRGqu5YRsZ3wdXii0xmVNSmbeLeIWjrW7/8f6ify3fbtpg10f6z8sN5hukty4LqxKJCaTXOVuwIGrioHfJeZgXA3FL1lYYrMPTrY+Uj3xIHzMNdihL4iTra6iqsZ11uzyDgvQi3rDQ3RjiEFNZCIS/uYBcvfa4SgCWhUKwp6JrlKwdTFuvCKv/9xfhzTWnnySpNfSRXroz8V5XWwN/9m1CUspC8ZxUcP+Z2RODNTiH1N6GD0SpKZqsMzDYm4t/SYxpyqzChWTSmYNZhqzVC8rRgxymghNBGEqVfAYwcHy+KQS+a6rva2VLdVW9SUDNLU6bY9UddcgPl2ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eaxEJh9AFBk0IzKJXZDzVoTqpfOElMkfXWlo1/iVCh0=; b=BiAW+zdX8aueQLQq3TaBCTavE6MbNMp7gsOZ/FQNexTdi9p4DNHZgSg17ttj6Gs9Xagz0mSAgDME/BXAeZhVKM1lUU2CUEEJSraNQjnktiPexG3Y91yNXn9GoB+YF1d/d5fuhndYQKF1OSAIssk1HGyd/7BMQN6pGsGNKDhM4xOpbz2GDXr3sdKqFJB1L55X+JEqjwwAeNJaG/unTRFiBQ0Fu+mIDiP4EpBtKYISd9dd3TtbWccCrnH0HrWh0yUYdmhU+DOMWizVxI/kGz+VSWzqvsgkClnU7M4GXS92++p9A0sXZxpKb2mN+fYK7LMbrSCmy3zzSXHauPM4Dj72tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eaxEJh9AFBk0IzKJXZDzVoTqpfOElMkfXWlo1/iVCh0=; b=ChTEVn4TnU3hfbGiyrPiJvvc4qjHJYq0XCu7+w7bRo94XByssZ8NnQYk45PtC7VEadyaWlq1fuEDX2aZty7UpwVZdzAMpe60RFgT31JzuGCBwgiO+QLWntFQL2RgSJRwY1N3SrYiVi51qKSQKEro/lhNDg06sZgzvgbZfxgz+Q4= Received: from HE1PR0801MB1788.eurprd08.prod.outlook.com (10.168.150.19) by HE1PR0801MB1627.eurprd08.prod.outlook.com (10.168.146.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.23; Mon, 20 Jan 2020 09:46:09 +0000 Received: from HE1PR0801MB1788.eurprd08.prod.outlook.com ([fe80::1822:1c81:8609:17bc]) by HE1PR0801MB1788.eurprd08.prod.outlook.com ([fe80::1822:1c81:8609:17bc%3]) with mapi id 15.20.2644.024; Mon, 20 Jan 2020 09:46:09 +0000 From: "Krzysztof Koch" To: =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= , "devel@edk2.groups.io" CC: Ard Biesheuvel , Leif Lindholm , Michael D Kinney , Sami Mujawar , Matteo Carlini , nd Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables Thread-Index: AQHVz3IKFHjMex2ItUS/OCySkAoN3afzTbjw Date: Mon, 20 Jan 2020 09:46:09 +0000 Message-ID: References: <20200109093536.76804-1-krzysztof.koch@arm.com> <9fbf43f5-4bba-dd41-4590-86b4d9ab71a3@redhat.com> In-Reply-To: <9fbf43f5-4bba-dd41-4590-86b4d9ab71a3@redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: c27ec8b0-fc4a-49fc-8406-284e1bcd7fdf.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Krzysztof.Koch@arm.com; x-originating-ip: [80.1.38.135] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1d77c5b6-11b3-47c5-4812-08d79d8d9841 X-MS-TrafficTypeDiagnostic: HE1PR0801MB1627:|HE1PR0801MB1627:|DB8PR08MB3948: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: True x-ms-oob-tlc-oobclassifiers: OLM:883;OLM:883; x-forefront-prvs: 0288CD37D9 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(366004)(376002)(136003)(396003)(39860400002)(346002)(199004)(189003)(54906003)(7696005)(33656002)(316002)(110136005)(86362001)(8676002)(55016002)(478600001)(186003)(53546011)(6506007)(4326008)(9686003)(81156014)(81166006)(966005)(26005)(8936002)(66476007)(71200400001)(76116006)(66946007)(66556008)(5660300002)(66446008)(64756008)(52536014)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0801MB1627;H:HE1PR0801MB1788.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1PLBn/O2VdzMyJJwiWf51NtQeMg5mZfOEAkmBF5hkkLqHVb1BCMVRy9wjvUQw3ueifTfXFwhrp2wKnlchKnZ8QcaGiL+ccdPSnYm6p3K3kdsURRa/gEOLXSUzdiN+sqczb3xkG/0htDcPfH/eaUaee/gwSCdCtoqh7TWUowUn0kC7ho2SCAuJ6W9nn4aJVk67Xv5dvc2ly1S5uAAOds4aS8tShS9tsWwG4vn9kOBr9DScCN5rURKf4Go4tjpxCdkLcx5k++0nNViHClWI/WElwn9kAZ9yhjHWu6O3eR0DjrUx8eu90dun0gSSjkL026dzeAJ4m75msIebC24MrzZJTluKJ7SOmQ+ILrNIRY+X6IU2tRUFKPbIwJs68XYMGAsmVBm7WfWxTTbP/qXs/7CZX7lmHCh3ef5nADSQtbGhcecuRQP+u9b77Naj3Rpk9JEVntZGgzC8p30sVG6TusJRztbYoiULCBxszj15Xd6PkO0DnZpw8n+nUMDBm/RrMT7TL8yhSSmmQ+bfdSbO6oJtA== MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1627 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Krzysztof.Koch@arm.com; Return-Path: Krzysztof.Koch@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(396003)(39860400002)(136003)(346002)(376002)(199004)(189003)(8676002)(70586007)(316002)(81156014)(36906005)(186003)(336012)(70206006)(53546011)(6506007)(5660300002)(26005)(356004)(966005)(8936002)(9686003)(55016002)(7696005)(4326008)(52536014)(478600001)(26826003)(33656002)(54906003)(2906002)(86362001)(110136005)(81166006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB8PR08MB3948;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 893754da-2d9c-42d6-476d-08d79d8d93fa X-Forefront-PRVS: 0288CD37D9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7f7bwz6WIwQA0SSoftX43I46+4YGzuPN0JDA3K9jHcjWDdLBmZScA6CR+B0e7R/L+bgfMrhrN5aLrZjPqXwYdh1KeYGD83rwlHM9WeSqqmxAWs1zW7qoJkottvxTWUOY4A75A3nqIXRLzfcDQZbc73wT/q4fg/gVyMelN+nSobj7eUP0gws+/Qwvhe6BpRW2gf4SP0/iZY9kM+sxMPID3ZGYgAjkvknPcj9IZYbCFrLufiNnvMqvjxsFN7PROEBCKC9rG6zGVn+uWPcfCZ2ZKVEmmzGan77wCSYujWJnwjAdAU1sjXUf73Z67XZB9dXUTx+1xkVbl1aZYCVfpPV3yfIWCT8+V+qFF7DqYFkNZbGOK9riBLlm9FTcpZBUwXb25x3FM+QYqYNzqr/ztDfAJyfiPGVl426T+E8Str9RLxLikF3/vJQRPibJlLUKoTxrpch2LU+g0t4HuOsyFBYlGf7oTkIy87wlJxIZyi3CCN4hhouKj8n1pF2hT208J0mkdIicfdzJ2PxeVsKHS0DJfw== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2020 09:46:16.5758 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d77c5b6-11b3-47c5-4812-08d79d8d9841 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3948 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sure! I don't mind changing the commit message. Shall I resubmit the patch? Kind regards, Krzysztof -----Original Message----- From: Philippe Mathieu-Daud=E9 =20 Sent: Monday, January 20, 2020 9:15 To: devel@edk2.groups.io; Krzysztof Koch Cc: Ard Biesheuvel ; Leif Lindholm ; Michael D Kinney ; Sami Mujawar= ; Matteo Carlini ; nd Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/ARM/ArmJ= unoDxe: Fix 'unused variable' error for DynamicTables On 1/9/20 10:35 AM, Krzysztof Koch wrote: > Fix 'mAcpiRegistration defined but not used' compiler error for=20 > Dynamic Tables Framework builds. >=20 > Do not declare the mAcpiRegistration variable in the Dynamic Tables=20 > Framework context. >=20 > An earlier patch made mAcpiRegistration variable STATIC. Reducing the Can we change "An earlier patch" -> "Commit 484a683ab9f"? > scope made scope resolution simpler, thus, the 'defined but not used' > error got raised. >=20 > Signed-off-by: Krzysztof Koch Reviewed-by: Philippe Mathieu-Daude > --- >=20 > Changes can be seen at:=20 > https://github.com/KrzysztofKoch1/edk2-platforms/tree/723_fix_unused_v > ariable_juno_dxe_v1 >=20 > Notes: > v1: > - Fix 'defined but not used' Dynamic Tables build error=20 > [Krzysztof] >=20 > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c=20 > b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > index=20 > e3b64992e02c003f7e3a6636340a6afa573f477a..cd7a205f90f131560419cfd744dd > 5c22df726c99 100644 > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > @@ -1,6 +1,6 @@ > /** @file > * > -* Copyright (c) 2013-2019, ARM Limited. All rights reserved. > +* Copyright (c) 2013-2020, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -30,9 +30,9 @@ > #ifndef DYNAMIC_TABLES_FRAMEWORK > // This GUID must match the FILE_GUID in ArmPlatformPkg/ArmJunoPkg/Acp= iTables/AcpiTables.inf > STATIC CONST EFI_GUID mJunoAcpiTableFile =3D { 0xa1dd808e, 0x1e95,=20 > 0x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } }; -#endif > - > STATIC VOID *mAcpiRegistration =3D NULL; > +#endif > + > STATIC VOID *mPciIoNotificationRegistration =3D NULL; > =20 > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20 >=20 >=20