From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.61; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=supreeth.venkatesh@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0061.outbound.protection.outlook.com [104.47.1.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8470021D2BF04 for ; Thu, 25 Jan 2018 09:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4rs03BRXamWm3ZU3x/JNR5ckoLwyd+FYJQp2H5Qv4dE=; b=rN+t2VJIo52a65SYZQz9+t0MIjVgYufGuUZ1UXRZFQyP7qBkGF0ZoUofX37oXakm2vF6ZPQs3wDou/KrP6ctDGGOacDz+1cTb4uAvU3CFUVBW3ecS/XV0MaVLAZg4trrPbR0eKc+ge+VwLrXEW3/EEC8nD2ns4y8wm1cJNt0R/0= Received: from HE1PR0802MB2316.eurprd08.prod.outlook.com (10.172.127.22) by HE1PR0802MB2202.eurprd08.prod.outlook.com (10.172.126.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Thu, 25 Jan 2018 17:45:03 +0000 Received: from HE1PR0802MB2316.eurprd08.prod.outlook.com ([fe80::5420:ce3d:e1e0:c6]) by HE1PR0802MB2316.eurprd08.prod.outlook.com ([fe80::5420:ce3d:e1e0:c6%18]) with mapi id 15.20.0444.015; Thu, 25 Jan 2018 17:45:03 +0000 From: Supreeth Venkatesh To: Marvin H?user , "edk2-devel@lists.01.org" CC: "michael.d.kinney@intel.com" , "liming.gao@intel.com" Thread-Topic: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. Thread-Index: AQHTlIUypswMo5AIJEG7XiWLeo/UbaOCLRgAgAKvZRA= Date: Thu, 25 Jan 2018 17:45:03 +0000 Message-ID: References: <20180123200303.5547-1-supreeth.venkatesh@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0802MB2202; 6:NffmxKR6sGUaYiz/NAYPTldUmc9FAO8H4yS7FaSLbRxBTdNGSNO6dGFYIZIIsJmDsnfYqIYGbksp/U0qmCrMvqUZ5myJjdCSLskrcP0W/sOWRzhXzR6ndsPuIjzb2FOFwbUDGUcnvxqIY3jOVKYMV5IhBXcBrcahahpzsiYuJ9lphVp5OL6HWAYvAgmk6Zb4r/vJeVkxKJ2rT9EJ/5nVZpuCbFqN4QX8LPul39eUtp8NcGeVT4JBx57I5NXEiwG1otLx3Uv4eaSYPOJmgwKIAGgk5VIiJeye+AoqeUvJJN/6B6V4RxMV8apY5p9wEw/l1xSZkzsMi5jjGOxQ1EAuoXFalgjdByaURWR9kVKbcTO9z5j1R+h1KYw4SBsdaMaG; 5:Lgmsc+Dvs1+Upb4a/IIxk9onDxxQQYtEMCc11bFJN++ECVMbO91U9P7FeWslBuoLAz2NZySfP7S1pHnTd0tQD58Eq8yayqpcGpiHQ9vU9R87UaWTJo/d3Vz5E5xACjzEufx0vjhIj8zfcNsVM+VbGXl1WeZEkONi8Lxc+3KrKb4=; 24:3KC5eppZV/aqFFKgwBY5enAngyPTP9SrExeLl717dDC3LUM+03c97W2cvNAibo2WaUIQwjYOnd7yNwv4FCKrurxgMUfEcO7dqjQC3gtEdh0=; 7:HM+SFYtlYAgm6CUzgWICwjeup/ksdR5x3r4VzdibENcJgW58ofgub8fzJIVPwvt1zQUyhxldOFxQFMis77TuJmxe6XsSZD1jNbxzi1xOnbW++cJRZyDAC2LTubPjvrlhxcjFxrN7IJvxNE8w+tTTC5c46ymR+Iz0WMYUZWiIZb62UZDi8kczbQIcl3IPKO42q7Aui1uo/Z7ZBCjJI1pkOXpP51P5C6um4I8FdA2G5Fn2LkB5XeIdXkoslwY4WoqN x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f20eb503-60c2-48e7-7cc1-08d5641b5d98 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:HE1PR0802MB2202; x-ms-traffictypediagnostic: HE1PR0802MB2202: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(189930954265078)(162533806227266)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231057)(2400081)(944501161)(3002001)(6055026)(6041288)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0802MB2202; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0802MB2202; x-forefront-prvs: 0563F2E8B7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(346002)(396003)(376002)(39380400002)(13464003)(40434004)(189003)(199004)(6306002)(53936002)(55016002)(9686003)(8676002)(81166006)(8936002)(81156014)(2900100001)(26005)(6346003)(186003)(68736007)(99286004)(54906003)(110136005)(6246003)(5250100002)(6436002)(2501003)(5890100001)(97736004)(25786009)(106356001)(229853002)(39060400002)(105586002)(7696005)(3280700002)(3660700001)(4326008)(66066001)(72206003)(86362001)(33656002)(966005)(45080400002)(575784001)(53546011)(59450400001)(6506007)(478600001)(76176011)(14454004)(7736002)(74316002)(305945005)(5660300001)(2906002)(2950100002)(6116002)(3846002)(102836004)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0802MB2202; H:HE1PR0802MB2316.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Supreeth.Venkatesh@arm.com; x-microsoft-antispam-message-info: s+FlkDVI1icnR1pTrpKXdI3VoFRskCnOiqQb2LLfT8xknVmDUINuHlManweTZfEj3bLA2I8mxqCW7VLnwdMjQQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f20eb503-60c2-48e7-7cc1-08d5641b5d98 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2018 17:45:03.8712 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2202 Subject: Re: [PATCH v1 1/1] MdePkg/Include: Add management mode FV file type and depex. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 17:39:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Marvin, Thanks for your comments. As per PI v1.6 specification, EFI_FV_FILETYPE_MM_CORE value is 0x0D (MM Foundation that support MM Tradit= ional Mode.) This is traditional MM mode, which ARM is not supporting at this point. We = are more interested in MM_CORE_STANDALONE mode. However, I have no issues in adding this in the patch, but would prefer if = this is added when MM traditional mode is supported in ARM. Further, w.r.t defining *_SMM_* definitions via the *_MM_* definitions. I don't want= to break backwards compatibility with existing SMM traditional mode implem= entations. I will be happy to let folks who have migrated to _MM_ definitions from _SM= M_ definitions to send the patch across. Thanks, Supreeth -----Original Message----- From: Marvin H?user [mailto:Marvin.Haeuser@outlook.com] Sent: Tuesday, January 23, 2018 6:34 PM To: edk2-devel@lists.01.org Cc: Supreeth Venkatesh ; michael.d.kinney@intel= .com; liming.gao@intel.com Subject: RE: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV f= ile type and depex. Good day, I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" (0x0= C). Furthermore, may I suggest changing the *_SMM_* definitions to be defined v= ia the *_MM_* definitions? Best regards, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Tuesday, January 23, 2018 9:03 PM > To: edk2-devel@lists.01.org > Cc: michael.d.kinney@intel.com; liming.gao@intel.com > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV > file type and depex. > > As per PI specification v1.6, > The following new file types are added: > EFI_FV_FILETYPE_MM_STANDALONE > EFI_FV_FILETYPE_MM_CORE_STANDALONE > > The following new section type is added: > EFI_SECTION_MM_DEPEX > > This patch adds the management mode FV file type and depex. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta > Signed-off-by: Supreeth Venkatesh > Reviewed-by: Jiewen Yao > --- > MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h > b/MdePkg/Include/Pi/PiFirmwareFile.h > index b982c9eda3..6086d1bb2f 100644 > --- a/MdePkg/Include/Pi/PiFirmwareFile.h > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > #define EFI_FV_FILETYPE_APPLICATION 0x09 > #define EFI_FV_FILETYPE_SMM 0x0A > +#define EFI_FV_FILETYPE_MM 0x0A > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > #define EFI_FV_FILETYPE_SMM_CORE 0x0D > +#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE; > #define EFI_SECTION_RAW 0x19 > #define EFI_SECTION_PEI_DEPEX 0x1B > #define EFI_SECTION_SMM_DEPEX 0x1C > +#define EFI_SECTION_MM_DEPEX 0x1C > > /// > /// Common section header. > -- > 2.14.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.