* [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table
@ 2021-03-22 6:12 Sunny Wang
2021-03-22 8:07 ` Ard Biesheuvel
0 siblings, 1 reply; 4+ messages in thread
From: Sunny Wang @ 2021-03-22 6:12 UTC (permalink / raw)
To: devel
Cc: Sunny Wang, Samer El-Haj-Mahmoud, Sami Mujawar, Pierre Gondois,
Ard Biesheuvel, Sunny Wang
PL011 is not a valid ACPI identifier so don't expose it as a _CID.
Since _CID (Comptable ID) is optional, let's just drop it.
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Signed-off-by: Sunny Wang <sunny.wang@arm.com>
---
Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
index c17c74e174..61353213fe 100644
--- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
+++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
@@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
// UART PL011
Device(COM0) {
Name(_HID, "ARMH0011")
- Name(_CID, "PL011")
Name(_UID, Zero)
Name(_CRS, ResourceTemplate() {
Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
--
2.31.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table
2021-03-22 6:12 [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table Sunny Wang
@ 2021-03-22 8:07 ` Ard Biesheuvel
2021-03-22 10:35 ` Sami Mujawar
2021-03-23 3:37 ` [edk2-devel] " Sunny Wang
0 siblings, 2 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2021-03-22 8:07 UTC (permalink / raw)
To: Sunny Wang
Cc: devel, Samer El-Haj-Mahmoud, Sami Mujawar, Pierre Gondois,
Ard Biesheuvel
On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>
Compatible
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> index c17c74e174..61353213fe 100644
> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
> // UART PL011
> Device(COM0) {
> Name(_HID, "ARMH0011")
> - Name(_CID, "PL011")
> Name(_UID, Zero)
> Name(_CRS, ResourceTemplate() {
> Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
> --
> 2.31.0.windows.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table
2021-03-22 8:07 ` Ard Biesheuvel
@ 2021-03-22 10:35 ` Sami Mujawar
2021-03-23 3:37 ` [edk2-devel] " Sunny Wang
1 sibling, 0 replies; 4+ messages in thread
From: Sami Mujawar @ 2021-03-22 10:35 UTC (permalink / raw)
To: Ard Biesheuvel, Sunny Wang
Cc: devel@edk2.groups.io, Samer El-Haj-Mahmoud, Pierre Gondois,
Ard Biesheuvel
Hi Sunny,
Thank you for this patch.
I will merge this change shortly with the typo fixed.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 22/03/2021, 08:07, "Ard Biesheuvel" <ardb@kernel.org> wrote:
On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>
Compatible
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> index c17c74e174..61353213fe 100644
> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
> // UART PL011
> Device(COM0) {
> Name(_HID, "ARMH0011")
> - Name(_CID, "PL011")
> Name(_UID, Zero)
> Name(_CRS, ResourceTemplate() {
> Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
> --
> 2.31.0.windows.1
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [edk2-devel] [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table
2021-03-22 8:07 ` Ard Biesheuvel
2021-03-22 10:35 ` Sami Mujawar
@ 2021-03-23 3:37 ` Sunny Wang
1 sibling, 0 replies; 4+ messages in thread
From: Sunny Wang @ 2021-03-23 3:37 UTC (permalink / raw)
To: devel@edk2.groups.io, ardb@kernel.org
Good catch, Ard. Thanks.
Since this was not on EDKII emailing list (thanks to Sami for offline pointing this out to me), I resend this patch for testing my email address and fixing this typo.
Best Regards,
Sunny Wang
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ard Biesheuvel via groups.io
Sent: Monday, March 22, 2021 4:07 PM
To: Sunny Wang <Sunny.Wang@arm.com>
Cc: devel@edk2.groups.io; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>; Pierre Gondois <Pierre.Gondois@arm.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table
On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>
Compatible
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> index c17c74e174..61353213fe 100644
> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
> // UART PL011
> Device(COM0) {
> Name(_HID, "ARMH0011")
> - Name(_CID, "PL011")
> Name(_UID, Zero)
> Name(_CRS, ResourceTemplate() {
> Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
> --
> 2.31.0.windows.1
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-23 3:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-22 6:12 [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table Sunny Wang
2021-03-22 8:07 ` Ard Biesheuvel
2021-03-22 10:35 ` Sami Mujawar
2021-03-23 3:37 ` [edk2-devel] " Sunny Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox