[PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

[PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

[AlexeiFedorov]

This patch adds UefiShellAcpiViewCommandLib INF file into
[Components] section of ShellPkg.dsc so this library can be built
in ShellPkg level build.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
---
All the changes can be reviewed at
https://github.com/AlexeiFedorov/edk2/tree/298_add_acpiview_lib_v1

Notes:
    v1:
    - add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

 ShellPkg/ShellPkg.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
index 21038ae8d596a9b5a520aca704494280cf8afd55..cb2a2422edd7b5ea6279ea81fe0ba9cc78511216 100644
--- a/ShellPkg/ShellPkg.dsc
+++ b/ShellPkg/ShellPkg.dsc
@@ -2,6 +2,7 @@
 # Shell Package
 #
 # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2018, Arm Limited. All rights reserved.<BR>
 #
 #    This program and the accompanying materials
 #    are licensed and made available under the terms and conditions of the BSD License
@@ -90,6 +91,7 @@ [Components]
   # This helps developers test changes and how they affect the package.
   #
   ShellPkg/Library/UefiShellLib/UefiShellLib.inf
+  ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
   ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
   ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'

Re: [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

[Ni, Ruiyu]

On 7/17/2018 6:59 PM, AlexeiFedorov wrote:
> This patch adds UefiShellAcpiViewCommandLib INF file into
> [Components] section of ShellPkg.dsc so this library can be built
> in ShellPkg level build.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
> ---
> All the changes can be reviewed at
> https://github.com/AlexeiFedorov/edk2/tree/298_add_acpiview_lib_v1
> 
> Notes:
>      v1:
>      - add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> 
>   ShellPkg/ShellPkg.dsc | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> index 21038ae8d596a9b5a520aca704494280cf8afd55..cb2a2422edd7b5ea6279ea81fe0ba9cc78511216 100644
> --- a/ShellPkg/ShellPkg.dsc
> +++ b/ShellPkg/ShellPkg.dsc
> @@ -2,6 +2,7 @@
>   # Shell Package
>   #
>   # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2018, Arm Limited. All rights reserved.<BR>
>   #
>   #    This program and the accompanying materials
>   #    are licensed and made available under the terms and conditions of the BSD License
> @@ -90,6 +91,7 @@ [Components]
>     # This helps developers test changes and how they affect the package.
>     #
>     ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> +  ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
>     ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>     ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>     ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray

Re: [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

[Alexei Fedorov]

Hello,


Is there anything else to be done to get this patch pushed?


Thanks.

Alexei

________________________________
From: edk2-devel <edk2-devel-bounces@lists.01.org> on behalf of Ni, Ruiyu <ruiyu.ni@Intel.com>
Sent: 18 July 2018 03:38:58
To: edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

On 7/17/2018 6:59 PM, AlexeiFedorov wrote:
> This patch adds UefiShellAcpiViewCommandLib INF file into
> [Components] section of ShellPkg.dsc so this library can be built
> in ShellPkg level build.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
> ---
> All the changes can be reviewed at
> https://github.com/AlexeiFedorov/edk2/tree/298_add_acpiview_lib_v1
>
> Notes:
>      v1:
>      - add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
>
>   ShellPkg/ShellPkg.dsc | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> index 21038ae8d596a9b5a520aca704494280cf8afd55..cb2a2422edd7b5ea6279ea81fe0ba9cc78511216 100644
> --- a/ShellPkg/ShellPkg.dsc
> +++ b/ShellPkg/ShellPkg.dsc
> @@ -2,6 +2,7 @@
>   # Shell Package
>   #
>   # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2018, Arm Limited. All rights reserved.<BR>
>   #
>   #    This program and the accompanying materials
>   #    are licensed and made available under the terms and conditions of the BSD License
> @@ -90,6 +91,7 @@ [Components]
>     # This helps developers test changes and how they affect the package.
>     #
>     ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> +  ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf
>     ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
>     ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>     ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

--
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

[Carsey, Jaben]

Alexei,

I did it, but I just realized it looks like it didn't make a change.  Shoot.  I think it was already pushed, but I am not sure.

-Jaben

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Alexei Fedorov
> Sent: Wednesday, July 25, 2018 9:29 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v1] ShellPkg: add
> UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> Importance: High
> 
> Hello,
> 
> 
> Is there anything else to be done to get this patch pushed?
> 
> 
> Thanks.
> 
> Alexei
> 
> ________________________________
> From: edk2-devel <edk2-devel-bounces@lists.01.org> on behalf of Ni, Ruiyu
> <ruiyu.ni@Intel.com>
> Sent: 18 July 2018 03:38:58
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v1] ShellPkg: add
> UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> 
> On 7/17/2018 6:59 PM, AlexeiFedorov wrote:
> > This patch adds UefiShellAcpiViewCommandLib INF file into
> > [Components] section of ShellPkg.dsc so this library can be built
> > in ShellPkg level build.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
> > ---
> > All the changes can be reviewed at
> > https://github.com/AlexeiFedorov/edk2/tree/298_add_acpiview_lib_v1
> >
> > Notes:
> >      v1:
> >      - add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> >
> >   ShellPkg/ShellPkg.dsc | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> > index
> 21038ae8d596a9b5a520aca704494280cf8afd55..cb2a2422edd7b5ea6279ea81f
> e0ba9cc78511216 100644
> > --- a/ShellPkg/ShellPkg.dsc
> > +++ b/ShellPkg/ShellPkg.dsc
> > @@ -2,6 +2,7 @@
> >   # Shell Package
> >   #
> >   # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2018, Arm Limited. All rights reserved.<BR>
> >   #
> >   #    This program and the accompanying materials
> >   #    are licensed and made available under the terms and conditions of the
> BSD License
> > @@ -90,6 +91,7 @@ [Components]
> >     # This helps developers test changes and how they affect the package.
> >     #
> >     ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> > +
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman
> dLib.inf
> >     ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> >     ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> >     ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> >
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> --
> Thanks,
> Ray
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH v1] ShellPkg: add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc

[Carsey, Jaben]

Never mind most of that.  I have to figure out how to configure gitk to show .dsc changes.  It's all good.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Carsey, Jaben
> Sent: Wednesday, July 25, 2018 1:47 PM
> To: Alexei Fedorov <Alexei.Fedorov@arm.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH v1] ShellPkg: add
> UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> Importance: High
> 
> Alexei,
> 
> I did it, but I just realized it looks like it didn't make a change.  Shoot.  I think it
> was already pushed, but I am not sure.
> 
> -Jaben
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Alexei Fedorov
> > Sent: Wednesday, July 25, 2018 9:29 AM
> > To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-devel@lists.01.org
> > Subject: Re: [edk2] [PATCH v1] ShellPkg: add
> > UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> > Importance: High
> >
> > Hello,
> >
> >
> > Is there anything else to be done to get this patch pushed?
> >
> >
> > Thanks.
> >
> > Alexei
> >
> > ________________________________
> > From: edk2-devel <edk2-devel-bounces@lists.01.org> on behalf of Ni,
> Ruiyu
> > <ruiyu.ni@Intel.com>
> > Sent: 18 July 2018 03:38:58
> > To: edk2-devel@lists.01.org
> > Subject: Re: [edk2] [PATCH v1] ShellPkg: add
> > UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> >
> > On 7/17/2018 6:59 PM, AlexeiFedorov wrote:
> > > This patch adds UefiShellAcpiViewCommandLib INF file into
> > > [Components] section of ShellPkg.dsc so this library can be built
> > > in ShellPkg level build.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
> > > ---
> > > All the changes can be reviewed at
> > > https://github.com/AlexeiFedorov/edk2/tree/298_add_acpiview_lib_v1
> > >
> > > Notes:
> > >      v1:
> > >      - add UefiShellAcpiViewCommandLib.inf to ShellPkg.dsc
> > >
> > >   ShellPkg/ShellPkg.dsc | 2 ++
> > >   1 file changed, 2 insertions(+)
> > >
> > > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> > > index
> >
> 21038ae8d596a9b5a520aca704494280cf8afd55..cb2a2422edd7b5ea6279ea81f
> > e0ba9cc78511216 100644
> > > --- a/ShellPkg/ShellPkg.dsc
> > > +++ b/ShellPkg/ShellPkg.dsc
> > > @@ -2,6 +2,7 @@
> > >   # Shell Package
> > >   #
> > >   # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> > > +# Copyright (c) 2018, Arm Limited. All rights reserved.<BR>
> > >   #
> > >   #    This program and the accompanying materials
> > >   #    are licensed and made available under the terms and conditions of
> the
> > BSD License
> > > @@ -90,6 +91,7 @@ [Components]
> > >     # This helps developers test changes and how they affect the package.
> > >     #
> > >     ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> > > +
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman
> > dLib.inf
> > >     ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> > >     ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> > >     ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> > >
> > Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> >
> > --
> > Thanks,
> > Ray
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> > IMPORTANT NOTICE: The contents of this email and any attachments are
> > confidential and may also be privileged. If you are not the intended
> recipient,
> > please notify the sender immediately and do not disclose the contents to
> any
> > other person, use it for any purpose, or store or copy the information in
> any
> > medium. Thank you.
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel