From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=104.47.1.74; helo=eur01-ve1-obe.outbound.protection.outlook.com; envelope-from=evan.lloyd@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0074.outbound.protection.outlook.com [104.47.1.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 843C222280C30 for ; Wed, 3 Jan 2018 08:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=n3wsDw/sPgcBbLkAczpc3FzLs2kH0MU5gL7fjuVpSbk=; b=qZMw7zFKqIoOQJXDQnL1ahePr9T4rsC7bX/uj5FL9hPYfSrOLZjQZ4QhQKdmq2CtbmrN+FqMxVR3u+j0ktZ3rwDCmGugzpaZQ+Y47A4zBaVAMRgLqeJNduZ19VLgxa1ZRlYMbBhqA+0lBCwF17lcRT3nUmEkzLM1jObAe6Tj26w= Received: from HE1PR08MB2684.eurprd08.prod.outlook.com (10.170.248.27) by HE1PR08MB0491.eurprd08.prod.outlook.com (10.161.120.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Wed, 3 Jan 2018 16:06:13 +0000 Received: from HE1PR08MB2684.eurprd08.prod.outlook.com ([fe80::2cba:9ca8:24d:df80]) by HE1PR08MB2684.eurprd08.prod.outlook.com ([fe80::2cba:9ca8:24d:df80%13]) with mapi id 15.20.0366.007; Wed, 3 Jan 2018 16:06:13 +0000 From: Evan Lloyd To: Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Matteo Carlini , "eif.lindholm@linaro.org" , nd Thread-Topic: [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard Thread-Index: AQHTe/Ci0O2pieDAhU+aG11EAA22cKNggPuwgABB1YCAAW0o4A== Date: Wed, 3 Jan 2018 16:06:13 +0000 Message-ID: References: <20171222183418.8616-1-evan.lloyd@arm.com> <20171222183418.8616-2-evan.lloyd@arm.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Evan.Lloyd@arm.com; x-originating-ip: [217.140.96.140] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR08MB0491; 7:Q77Cf9v0eKNo83VBoad48pXAB+ZZUHvNiIF/gUXi1AFvGhDu5XX3uCKgrQGs2Bg6ecmiL7sZuK6U0/lF1tym0adlp9Z0K9FJnHuuOJT7zyzU59ylF0yoRZoW8/Hu2AI1W41UEZQ/5OKZOh3R3Nyew9QVzaqLEILGfuueq+rocHzNVZCRi7bjgKShAknY2Y9oIplO1xJ2WZ2YBNGtRYk/VBdMVGnZPYEagDpfIWPLkmzmOVnwTlfL4/3yGR5ejp64 x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9c079934-389b-420e-ae63-08d552c3e9df x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060); SRVR:HE1PR08MB0491; x-ms-traffictypediagnostic: HE1PR08MB0491: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(162533806227266); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501075)(93006095)(93001095)(10201501046)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR08MB0491; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR08MB0491; x-forefront-prvs: 0541031FF6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(39860400002)(396003)(346002)(376002)(24454002)(189003)(199004)(13464003)(5250100002)(316002)(305945005)(74316002)(97736004)(3280700002)(99286004)(229853002)(3660700001)(6916009)(2950100002)(93886005)(25786009)(6246003)(4326008)(14454004)(7736002)(9686003)(2900100001)(66066001)(81166006)(8676002)(81156014)(2906002)(6116002)(8936002)(53546011)(105586002)(3846002)(6506007)(478600001)(86362001)(102836004)(72206003)(68736007)(6436002)(53936002)(54906003)(33656002)(106356001)(55016002)(5660300001)(76176011)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB0491; H:HE1PR08MB2684.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Wsqu1Hnv4tS8LWmF1wBEVJAAmr3/37yvGBgw3nVXO9i/ZC0OK9wEFYJ4gBpFGZu50oOaj1T69MicoyUgTL1nsg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c079934-389b-420e-ae63-08d552c3e9df X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2018 16:06:13.7237 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0491 Subject: Re: [PATCH v2 01/13] ArmPlatformPkg: Tidy Lcd code: Coding standard X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jan 2018 16:01:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgQXJkDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQXJkIEJpZXNo ZXV2ZWwgW21haWx0bzphcmQuYmllc2hldXZlbEBsaW5hcm8ub3JnXQ0KPiBTZW50OiAwMiBKYW51 YXJ5IDIwMTggMTU6MjENCj4gVG86IEV2YW4gTGxveWQgPEV2YW4uTGxveWRAYXJtLmNvbT4NCj4g Q2M6IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnOyBNYXR0ZW8gQ2FybGluaSA8TWF0dGVvLkNhcmxp bmlAYXJtLmNvbT47DQo+IGVpZi5saW5kaG9sbUBsaW5hcm8ub3JnOyBuZCA8bmRAYXJtLmNvbT4N Cj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAwMS8xM10gQXJtUGxhdGZvcm1Qa2c6IFRpZHkgTGNk IGNvZGU6IENvZGluZw0KPiBzdGFuZGFyZA0KPiANCj4gT24gMiBKYW51YXJ5IDIwMTggYXQgMTU6 MTEsIEV2YW4gTGxveWQgPEV2YW4uTGxveWRAYXJtLmNvbT4gd3JvdGU6DQo+ID4gSGkgQXJkLg0K PiA+IE9uZSBhaW0gb2YgdGhlc2UgY2hhbmdlcyBpcyB0byBnZXQgdGhvc2UgZmlsZXMgd2UgaGF2 ZSB0byBwbGF5IHdpdGggaW50byBhDQo+IHN0YXRlIHdoZXJlIGEgYmVhdXRpZmllciBsaWtlIGlu ZGVudCwgYXN0eWxlLCAgb3IgY2xhbmctZm9ybWF0IGNhbiBiZSB1c2VkIHRvDQo+IGhlbHAgdGlk eSBvdXIgY2hhbmdlcy4gIChOT1RFLCB3ZSBkbyBub3QgaGF2ZSB0aGF0IGZ1bGx5IHdvcmtpbmcg eWV0LCBidXQNCj4gdGhleSBkbyBoZWxwLikgIEluIGEgd29ybGQgd2hlcmUgd2UgaGF2ZSB0byBw bGF5IHdpdGggc2V2ZXJhbCBjb250cmFkaWN0b3J5DQo+IGZvcm1hdHRpbmcgc3RhbmRhcmRzIChu b3QganVzdCBFREsyKSB0aGVuIGFueXRoaW5nIHRoYXQgY2FuIGhlbHAgaXMNCj4gd2VsY29tZS4N Cj4gPiBPZiB0aGUgY2hhbmdlcyBtYWRlOg0KPiA+ICAgICAgICAgRml4aW5nIHRoZSBpbmNsdWRl IGd1YXJkczogaXMgYSBzbWFsbCBpbXByb3ZlbWVudC4gIChJZGVhbGx5DQo+IHBhdGNoY2hlY2sg c2hvdWxkIHJlamVjdCB0aGVzZS4pDQo+ID4gICAgICAgICBSZWR1Y2luZyBsaW5lcyB0byA4MCBj b2x1bW5zOiBtYWtlcyBMZWlmIChhdCBsZWFzdCkgaGFwcHksIGFuZCBhbGlnbnMNCj4gd2l0aCBm b3JtYXR0ZXIgYmVoYXZpb3VyLg0KPiA+ICAgICAgICAgQ29ycmVjdGluZyBEb3h5Z2VuIGZvcm1h dCBjb21tZW50czogcHJldmVudHMgRG94eWdlbiBnZW5lcmF0aW5nDQo+IGdpYmJlcmlzaC4NCj4g PiAgICAgICAgIFNwYWNlcyBiZWZvcmUgJygnOiBNYWludGFpbnMgY29uc2lzdGVuY3ksIGFuZCBh bGlnbnMgd2l0aCBkZXNpcmVkDQo+IGZvcm1hdHRlciBiZWhhdmlvdXIuDQo+ID4NCj4gDQo+IFRv IGJlIGhvbmVzdCwgdGhpcyBpcyBhbiBhc3BlY3QgSSBoYWRuJ3QgY29uc2lkZXJlZCBhdCBhbGwu IEl0IHdvdWxkIGJlDQo+IGV4Y2VsbGVudCBpZiB3ZSBjb3VsZCB1c2UgdG9vbGluZyB0byBmaXgg b3VyIGNvZGUgd3J0IHRvIGNvZGluZyBzdHlsZSwgYW5kIGlmDQo+IGNoYW5nZXMgc3VjaCBhcyB0 aGVzZSBicmluZyB1cyBjbG9zZXIgdG8gdGhhdCBnb2FsLCBJIGFtIGFsbCBmb3IgaXQuDQoNCiBb W0V2YW4gTGxveWRdXSBFeGNlbGxlbnQgbmV3cyAtIG5vdyB5b3Uga25vdyB3aHkgd2Ugd2VyZSBk b2luZyBhbGwgdGhvc2UgaW5leHBsaWNhYmxlIHRoaW5ncy4gIEkgcmVhbGx5IHNob3VsZCBoYXZl IGV4cGxhaW5lZCB0aGlzIG1vcmUgY2xlYXJseSBiZWZvcmUuDQoNCj4gDQo+IFdvdWxkIGl0IGJl IGZlYXNpYmxlIHRvIHJ1biB0aGF0IG9uIGVudGlyZSBwYWNrYWdlcywgaS5lLiwgQXJtUGtnIGFu ZA0KPiBBcm1QbGF0Zm9ybVBrZz8NCg0KIFtbRXZhbiBMbG95ZF1dICBBcyBpdCBzdGFuZHMsIG5v bmUgb2YgdGhlIHRvb2xzIGlzIHZlcnkgaGFwcHkgd2l0aCB0aGUgRURLMiBzdHlsZSwgYW5kIHRo ZXkgdGVuZCB0byBtaXNzIG1lZXRpbmcgaXQgaW4gZGlmZmVyZW50IHdheXMuDQooQXMgYW4gYXNp ZGUgLSBvbmUgY29tbW9uIHByb2JsZW0gaXMgdGhhdCBJIGhhdmUgZm91bmQgbm8gbWVhbnMgb2Yg Y29lcmNpbmcgdGhlbSB0byBmb3JjZSB0aGUgIik7IiBhdCB0aGUgZW5kIG9mIGEgZnVuY3Rpb24g Y2FsbCBvbnRvIGl0cyBvd24gbGluZS4gIFlvdXIgcmVjZW50IENDUyBjaGFuZ2UgdG8gbWFrZSB0 aGF0IG9wdGlvbmFsIGhlbHBzIGEgbG90IHdpdGggdGhhdC4pICBIb3dldmVyLCBJIGhhdmUgc28g ZmFyIGZhaWxlZCB0byBnZXQgYW55IG9mIHRoZSBhYm92ZSB0b29scyB0byBkbyBleGFjdGx5IHdo YXQgd2Ugd2FudC4gIEFsbCB0aGF0IEkgY2FuIGFjaGlldmUgaXMgdG8gZ2VuZXJhdGUgYSBmb3Jt YXR0ZWQgdmlldyB0aGF0IGNhbiBiZSBjb21wYXJlZCBhZ2FpbnN0IHRoZSBvcmlnaW5hbCB3aXRo IGEgdmlzdWFsIHByb2dyYW0gbGlrZSBrZGlmZjMgLSBoaWdobGlnaHRpbmcgc29tZSBmb3JtYXR0 aW5nIGltcHJvdmVtZW50cyB0aGF0IGNhbiB0aGVuIGJlIGNvcGllZCBhY3Jvc3MsIHdoaWxzdCB0 aGUgbWlzbWF0Y2hlcyBjYW4gYmUgaWdub3JlZC4gIFRoaXMgaXMgbm90IG11Y2gsIGJ1dCBpdCBk b2VzIGhlbHAsIGVzcGVjaWFsbHkgd2l0aCBzcGFjaW5nIGFuZCBsaW5lIGxlbmd0aCBlcnJvcnMu DQoNCklmIHlvdSBhcmUgaW50ZXJlc3RlZCwgSSBhbSB2ZXJ5IGhhcHB5IHRvIG1ha2UgdGhvc2Ug cGFyYW1ldGVyIGZpbGVzIHRoYXQgSSBoYXZlIGF2YWlsYWJsZSBmb3IgY29uc2lkZXJhdGlvbiwg YXMgbG9uZyBhcyBldmVyeW9uZSB1bmRlcnN0YW5kcyBob3cgZmFyIGZyb20gZnVsbHkgY29tcGxp YW50IHRoZXkgYXJlLCBhbmQgdGhhdCB0aGVpciBsaW1pdGF0aW9ucyBhcmUgbWFuaWZvbGQuICBJ IHN1c3BlY3QgdGhlIHBhdGggdG8gYSBmdWxseSBhdXRvbWF0ZWQgcmVmb3JtYXQgd2lsbCBiZSBh IGxvbmcgYW5kIHdpbmRpbmcgcm9hZC4gIFRoZSBiZXN0IGJldCBtaWdodCBiZSB0byBhY3R1YWxs eSBjaGFuZ2Ugb25lIG9mIHRoZSBPcGVuIFNvdXJjZSB0b29scyB0byBzdWl0IHVzLCBidXQgSSBj ZXJ0YWlubHkgZG9uJ3Qga25vdyBvZiBhbnlvbmUgd2l0aCB0aGUgbGVpc3VyZSB0aW1lIGF2YWls YWJsZSB0byB0YWtlIHRoYXQgb24uDQoNClJlZ2FyZHMsDQpFdmFuDQoNCj4gDQouLi4NCj4gPj4g PiAtLQ0KPiA+PiA+IEd1aWQoIkNFMTY1NjY5LTNFRjMtNDkzRi1CODVELTYxOTBFRTVCOTc1OSIp DQo+ID4+ID4NCg==