From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=40.107.3.40; helo=eur03-am5-obe.outbound.protection.outlook.com; envelope-from=thomas.abraham@arm.com; receiver=edk2-devel@lists.01.org Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30040.outbound.protection.outlook.com [40.107.3.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5789C2215BD92 for ; Mon, 29 Jan 2018 05:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vUuotk69emUT1hnCNbFJd0eN7Den39PfOoEoJCtTbVE=; b=imiU6LQ9DFh4Vg8j727P6huCyQVcjn5m4aulYXtqFRSZZtpA7zPtcQQcAvbhsklffyA78AsdH/4qrfsS2sqtOBnofokVaLRYgsItVUCYfVXX7oEYj7WFuLTqNdfkpRSl2N8Umqcutsz5XpOscdR9Q2rkxr+NK8o5xrMSmCAlIFw= Received: from HE1PR08MB2923.eurprd08.prod.outlook.com (10.170.245.152) by HE1PR08MB0890.eurprd08.prod.outlook.com (10.164.53.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Mon, 29 Jan 2018 13:12:35 +0000 Received: from HE1PR08MB2923.eurprd08.prod.outlook.com ([10.170.245.152]) by HE1PR08MB2923.eurprd08.prod.outlook.com ([10.170.245.152]) with mapi id 15.20.0444.016; Mon, 29 Jan 2018 13:12:35 +0000 From: Thomas Abraham To: "edk2-devel@lists.01.org" CC: "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" Thread-Topic: [edk2] [PATCH] Platform/ARM/VExpress: refine the check for DVI support Thread-Index: AQHTlsfg+PwdMz/qFEyDRqAwy2LooKOK0clg Date: Mon, 29 Jan 2018 13:12:35 +0000 Message-ID: References: <1516986299-1616-1-git-send-email-thomas.abraham@arm.com> In-Reply-To: <1516986299-1616-1-git-send-email-thomas.abraham@arm.com> Accept-Language: en-IN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=thomas.abraham@arm.com; x-originating-ip: [217.140.105.40] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR08MB0890; 7:1TaBJQaUPd97ZSM+jCrVl+nZ2Qm1ujehxI16+3Ff1dZuUjYkjZGnZEPJuo0pWM5r5SEaGgvFDcmfxn9HAGK+44a4o7+oMwNq0RMjXozfsFVeVWc5S06N4KOkxJpsfourci2TDKBOgEHlrt6KQpEkVuQ3/DKUcBymGuJhz8PLigKFC5z55VAcLBrh8Y/9fhyhc0fhRTwraS048f71zvgykN5e6Up6BtmpulrzEB8gUlLdHT41ITyA7WmPvNCVszrh x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4df6307c-c3f9-4e46-0a7d-08d56719f6d9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:HE1PR08MB0890; x-ms-traffictypediagnostic: HE1PR08MB0890: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(3231101)(944501161)(10201501046)(6055026)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR08MB0890; BCL:0; PCL:0; RULEID:; SRVR:HE1PR08MB0890; x-forefront-prvs: 0567A15835 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(346002)(376002)(39380400002)(189003)(199004)(40434004)(97736004)(53546011)(76176011)(316002)(14454004)(26005)(77096007)(5890100001)(3280700002)(2906002)(3660700001)(8936002)(6506007)(99286004)(68736007)(7696005)(81166006)(102836004)(186003)(54906003)(59450400001)(2501003)(478600001)(8676002)(81156014)(86362001)(4326008)(55016002)(305945005)(5660300001)(5640700003)(2950100002)(229853002)(6916009)(105586002)(25786009)(53936002)(2900100001)(6246003)(7736002)(6436002)(33656002)(2351001)(3846002)(106356001)(6116002)(9686003)(66066001)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR08MB0890; H:HE1PR08MB2923.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: DPt2AcpPk4kLwXNlFX/MDstPv9poasy+WMdbijNX82YBeicbFL0BborS+sHFYnzdUNYq19Rl6seUFZABvg3Blw== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4df6307c-c3f9-4e46-0a7d-08d56719f6d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2018 13:12:35.4493 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB0890 Subject: Re: [PATCH] Platform/ARM/VExpress: refine the check for DVI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 13:07:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Leif, > On Fri, Jan 26, 2018 at 10:34 PM, Thomas Abraham = wrote: > The base models could have different values for the revision ID field in = the > System ID register. Base models do not have support for DVI and so the re= vision > ID field should also be masked out when checking for the presence of DVI > support. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Thomas Abraham > --- > .../VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c = | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmV > Express.c > b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmV > Express.c > index 3f3ceb3..89ba130 100644 > --- > a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmV > Express.c > +++ > b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdAr > +++ mVExpress.c > @@ -264,7 +264,7 @@ LcdPlatformSetMode ( > SysId =3D MmioRead32 (ARM_VE_SYS_ID_REG); > if (SysId !=3D ARM_RTSM_SYS_ID) { > // Take out the FVP GIC variant to reduce the permutations. > - SysId &=3D ~ARM_FVP_SYS_ID_VARIANT_MASK; > + SysId &=3D ~(ARM_FVP_SYS_ID_VARIANT_MASK | > ARM_FVP_SYS_ID_REV_MASK); > if (SysId !=3D ARM_FVP_BASE_BOARD_SYS_ID) { > // Set the DVI into the new mode > Status =3D ArmPlatformSysConfigSet (SYS_CFG_DVIMODE, > mResolutions[ModeNumber].Mode); > -- Sorry, I don't mean to be pushy -- just wanted to know if there are any com= ments on this patch. This patch fixes a check on system ID register value w= ithout which an assert is triggered on FVP platforms. This fix is also requ= ired for an upcoming release for fvp platforms. Thanks, Thomas. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.